From: David Gibson <david@gibson.dropbear.id.au>
To: Greg Kurz <groug@kaod.org>
Cc: "Daniel Henrique Barboza" <danielhb413@gmail.com>,
qemu-ppc@nongnu.org, "Cédric Le Goater" <clg@kaod.org>,
qemu-devel@nongnu.org
Subject: Re: [PATCH 01/14] spapr: Simplify error handling in spapr_phb_realize()
Date: Fri, 14 Aug 2020 13:32:16 +1000 [thread overview]
Message-ID: <20200814033216.GB12805@yekko.fritz.box> (raw)
In-Reply-To: <20200813233927.52e38400@bahia.lan>
[-- Attachment #1: Type: text/plain, Size: 2111 bytes --]
On Thu, Aug 13, 2020 at 11:39:27PM +0200, Greg Kurz wrote:
> On Thu, 13 Aug 2020 16:57:04 -0300
> Daniel Henrique Barboza <danielhb413@gmail.com> wrote:
>
> > Greg,
> >
> > This patch is breaking guest startup in ppc-for-5.2 for me. The process
> > gives an almost instant segfault. Here's what I'm doing:
> >
>
> Ok, this is because this patch should have been applied after
> the "spapr: Cleanups for XIVE" series:
>
> http://patchwork.ozlabs.org/project/qemu-devel/cover/159679991916.876294.8967140647442842745.stgit@bahia.lan/
>
> specifically this patch:
>
> http://patchwork.ozlabs.org/project/qemu-devel/patch/159679993438.876294.7285654331498605426.stgit@bahia.lan/
>
> which prevents of a bogus error path in kvmppc_xive_source_reset_one() to
> be taken:
Oops, yeah, I realized this halfway through and fixed it up, but
forgot to push out the updated version.
>
> /* The KVM XIVE device is not in use */
> if (xive->fd == -1) {
> return -ENODEV; <== this should return 0 to avoid the segfault, but
> the real issue is that kvmppc_xive_*() calls
> shouldn't be called at all when we don't have
> a KVM XIVE device. This is the purpose of the
> "spapr: Cleanups for XIVE" series.
> }
>
> I should maybe have added some Based-on: tag to make it clearer...
That would have helped, yes.
>
> David,
>
> Can you apply the series the other way around ?
>
> First :
>
> "spapr: Cleanups for XIVE"
>
> http://patchwork.ozlabs.org/project/qemu-devel/cover/159679991916.876294.8967140647442842745.stgit@bahia.lan/
>
> Then :
>
> "ppc/spapr: Error handling fixes and cleanups"
>
> http://patchwork.ozlabs.org/project/qemu-devel/cover/159707843034.1489912.1082061742626355958.stgit@bahia.lan/
>
> Sorry everyone for the inconvenience.
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-08-14 4:02 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-10 16:53 [PATCH 00/14] ppc/spapr: Error handling fixes and cleanups Greg Kurz
2020-08-10 16:53 ` [PATCH 01/14] spapr: Simplify error handling in spapr_phb_realize() Greg Kurz
2020-08-13 7:12 ` David Gibson
2020-08-13 19:57 ` Daniel Henrique Barboza
2020-08-13 21:39 ` Greg Kurz
2020-08-14 3:32 ` David Gibson [this message]
2020-08-10 16:54 ` [PATCH 02/14] spapr/xive: Rework error handling of kvmppc_xive_cpu_connect() Greg Kurz
2020-08-13 7:14 ` David Gibson
2020-08-10 16:54 ` [PATCH 03/14] spapr/xive: Rework error handling of kvmppc_xive_source_reset() Greg Kurz
2020-08-13 10:15 ` David Gibson
2020-08-10 16:54 ` [PATCH 04/14] spapr/xive: Rework error handling of kvmppc_xive_mmap() Greg Kurz
2020-08-13 10:19 ` David Gibson
2020-08-10 16:54 ` [PATCH 05/14] spapr/xive: Rework error handling of kvmppc_xive_cpu_[gs]et_state() Greg Kurz
2020-08-13 10:22 ` David Gibson
2020-08-10 16:54 ` [PATCH 06/14] spapr/xive: Rework error handling of kvmppc_xive_[gs]et_queue_config() Greg Kurz
2020-08-13 10:23 ` David Gibson
2020-08-10 16:54 ` [PATCH 07/14] spapr/xive: Rework error handling in kvmppc_xive_get_queues() Greg Kurz
2020-08-13 10:24 ` David Gibson
2020-08-10 16:54 ` [PATCH 08/14] spapr/xive: Rework error handling of kvmppc_xive_set_source_config() Greg Kurz
2020-08-13 10:25 ` David Gibson
2020-08-10 16:54 ` [PATCH 09/14] spapr/kvm: Fix error handling in kvmppc_xive_pre_save() Greg Kurz
2020-08-13 10:28 ` David Gibson
2020-08-10 16:55 ` [PATCH 10/14] spapr/xive: Fix error handling in kvmppc_xive_post_load() Greg Kurz
2020-08-13 10:30 ` David Gibson
2020-08-10 16:55 ` [PATCH 11/14] ppc/xive: Fix error handling in vmstate_xive_tctx_*() callbacks Greg Kurz
2020-08-13 11:05 ` David Gibson
2020-08-10 16:55 ` [PATCH 12/14] spapr/xive: Simplify error handling in kvmppc_xive_connect() Greg Kurz
2020-08-13 11:07 ` David Gibson
2020-08-10 16:55 ` [PATCH 13/14] ppc/xive: Simplify error handling in xive_tctx_realize() Greg Kurz
2020-08-13 11:07 ` David Gibson
2020-08-10 16:55 ` [PATCH 14/14] spapr/xive: Simplify error handling of kvmppc_xive_cpu_synchronize_state() Greg Kurz
2020-08-13 11:09 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200814033216.GB12805@yekko.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).