From: Rohit Shinde <rohit.shinde12194@gmail.com>
To: qemu-devel@nongnu.org
Cc: Rohit Shinde <rohit.shinde12194@gmail.com>,
armbru@redhat.com, mdroth@linux.vnet.ibm.com
Subject: [PATCH] Fixes: Fallthrough warning on line 270 of qemu/qapi/opts-visitor.c
Date: Sat, 15 Aug 2020 06:00:46 -0700 [thread overview]
Message-ID: <20200815130046.5344-1-rohit.shinde12194@gmail.com> (raw)
Added the fallthrough comment so that the compiler doesn't emit an error on compiling with the -Wimplicit-fallthrough flag.
Signed off by: Rohit Shinde
---
qapi/opts-visitor.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c
index 7781c23a42..43cf60d3a0 100644
--- a/qapi/opts-visitor.c
+++ b/qapi/opts-visitor.c
@@ -266,6 +266,7 @@ opts_next_list(Visitor *v, GenericList *tail, size_t size)
}
ov->list_mode = LM_IN_PROGRESS;
/* range has been completed, fall through in order to pop option */
+ __attribute__((fallthrough));
case LM_IN_PROGRESS: {
const QemuOpt *opt;
--
2.25.1
next reply other threads:[~2020-08-15 14:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-15 13:00 Rohit Shinde [this message]
2020-08-15 15:03 ` [PATCH] Fixes: Fallthrough warning on line 270 of qemu/qapi/opts-visitor.c no-reply
2020-08-15 15:16 ` no-reply
2020-08-15 15:24 ` Philippe Mathieu-Daudé
2020-08-15 17:14 ` Rohit Shinde
-- strict thread matches above, loose matches on Subject: below --
2020-08-15 15:11 Rohit Shinde
2020-08-15 15:26 ` Philippe Mathieu-Daudé
2020-08-15 16:12 ` no-reply
2020-08-15 15:12 Rohit Shinde
2020-08-15 15:28 ` Philippe Mathieu-Daudé
2020-08-15 16:30 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200815130046.5344-1-rohit.shinde12194@gmail.com \
--to=rohit.shinde12194@gmail.com \
--cc=armbru@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).