From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66AFAC433DF for ; Mon, 17 Aug 2020 06:50:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3277F20758 for ; Mon, 17 Aug 2020 06:50:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="heeOEYsL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3277F20758 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42882 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k7Yyj-0002KM-Gj for qemu-devel@archiver.kernel.org; Mon, 17 Aug 2020 02:50:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47174) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k7Yxe-0001OD-AF for qemu-devel@nongnu.org; Mon, 17 Aug 2020 02:49:38 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:37402 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k7Yxc-0007kS-N2 for qemu-devel@nongnu.org; Mon, 17 Aug 2020 02:49:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597646975; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qSNqbd8xdlm+KvS2CRU8j/CZdv8Su5c3Xq64Mqa9GRc=; b=heeOEYsL2XZ9jG3XXSalwMc+s35Gx4pUFrqYGtAmETOqPF4FsJ8iBCZlimwgX4yajqlahA dO2lsLxKrGRHB+t/cLqoxJXCX+eCYiBvcq4CLrT7Heg9yy9z2rIS3Q+5x8NjfXXh4gzhvV dcj6srR4K6E6QzF5QmauhQr7AFdoOH4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-167-ey04bhYBMfek47yz1D7QWg-1; Mon, 17 Aug 2020 02:49:31 -0400 X-MC-Unique: ey04bhYBMfek47yz1D7QWg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9CE0E81F007; Mon, 17 Aug 2020 06:49:30 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-195.ams2.redhat.com [10.36.112.195]) by smtp.corp.redhat.com (Postfix) with ESMTP id 380E3100EBA5; Mon, 17 Aug 2020 06:49:29 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 121FC1753B; Mon, 17 Aug 2020 08:49:29 +0200 (CEST) Date: Mon, 17 Aug 2020 08:49:29 +0200 From: Gerd Hoffmann To: Chen Qun Subject: Re: [PATCH 11/11] hw/display/vga:Remove redundant statement in vga_draw_graphic() Message-ID: <20200817064929.4ankvfxxiqa4adgo@sirius.home.kraxel.org> References: <20200813073712.4001404-1-kuhn.chenqun@huawei.com> <20200813073712.4001404-12-kuhn.chenqun@huawei.com> MIME-Version: 1.0 In-Reply-To: <20200813073712.4001404-12-kuhn.chenqun@huawei.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=207.211.31.120; envelope-from=kraxel@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/17 00:24:04 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Euler Robot , pannengyuan@huawei.com, qemu-devel@nongnu.org, zhang.zhanghailiang@huawei.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Aug 13, 2020 at 03:37:12PM +0800, Chen Qun wrote: > Clang static code analyzer show warning: > hw/display/vga.c:1677:9: warning: Value stored to 'update' is never read > update = full_update; > ^ ~~~~~~~~~~~ > > Reported-by: Euler Robot > Signed-off-by: Chen Qun Reviewed-by: Gerd Hoffmann