From: Klaus Jensen <its@irrelevant.dk>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Emanuele Giuseppe Esposito <e.emanuelegiuseppe@gmail.com>,
QEMU Developers <qemu-devel@nongnu.org>,
"Michael S . Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] pci_dma_rw: return correct value instead of 0
Date: Mon, 17 Aug 2020 09:04:08 +0200 [thread overview]
Message-ID: <20200817070408.GA17572@apples.localdomain> (raw)
In-Reply-To: <CAFEAcA_XfRWFSp3X03=g_FrjL3eqRG_DY8AZE1crxDGKnJKNnQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 920 bytes --]
On Jul 30 09:48, Peter Maydell wrote:
> On Wed, 29 Jul 2020 at 23:19, Emanuele Giuseppe Esposito
> <e.emanuelegiuseppe@gmail.com> wrote:
> >
> > pci_dma_rw currently always returns 0, regardless
> > of the result of dma_memory_rw. Adjusted to return
> > the correct value.
> >
> > Signed-off-by: Emanuele Giuseppe Esposito <e.emanuelegiuseppe@gmail.com>
>
> We also have the equivalent patch from Klaus Jensen back in 2019
> which got reviewed at the time but seems to have gotten lost along the way:
> https://patchwork.kernel.org/patch/11184911/
>
> thanks
> -- PMM
>
Yes, I posted this a while back because I need that return value in the
emulated nvme device - so please don't make it void ;)
My patch was part of a series that has not gone in yet, but I can resend
seperately - or you can just apply the patch from Emanuele. It's no
biggie to me as long as the fix is there!
Klaus
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-08-17 7:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 22:17 [PATCH] pci_dma_rw: return correct value instead of 0 Emanuele Giuseppe Esposito
2020-07-30 7:41 ` Stefano Garzarella
2020-07-30 8:50 ` Emanuele Giuseppe Esposito
2020-07-30 10:41 ` Stefano Garzarella
2020-07-30 8:58 ` Peter Maydell
2020-07-30 10:48 ` Stefano Garzarella
2020-07-30 8:48 ` Peter Maydell
2020-08-17 7:04 ` Klaus Jensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817070408.GA17572@apples.localdomain \
--to=its@irrelevant.dk \
--cc=e.emanuelegiuseppe@gmail.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).