qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: fam@euphon.net, kwolf@redhat.com, vsementsov@virtuozzo.com,
	armbru@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com,
	stefanha@redhat.com, den@openvz.org
Subject: [PATCH v3 04/12] block/io: bdrv_wait_serialising_requests_locked: drop extra bs arg
Date: Mon, 17 Aug 2020 12:15:45 +0300	[thread overview]
Message-ID: <20200817091553.283155-5-vsementsov@virtuozzo.com> (raw)
In-Reply-To: <20200817091553.283155-1-vsementsov@virtuozzo.com>

bs is linked in req, so no needs to pass it separately. Most of
tracked-requests API doesn't have bs argument. Actually, after this
patch only tracked_request_begin has it, but it's for purpose.

While being here, also add a comment about what "_locked" is.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
 block/io.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/block/io.c b/block/io.c
index 5b96715058..36bbe4b9b1 100644
--- a/block/io.c
+++ b/block/io.c
@@ -761,16 +761,16 @@ bdrv_find_conflicting_request(BdrvTrackedRequest *self)
     return NULL;
 }
 
+/* Called with self->bs->reqs_lock held */
 static bool coroutine_fn
-bdrv_wait_serialising_requests_locked(BlockDriverState *bs,
-                                      BdrvTrackedRequest *self)
+bdrv_wait_serialising_requests_locked(BdrvTrackedRequest *self)
 {
     BdrvTrackedRequest *req;
     bool waited = false;
 
     while ((req = bdrv_find_conflicting_request(self))) {
         self->waiting_for = req;
-        qemu_co_queue_wait(&req->wait_queue, &bs->reqs_lock);
+        qemu_co_queue_wait(&req->wait_queue, &self->bs->reqs_lock);
         self->waiting_for = NULL;
         waited = true;
     }
@@ -794,7 +794,7 @@ bool bdrv_mark_request_serialising(BdrvTrackedRequest *req, uint64_t align)
 
     req->overlap_offset = MIN(req->overlap_offset, overlap_offset);
     req->overlap_bytes = MAX(req->overlap_bytes, overlap_bytes);
-    waited = bdrv_wait_serialising_requests_locked(bs, req);
+    waited = bdrv_wait_serialising_requests_locked(req);
     qemu_co_mutex_unlock(&bs->reqs_lock);
     return waited;
 }
@@ -876,7 +876,7 @@ static bool coroutine_fn bdrv_wait_serialising_requests(BdrvTrackedRequest *self
     }
 
     qemu_co_mutex_lock(&bs->reqs_lock);
-    waited = bdrv_wait_serialising_requests_locked(bs, self);
+    waited = bdrv_wait_serialising_requests_locked(self);
     qemu_co_mutex_unlock(&bs->reqs_lock);
 
     return waited;
-- 
2.18.0



  parent reply	other threads:[~2020-08-17  9:29 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-17  9:15 [PATCH v3 00/12] preallocate filter Vladimir Sementsov-Ogievskiy
2020-08-17  9:15 ` [PATCH v3 01/12] block: simplify comment to BDRV_REQ_SERIALISING Vladimir Sementsov-Ogievskiy
2020-08-19 14:59   ` Stefan Hajnoczi
2020-08-17  9:15 ` [PATCH v3 02/12] block/io.c: drop assertion on double waiting for request serialisation Vladimir Sementsov-Ogievskiy
2020-08-19 15:28   ` Stefan Hajnoczi
2020-08-19 15:48     ` Paolo Bonzini
2020-08-17  9:15 ` [PATCH v3 03/12] block/io: split out bdrv_find_conflicting_request Vladimir Sementsov-Ogievskiy
2020-08-19 14:59   ` Stefan Hajnoczi
2020-08-17  9:15 ` Vladimir Sementsov-Ogievskiy [this message]
2020-08-19 14:59   ` [PATCH v3 04/12] block/io: bdrv_wait_serialising_requests_locked: drop extra bs arg Stefan Hajnoczi
2020-08-17  9:15 ` [PATCH v3 05/12] block: bdrv_mark_request_serialising: split non-waiting function Vladimir Sementsov-Ogievskiy
2020-08-19 14:40   ` Stefan Hajnoczi
2020-08-17  9:15 ` [PATCH v3 06/12] block: introduce BDRV_REQ_NO_WAIT flag Vladimir Sementsov-Ogievskiy
2020-08-19 14:42   ` Stefan Hajnoczi
2020-08-17  9:15 ` [PATCH v3 07/12] block: introduce preallocate filter Vladimir Sementsov-Ogievskiy
2020-08-19 14:57   ` Stefan Hajnoczi
2020-08-17  9:15 ` [PATCH v3 08/12] iotests.py: add verify_o_direct helper Vladimir Sementsov-Ogievskiy
2020-08-19 14:59   ` Stefan Hajnoczi
2020-08-17  9:15 ` [PATCH v3 09/12] iotests.py: add filter_img_check Vladimir Sementsov-Ogievskiy
2020-08-19 14:59   ` Stefan Hajnoczi
2020-08-17  9:15 ` [PATCH v3 10/12] iotests: add 298 to test new preallocate filter driver Vladimir Sementsov-Ogievskiy
2020-08-19 14:59   ` Stefan Hajnoczi
2020-08-17  9:15 ` [PATCH v3 11/12] block: add bdrv_is_file_on_fuse helper Vladimir Sementsov-Ogievskiy
2020-08-17  9:15 ` [PATCH v3 12/12] block/qcow2: automatically insert preallocate filter when on FUSE Vladimir Sementsov-Ogievskiy
2020-08-19 15:15   ` Stefan Hajnoczi
2020-08-20  9:46     ` Vladimir Sementsov-Ogievskiy
2020-08-17  9:45 ` [PATCH v3 00/12] preallocate filter no-reply
2020-08-17 10:44   ` Vladimir Sementsov-Ogievskiy
2020-08-17  9:48 ` no-reply
2020-08-17 10:46   ` Vladimir Sementsov-Ogievskiy
2020-08-19 15:29 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200817091553.283155-5-vsementsov@virtuozzo.com \
    --to=vsementsov@virtuozzo.com \
    --cc=armbru@redhat.com \
    --cc=den@openvz.org \
    --cc=fam@euphon.net \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).