From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: fam@euphon.net, kwolf@redhat.com, vsementsov@virtuozzo.com,
armbru@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com,
stefanha@redhat.com, den@openvz.org
Subject: [PATCH v3 06/12] block: introduce BDRV_REQ_NO_WAIT flag
Date: Mon, 17 Aug 2020 12:15:47 +0300 [thread overview]
Message-ID: <20200817091553.283155-7-vsementsov@virtuozzo.com> (raw)
In-Reply-To: <20200817091553.283155-1-vsementsov@virtuozzo.com>
Add flag to make serialising request no wait: if there are conflicting
requests, just return error immediately. It's will be used in upcoming
preallocate filter.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
include/block/block.h | 9 ++++++++-
block/io.c | 13 ++++++++++++-
2 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/include/block/block.h b/include/block/block.h
index b8f4e86e8d..877fda06a4 100644
--- a/include/block/block.h
+++ b/include/block/block.h
@@ -67,8 +67,15 @@ typedef enum {
* written to qiov parameter which may be NULL.
*/
BDRV_REQ_PREFETCH = 0x200,
+
+ /*
+ * If we need to wait for other requests, just fail immediately. Used
+ * only together with BDRV_REQ_SERIALISING.
+ */
+ BDRV_REQ_NO_WAIT = 0x400,
+
/* Mask of valid flags */
- BDRV_REQ_MASK = 0x3ff,
+ BDRV_REQ_MASK = 0x7ff,
} BdrvRequestFlags;
typedef struct BlockSizes {
diff --git a/block/io.c b/block/io.c
index 96b1b9cf5f..fc6d44d302 100644
--- a/block/io.c
+++ b/block/io.c
@@ -1911,9 +1911,20 @@ bdrv_co_write_req_prepare(BdrvChild *child, int64_t offset, uint64_t bytes,
assert(!(bs->open_flags & BDRV_O_INACTIVE));
assert((bs->open_flags & BDRV_O_NO_IO) == 0);
assert(!(flags & ~BDRV_REQ_MASK));
+ assert(!((flags & BDRV_REQ_NO_WAIT) && !(flags & BDRV_REQ_SERIALISING)));
if (flags & BDRV_REQ_SERIALISING) {
- bdrv_make_request_serialising(req, bdrv_get_cluster_size(bs));
+ qemu_co_mutex_lock(&bs->reqs_lock);
+
+ tracked_request_set_serialising(req, bdrv_get_cluster_size(bs));
+
+ if ((flags & BDRV_REQ_NO_WAIT) && bdrv_find_conflicting_request(req)) {
+ return -EBUSY;
+ }
+
+ bdrv_wait_serialising_requests_locked(req);
+
+ qemu_co_mutex_unlock(&bs->reqs_lock);
} else {
bdrv_wait_serialising_requests(req);
}
--
2.18.0
next prev parent reply other threads:[~2020-08-17 9:26 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 9:15 [PATCH v3 00/12] preallocate filter Vladimir Sementsov-Ogievskiy
2020-08-17 9:15 ` [PATCH v3 01/12] block: simplify comment to BDRV_REQ_SERIALISING Vladimir Sementsov-Ogievskiy
2020-08-19 14:59 ` Stefan Hajnoczi
2020-08-17 9:15 ` [PATCH v3 02/12] block/io.c: drop assertion on double waiting for request serialisation Vladimir Sementsov-Ogievskiy
2020-08-19 15:28 ` Stefan Hajnoczi
2020-08-19 15:48 ` Paolo Bonzini
2020-08-17 9:15 ` [PATCH v3 03/12] block/io: split out bdrv_find_conflicting_request Vladimir Sementsov-Ogievskiy
2020-08-19 14:59 ` Stefan Hajnoczi
2020-08-17 9:15 ` [PATCH v3 04/12] block/io: bdrv_wait_serialising_requests_locked: drop extra bs arg Vladimir Sementsov-Ogievskiy
2020-08-19 14:59 ` Stefan Hajnoczi
2020-08-17 9:15 ` [PATCH v3 05/12] block: bdrv_mark_request_serialising: split non-waiting function Vladimir Sementsov-Ogievskiy
2020-08-19 14:40 ` Stefan Hajnoczi
2020-08-17 9:15 ` Vladimir Sementsov-Ogievskiy [this message]
2020-08-19 14:42 ` [PATCH v3 06/12] block: introduce BDRV_REQ_NO_WAIT flag Stefan Hajnoczi
2020-08-17 9:15 ` [PATCH v3 07/12] block: introduce preallocate filter Vladimir Sementsov-Ogievskiy
2020-08-19 14:57 ` Stefan Hajnoczi
2020-08-17 9:15 ` [PATCH v3 08/12] iotests.py: add verify_o_direct helper Vladimir Sementsov-Ogievskiy
2020-08-19 14:59 ` Stefan Hajnoczi
2020-08-17 9:15 ` [PATCH v3 09/12] iotests.py: add filter_img_check Vladimir Sementsov-Ogievskiy
2020-08-19 14:59 ` Stefan Hajnoczi
2020-08-17 9:15 ` [PATCH v3 10/12] iotests: add 298 to test new preallocate filter driver Vladimir Sementsov-Ogievskiy
2020-08-19 14:59 ` Stefan Hajnoczi
2020-08-17 9:15 ` [PATCH v3 11/12] block: add bdrv_is_file_on_fuse helper Vladimir Sementsov-Ogievskiy
2020-08-17 9:15 ` [PATCH v3 12/12] block/qcow2: automatically insert preallocate filter when on FUSE Vladimir Sementsov-Ogievskiy
2020-08-19 15:15 ` Stefan Hajnoczi
2020-08-20 9:46 ` Vladimir Sementsov-Ogievskiy
2020-08-17 9:45 ` [PATCH v3 00/12] preallocate filter no-reply
2020-08-17 10:44 ` Vladimir Sementsov-Ogievskiy
2020-08-17 9:48 ` no-reply
2020-08-17 10:46 ` Vladimir Sementsov-Ogievskiy
2020-08-19 15:29 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817091553.283155-7-vsementsov@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).