From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: qemu-devel@nongnu.org
Cc: figlesia@xilinx.com, peter.maydell@linaro.org,
sstabellini@kernel.org, edgar.iglesias@xilinx.com,
sai.pavan.boddu@xilinx.com, frasse.iglesias@gmail.com,
alistair@alistair23.me, richard.henderson@linaro.org,
frederic.konrad@adacore.com, qemu-arm@nongnu.org,
philmd@redhat.com, luc.michel@greensocs.com
Subject: [PATCH v1 1/5] target/microblaze: mbar: Transfer dc->rd to mbar_imm
Date: Mon, 17 Aug 2020 16:01:40 +0200 [thread overview]
Message-ID: <20200817140144.373403-2-edgar.iglesias@gmail.com> (raw)
In-Reply-To: <20200817140144.373403-1-edgar.iglesias@gmail.com>
From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
Transfer dc->rd to mbar_imm to improve the readability when
comparing to the specs.
No functional change.
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
---
target/microblaze/translate.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c
index f6ff2591c3..47637f152b 100644
--- a/target/microblaze/translate.c
+++ b/target/microblaze/translate.c
@@ -1229,8 +1229,10 @@ static void dec_br(DisasContext *dc)
/* Memory barrier. */
mbar = (dc->ir >> 16) & 31;
if (mbar == 2 && dc->imm == 4) {
+ uint16_t mbar_imm = dc->rd;
+
/* mbar IMM & 16 decodes to sleep. */
- if (dc->rd & 16) {
+ if (mbar_imm & 16) {
TCGv_i32 tmp_hlt = tcg_const_i32(EXCP_HLT);
TCGv_i32 tmp_1 = tcg_const_i32(1);
@@ -1246,7 +1248,7 @@ static void dec_br(DisasContext *dc)
tcg_temp_free_i32(tmp_1);
return;
}
- LOG_DIS("mbar %d\n", dc->rd);
+ LOG_DIS("mbar %d\n", mbar_imm);
/* Break the TB. */
dc->cpustate_changed = 1;
return;
--
2.25.1
next prev parent reply other threads:[~2020-08-17 14:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 14:01 [PATCH v1 0/5] target/microblaze: Enable MTTCG Edgar E. Iglesias
2020-08-17 14:01 ` Edgar E. Iglesias [this message]
2020-08-17 15:31 ` [PATCH v1 1/5] target/microblaze: mbar: Transfer dc->rd to mbar_imm Richard Henderson
2020-08-17 16:08 ` Alistair Francis
2020-08-17 14:01 ` [PATCH v1 2/5] target/microblaze: mbar: Move LOG_DIS to before sleep Edgar E. Iglesias
2020-08-17 15:32 ` Richard Henderson
2020-08-17 16:08 ` Alistair Francis
2020-08-17 14:01 ` [PATCH v1 3/5] target/microblaze: mbar: Add support for data-access barriers Edgar E. Iglesias
2020-08-17 15:42 ` Richard Henderson
2020-08-17 17:03 ` Edgar E. Iglesias
2020-08-17 16:12 ` Alistair Francis
2020-08-17 14:01 ` [PATCH v1 4/5] target/microblaze: swx: Use atomic_cmpxchg Edgar E. Iglesias
2020-08-17 15:52 ` Richard Henderson
2020-08-17 15:59 ` Edgar E. Iglesias
2020-08-17 16:11 ` Alistair Francis
2020-08-17 14:01 ` [PATCH v1 5/5] configure: microblaze: Enable mttcg Edgar E. Iglesias
2020-08-17 16:07 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817140144.373403-2-edgar.iglesias@gmail.com \
--to=edgar.iglesias@gmail.com \
--cc=alistair@alistair23.me \
--cc=edgar.iglesias@xilinx.com \
--cc=figlesia@xilinx.com \
--cc=frasse.iglesias@gmail.com \
--cc=frederic.konrad@adacore.com \
--cc=luc.michel@greensocs.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sai.pavan.boddu@xilinx.com \
--cc=sstabellini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).