qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Rohit Shinde <rohit.shinde12194@gmail.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org,
	Rohit Shinde <rohit.shinde12194@gmail.com>,
	armbru@redhat.com, mdroth@linux.vnet.ibm.com
Subject: [PATCH v5] qapi/opts-visitor: Added missing fallthrough annotations
Date: Tue, 18 Aug 2020 06:50:21 -0400	[thread overview]
Message-ID: <20200818105021.4998-1-rohit.shinde12194@gmail.com> (raw)

Added fallthrough comment on line 270 to prevent the compiler from
throwing an error while compiling with the -Wimplicit-fallthrough flag

Signed-off-by: Rohit Shinde <rohit.shinde12194@gmail.com>
---
 qapi/opts-visitor.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c
index 7781c23a42..3422ff265e 100644
--- a/qapi/opts-visitor.c
+++ b/qapi/opts-visitor.c
@@ -266,6 +266,7 @@ opts_next_list(Visitor *v, GenericList *tail, size_t size)
         }
         ov->list_mode = LM_IN_PROGRESS;
         /* range has been completed, fall through in order to pop option */
+        /* fallthrough */
 
     case LM_IN_PROGRESS: {
         const QemuOpt *opt;
-- 
2.25.1



             reply	other threads:[~2020-08-18 10:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-18 10:50 Rohit Shinde [this message]
2020-08-25  6:03 ` [PATCH v5] qapi/opts-visitor: Added missing fallthrough annotations Markus Armbruster
2020-08-27  0:55   ` Rohit Shinde
2020-08-27  6:10     ` Markus Armbruster
2020-08-28  0:07       ` Rohit Shinde
2020-08-28  6:08         ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200818105021.4998-1-rohit.shinde12194@gmail.com \
    --to=rohit.shinde12194@gmail.com \
    --cc=armbru@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).