From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [RFC PATCH 22/22] block/export: Add query-block-exports
Date: Wed, 19 Aug 2020 14:04:56 +0200 [thread overview]
Message-ID: <20200819113107.GC10272@linux.fritz.box> (raw)
In-Reply-To: <eb78ea1a-1196-62df-c2be-e1fba5a9a5e4@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1308 bytes --]
Am 19.08.2020 um 13:04 hat Max Reitz geschrieben:
> On 13.08.20 18:29, Kevin Wolf wrote:
> > This adds a simple QMP command to query the list of block exports.
> >
> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> > ---
> > qapi/block-export.json | 33 +++++++++++++++++++++++++++++++++
> > block/export/export.c | 23 +++++++++++++++++++++++
> > 2 files changed, 56 insertions(+)
> >
> > diff --git a/qapi/block-export.json b/qapi/block-export.json
> > index a067de2ba3..0b184bbd7c 100644
> > --- a/qapi/block-export.json
> > +++ b/qapi/block-export.json
> > @@ -226,3 +226,36 @@
> > ##
> > { 'command': 'block-export-del',
> > 'data': { 'id': 'str', '*mode': 'BlockExportRemoveMode' } }
> > +
> > +##
> > +# @BlockExportInfo:
> > +#
> > +# Information about a single block export.
> > +#
> > +# @id: The unique identifier for the block export
> > +#
> > +# @type: This field is returned only for compatibility reasons, it should
> > +# not be used (always returns 'unknown')
>
> Äh?
>
> I don’t understand. It looks like it definitely doesn’t always return
> “unknown”. Also, the “compatibility reasons” aren’t really immediately
> clear to me... :?
Oops, this seems to be copied from BlockInfo and I forgot to change it...
Kevin
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-08-19 12:06 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 16:29 [RFC PATCH 00/22] block/export: Add infrastructure and QAPI for block exports Kevin Wolf
2020-08-13 16:29 ` [RFC PATCH 01/22] nbd: Remove unused nbd_export_get_blockdev() Kevin Wolf
2020-08-17 8:14 ` Max Reitz
2020-08-19 18:13 ` Eric Blake
2020-08-13 16:29 ` [RFC PATCH 02/22] qapi: Create block-export module Kevin Wolf
2020-08-17 8:50 ` Max Reitz
2020-08-19 18:17 ` Eric Blake
2020-08-13 16:29 ` [RFC PATCH 03/22] qapi: Rename BlockExport to BlockExportOptions Kevin Wolf
2020-08-17 9:13 ` Max Reitz
2020-08-19 18:19 ` Eric Blake
2020-08-13 16:29 ` [RFC PATCH 04/22] block/export: Add BlockExport infrastructure and block-export-add Kevin Wolf
2020-08-17 10:03 ` Max Reitz
2020-08-17 12:45 ` Kevin Wolf
2020-08-17 13:19 ` Max Reitz
2020-08-17 13:29 ` Kevin Wolf
2020-08-17 13:53 ` Max Reitz
2020-08-19 18:31 ` Eric Blake
2020-08-13 16:29 ` [RFC PATCH 05/22] qemu-storage-daemon: Use qmp_block_export_add() Kevin Wolf
2020-08-17 10:13 ` Max Reitz
2020-08-19 19:14 ` Eric Blake
2020-08-13 16:29 ` [RFC PATCH 06/22] qemu-nbd: Use raw block driver for --offset Kevin Wolf
2020-08-17 10:56 ` Max Reitz
2020-08-17 11:41 ` Max Reitz
2020-08-17 17:19 ` Nir Soffer
2020-08-18 8:47 ` Kevin Wolf
2020-08-18 9:05 ` Nir Soffer
2020-08-19 19:33 ` Eric Blake
2020-08-13 16:29 ` [RFC PATCH 07/22] block/export: Remove magic from block-export-add Kevin Wolf
2020-08-17 11:41 ` Max Reitz
2020-08-17 12:49 ` Kevin Wolf
2020-08-17 13:22 ` Max Reitz
2020-08-19 19:50 ` Eric Blake
2020-08-20 11:05 ` Kevin Wolf
2020-08-20 14:41 ` Eric Blake
2020-08-20 15:28 ` Peter Krempa
2020-08-13 16:29 ` [RFC PATCH 08/22] nbd: Add max-connections to nbd-server-start Kevin Wolf
2020-08-17 12:37 ` Max Reitz
2020-08-17 13:01 ` Kevin Wolf
2020-08-19 20:00 ` Eric Blake
2020-08-20 11:12 ` Kevin Wolf
2020-08-13 16:29 ` [RFC PATCH 09/22] nbd: Add writethrough to block-export-add Kevin Wolf
2020-08-17 12:56 ` Max Reitz
2020-08-17 13:13 ` Kevin Wolf
2020-08-17 13:51 ` Max Reitz
2020-08-17 14:32 ` Kevin Wolf
2020-08-17 15:35 ` Max Reitz
2020-08-19 20:05 ` Eric Blake
2020-08-19 20:13 ` Eric Blake
2020-08-13 16:29 ` [RFC PATCH 10/22] nbd: Remove NBDExport.close callback Kevin Wolf
2020-08-17 14:02 ` Max Reitz
2020-08-19 20:17 ` Eric Blake
2020-08-13 16:29 ` [RFC PATCH 11/22] qemu-nbd: Use blk_exp_add() to create the export Kevin Wolf
2020-08-17 14:27 ` Max Reitz
2020-08-17 14:38 ` Max Reitz
2020-08-17 15:01 ` Kevin Wolf
2020-08-19 20:35 ` Eric Blake
2020-08-13 16:29 ` [RFC PATCH 12/22] nbd/server: Simplify export shutdown Kevin Wolf
2020-08-17 14:32 ` Max Reitz
2020-08-19 20:45 ` Eric Blake
2020-08-13 16:29 ` [RFC PATCH 13/22] block/export: Move refcount from NBDExport to BlockExport Kevin Wolf
2020-08-17 14:49 ` Max Reitz
2020-08-19 20:58 ` Eric Blake
2020-08-20 14:15 ` Kevin Wolf
2020-08-13 16:29 ` [RFC PATCH 14/22] block/export: Move AioContext " Kevin Wolf
2020-08-17 14:56 ` Max Reitz
2020-08-17 15:22 ` Kevin Wolf
2020-08-17 15:47 ` Max Reitz
2020-08-13 16:29 ` [RFC PATCH 15/22] block/export: Move device to BlockExportOptions Kevin Wolf
2020-08-17 15:13 ` Max Reitz
2020-08-17 15:27 ` Kevin Wolf
2020-08-17 15:49 ` Max Reitz
2020-08-19 21:13 ` Eric Blake
2020-08-13 16:29 ` [RFC PATCH 16/22] block/export: Allocate BlockExport in blk_exp_add() Kevin Wolf
2020-08-18 14:25 ` Max Reitz
2020-08-13 16:29 ` [RFC PATCH 17/22] block/export: Add blk_exp_close_all(_type) Kevin Wolf
2020-08-18 15:00 ` Max Reitz
2020-08-13 16:29 ` [RFC PATCH 18/22] block/export: Add 'id' option to block-export-add Kevin Wolf
2020-08-18 15:08 ` Max Reitz
2020-08-13 16:29 ` [RFC PATCH 19/22] block/export: Move strong user reference to block_exports Kevin Wolf
2020-08-19 8:35 ` Max Reitz
2020-08-19 11:56 ` Max Reitz
2020-08-19 14:23 ` Kevin Wolf
2020-08-19 14:48 ` Max Reitz
2020-08-13 16:29 ` [RFC PATCH 20/22] block/export: Add block-export-del Kevin Wolf
2020-08-19 9:54 ` Max Reitz
2020-08-13 16:29 ` [RFC PATCH 21/22] block/export: Move blk to BlockExport Kevin Wolf
2020-08-19 10:53 ` Max Reitz
2020-08-13 16:29 ` [RFC PATCH 22/22] block/export: Add query-block-exports Kevin Wolf
2020-08-19 11:04 ` Max Reitz
2020-08-19 12:04 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200819113107.GC10272@linux.fritz.box \
--to=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).