From: Cornelia Huck <cohuck@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>, Qinghua Cheng <qcheng@redhat.com>,
Qian Cai <caiqian@redhat.com>,
David Hildenbrand <david@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, qemu-stable@nongnu.org,
Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH 2/3] vhost-user-vsock-pci: force virtio version 1
Date: Wed, 19 Aug 2020 13:57:12 +0200 [thread overview]
Message-ID: <20200819135712.4297c1a4.cohuck@redhat.com> (raw)
In-Reply-To: <20200819105156.54163-3-sgarzare@redhat.com>
On Wed, 19 Aug 2020 12:51:55 +0200
Stefano Garzarella <sgarzare@redhat.com> wrote:
> Commit 9b3a35ec82 ("virtio: verify that legacy support is not
> accidentally on") added a safety checks that requires to set
> 'disable-legacy=on' on vhost-user-vsock-pci device:
>
> $ ./qemu-system-x86_64 ... \
> -chardev socket,id=char0,reconnect=0,path=/tmp/vhost4.socket \
> -device vhost-user-vsock-pci,chardev=char0
> qemu-system-x86_64: -device vhost-user-vsock-pci,chardev=char0:
> device is modern-only, use disable-legacy=on
>
> virtio-vsock was introduced after the release of VIRTIO 1.0
> specifications, so it should be 'modern-only'.
>
> This patch forces virtio version 1 and remove 'transitional_name'
> properties, as done for vhost-vsock-pci, removing the need to specify
> 'disable-legacy=on' on vhost-user-vsock-pci device.
>
> Cc: qemu-stable@nongnu.org
> Suggested-by: Cornelia Huck <cohuck@redhat.com>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
> ---
> hw/virtio/vhost-user-vsock-pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Same nits for the patch description as for patch 1, otherwise
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2020-08-19 11:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 10:51 [PATCH 0/3] vhost-vsock: force virtio version 1 Stefano Garzarella
2020-08-19 10:51 ` [PATCH 1/3] vhost-vsock-pci: " Stefano Garzarella
2020-08-19 11:55 ` Cornelia Huck
2020-08-19 12:09 ` Stefano Garzarella
2020-08-19 12:28 ` Cornelia Huck
2020-08-19 10:51 ` [PATCH 2/3] vhost-user-vsock-pci: " Stefano Garzarella
2020-08-19 11:57 ` Cornelia Huck [this message]
2020-08-19 10:51 ` [PATCH 3/3] vhost-vsock-ccw: " Stefano Garzarella
2020-08-19 12:01 ` Cornelia Huck
2020-08-19 11:06 ` [PATCH 0/3] vhost-vsock: " David Hildenbrand
2020-08-19 11:21 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200819135712.4297c1a4.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=caiqian@redhat.com \
--cc=david@redhat.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=qcheng@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=rth@twiddle.net \
--cc=sgarzare@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).