From: Stefan Hajnoczi <stefanha@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: fam@euphon.net, kwolf@redhat.com, qemu-block@nongnu.org,
armbru@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com,
den@openvz.org
Subject: Re: [PATCH v3 05/12] block: bdrv_mark_request_serialising: split non-waiting function
Date: Wed, 19 Aug 2020 15:40:24 +0100 [thread overview]
Message-ID: <20200819144024.GF366841@stefanha-x1.localdomain> (raw)
In-Reply-To: <20200817091553.283155-6-vsementsov@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 494 bytes --]
On Mon, Aug 17, 2020 at 12:15:46PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> @@ -882,6 +878,20 @@ static bool coroutine_fn bdrv_wait_serialising_requests(BdrvTrackedRequest *self
> return waited;
> }
>
> +bool bdrv_make_request_serialising(BdrvTrackedRequest *req, uint64_t align)
> +{
> + bool waited;
> +
> + qemu_co_mutex_lock(&req->bs->reqs_lock);
qemu_co_mutex_lock() is a coroutine_fn so
bdrv_make_request_serialising() needs to be marked coroutine_fn too.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-08-19 14:44 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 9:15 [PATCH v3 00/12] preallocate filter Vladimir Sementsov-Ogievskiy
2020-08-17 9:15 ` [PATCH v3 01/12] block: simplify comment to BDRV_REQ_SERIALISING Vladimir Sementsov-Ogievskiy
2020-08-19 14:59 ` Stefan Hajnoczi
2020-08-17 9:15 ` [PATCH v3 02/12] block/io.c: drop assertion on double waiting for request serialisation Vladimir Sementsov-Ogievskiy
2020-08-19 15:28 ` Stefan Hajnoczi
2020-08-19 15:48 ` Paolo Bonzini
2020-08-17 9:15 ` [PATCH v3 03/12] block/io: split out bdrv_find_conflicting_request Vladimir Sementsov-Ogievskiy
2020-08-19 14:59 ` Stefan Hajnoczi
2020-08-17 9:15 ` [PATCH v3 04/12] block/io: bdrv_wait_serialising_requests_locked: drop extra bs arg Vladimir Sementsov-Ogievskiy
2020-08-19 14:59 ` Stefan Hajnoczi
2020-08-17 9:15 ` [PATCH v3 05/12] block: bdrv_mark_request_serialising: split non-waiting function Vladimir Sementsov-Ogievskiy
2020-08-19 14:40 ` Stefan Hajnoczi [this message]
2020-08-17 9:15 ` [PATCH v3 06/12] block: introduce BDRV_REQ_NO_WAIT flag Vladimir Sementsov-Ogievskiy
2020-08-19 14:42 ` Stefan Hajnoczi
2020-08-17 9:15 ` [PATCH v3 07/12] block: introduce preallocate filter Vladimir Sementsov-Ogievskiy
2020-08-19 14:57 ` Stefan Hajnoczi
2020-08-17 9:15 ` [PATCH v3 08/12] iotests.py: add verify_o_direct helper Vladimir Sementsov-Ogievskiy
2020-08-19 14:59 ` Stefan Hajnoczi
2020-08-17 9:15 ` [PATCH v3 09/12] iotests.py: add filter_img_check Vladimir Sementsov-Ogievskiy
2020-08-19 14:59 ` Stefan Hajnoczi
2020-08-17 9:15 ` [PATCH v3 10/12] iotests: add 298 to test new preallocate filter driver Vladimir Sementsov-Ogievskiy
2020-08-19 14:59 ` Stefan Hajnoczi
2020-08-17 9:15 ` [PATCH v3 11/12] block: add bdrv_is_file_on_fuse helper Vladimir Sementsov-Ogievskiy
2020-08-17 9:15 ` [PATCH v3 12/12] block/qcow2: automatically insert preallocate filter when on FUSE Vladimir Sementsov-Ogievskiy
2020-08-19 15:15 ` Stefan Hajnoczi
2020-08-20 9:46 ` Vladimir Sementsov-Ogievskiy
2020-08-17 9:45 ` [PATCH v3 00/12] preallocate filter no-reply
2020-08-17 10:44 ` Vladimir Sementsov-Ogievskiy
2020-08-17 9:48 ` no-reply
2020-08-17 10:46 ` Vladimir Sementsov-Ogievskiy
2020-08-19 15:29 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200819144024.GF366841@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).