From: David Gibson <david@gibson.dropbear.id.au>
To: "Cédric Le Goater" <clg@kaod.org>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
Greg Kurz <groug@kaod.org>,
Gustavo Romero <gromero@linux.ibm.com>
Subject: Re: [PATCH 7/8] spapr/xive: Use the xics flag to check for XIVE-only IRQ backends
Date: Thu, 20 Aug 2020 11:36:59 +1000 [thread overview]
Message-ID: <20200820013659.GH271315@yekko.fritz.box> (raw)
In-Reply-To: <20200819130843.2230799-8-clg@kaod.org>
[-- Attachment #1: Type: text/plain, Size: 1070 bytes --]
On Wed, Aug 19, 2020 at 03:08:42PM +0200, Cédric Le Goater wrote:
I can see why this is a good idea, but it really needs a rationale in
the comment for posterity.
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
> hw/ppc/spapr_irq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ppc/spapr_irq.c b/hw/ppc/spapr_irq.c
> index 80cf1c3d6bb2..d036c8fef519 100644
> --- a/hw/ppc/spapr_irq.c
> +++ b/hw/ppc/spapr_irq.c
> @@ -172,7 +172,7 @@ static int spapr_irq_check(SpaprMachineState *spapr, Error **errp)
> * To cover both and not confuse the OS, add an early failure in
> * QEMU.
> */
> - if (spapr->irq == &spapr_irq_xive) {
> + if (!spapr->irq->xics) {
> error_setg(errp, "XIVE-only machines require a POWER9 CPU");
> return -1;
> }
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-08-20 1:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 13:08 [PATCH 0/8] spapr/xive: Activate StoreEOI in P10 compat guests Cédric Le Goater
2020-08-19 13:08 ` [PATCH 1/8] spapr/xive: Add a 'hv-prio' property to represent the KVM escalation priority Cédric Le Goater
2020-08-20 0:58 ` David Gibson
2020-08-19 13:08 ` [PATCH 2/8] linux-headers: Update for KVM_DEV_XIVE_GRP_SOURCE_INFO Cédric Le Goater
2020-08-20 0:58 ` David Gibson
2020-08-20 6:49 ` Cédric Le Goater
2020-08-19 13:08 ` [PATCH 3/8] spapr/xive: Query the characteristics of a source in KVM Cédric Le Goater
2020-08-20 1:33 ` David Gibson
2020-08-20 6:58 ` Cédric Le Goater
2020-08-19 13:08 ` [PATCH 4/8] spapr/xive: Activate StoreEOI for POWER10 only Cédric Le Goater
2020-08-19 13:08 ` [PATCH 5/8] spapr/xive: Enforce the load-after-store ordering Cédric Le Goater
2020-08-19 13:08 ` [PATCH 6/8] spapr/xive: Activate StoreEOI by default Cédric Le Goater
2020-08-19 13:08 ` [PATCH 7/8] spapr/xive: Use the xics flag to check for XIVE-only IRQ backends Cédric Le Goater
2020-08-20 1:36 ` David Gibson [this message]
2020-08-20 6:59 ` Cédric Le Goater
2020-08-19 13:08 ` [PATCH 8/8] spapr/xive: Introduce a XIVE StoreEOI IRQ backend Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200820013659.GH271315@yekko.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=clg@kaod.org \
--cc=gromero@linux.ibm.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).