qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Fam Zheng" <fam@euphon.net>, "Kevin Wolf" <kwolf@redhat.com>,
	qemu-block@nongnu.org, "Max Reitz" <mreitz@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH v5 11/15] block/nvme: Simplify nvme_init_queue() arguments
Date: Thu, 20 Aug 2020 18:58:57 +0200	[thread overview]
Message-ID: <20200820165901.1139109-12-philmd@redhat.com> (raw)
In-Reply-To: <20200820165901.1139109-1-philmd@redhat.com>

nvme_init_queue() doesn't require BlockDriverState anymore.
Replace it by BDRVNVMeState to simplify.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 block/nvme.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/block/nvme.c b/block/nvme.c
index f180078e781..5b69fc75a60 100644
--- a/block/nvme.c
+++ b/block/nvme.c
@@ -165,10 +165,9 @@ static QemuOptsList runtime_opts = {
     },
 };
 
-static void nvme_init_queue(BlockDriverState *bs, NVMeQueue *q,
+static void nvme_init_queue(BDRVNVMeState *s, NVMeQueue *q,
                             int nentries, int entry_bytes, Error **errp)
 {
-    BDRVNVMeState *s = bs->opaque;
     size_t bytes;
     int r;
 
@@ -251,14 +250,14 @@ static NVMeQueuePair *nvme_create_queue_pair(BlockDriverState *bs,
         req->prp_list_iova = prp_list_iova + i * s->page_size;
     }
 
-    nvme_init_queue(bs, &q->sq, size, NVME_SQ_ENTRY_BYTES, &local_err);
+    nvme_init_queue(s, &q->sq, size, NVME_SQ_ENTRY_BYTES, &local_err);
     if (local_err) {
         error_propagate(errp, local_err);
         goto fail;
     }
     q->sq.doorbell = &s->regs->doorbells[idx * 2 * s->doorbell_scale];
 
-    nvme_init_queue(bs, &q->cq, size, NVME_CQ_ENTRY_BYTES, &local_err);
+    nvme_init_queue(s, &q->cq, size, NVME_CQ_ENTRY_BYTES, &local_err);
     if (local_err) {
         error_propagate(errp, local_err);
         goto fail;
-- 
2.26.2



  parent reply	other threads:[~2020-08-20 17:05 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-20 16:58 [PATCH v5 00/15] block/nvme: Various cleanups required to use multiple queues Philippe Mathieu-Daudé
2020-08-20 16:58 ` [PATCH v5 01/15] block/nvme: Replace magic value by SCALE_MS definition Philippe Mathieu-Daudé
2020-08-21  9:33   ` Stefano Garzarella
2020-08-20 16:58 ` [PATCH v5 02/15] block/nvme: Avoid further processing if trace event not enabled Philippe Mathieu-Daudé
2020-08-20 16:58 ` [PATCH v5 03/15] block/nvme: Let nvme_create_queue_pair() fail gracefully Philippe Mathieu-Daudé
2020-08-21  9:44   ` Stefano Garzarella
2020-08-21 13:36     ` Philippe Mathieu-Daudé
2020-08-21 13:54       ` Stefano Garzarella
2020-08-20 16:58 ` [PATCH v5 04/15] block/nvme: Define INDEX macros to ease code review Philippe Mathieu-Daudé
2020-08-21  9:52   ` Stefano Garzarella
2020-08-20 16:58 ` [PATCH v5 05/15] block/nvme: Improve error message when IO queue creation failed Philippe Mathieu-Daudé
2020-08-21  9:54   ` Stefano Garzarella
2020-08-20 16:58 ` [PATCH v5 06/15] block/nvme: Use common error path in nvme_add_io_queue() Philippe Mathieu-Daudé
2020-08-21  9:55   ` Stefano Garzarella
2020-08-20 16:58 ` [PATCH v5 07/15] block/nvme: Rename local variable Philippe Mathieu-Daudé
2020-08-21  9:57   ` Stefano Garzarella
2020-08-20 16:58 ` [PATCH v5 08/15] block/nvme: Use union of NvmeIdCtrl / NvmeIdNs structures Philippe Mathieu-Daudé
2020-08-21 10:03   ` Stefano Garzarella
2020-08-21 13:27     ` Philippe Mathieu-Daudé
2020-08-21 13:52       ` Stefano Garzarella
2020-08-20 16:58 ` [PATCH v5 09/15] block/nvme: Replace qemu_try_blockalign0 by qemu_try_blockalign/memset Philippe Mathieu-Daudé
2020-08-21 10:07   ` Stefano Garzarella
2020-08-20 16:58 ` [PATCH v5 10/15] block/nvme: Replace qemu_try_blockalign(bs) by qemu_try_memalign(pg_sz) Philippe Mathieu-Daudé
2020-08-21 10:08   ` Stefano Garzarella
2020-08-20 16:58 ` Philippe Mathieu-Daudé [this message]
2020-08-21 10:10   ` [PATCH v5 11/15] block/nvme: Simplify nvme_init_queue() arguments Stefano Garzarella
2020-08-20 16:58 ` [PATCH v5 12/15] block/nvme: Replace BDRV_POLL_WHILE by AIO_WAIT_WHILE Philippe Mathieu-Daudé
2020-08-21 10:15   ` Stefano Garzarella
2020-08-21 13:15     ` Philippe Mathieu-Daudé
2020-08-21 13:47       ` Stefano Garzarella
2020-08-20 16:58 ` [PATCH v5 13/15] block/nvme: Simplify nvme_create_queue_pair() arguments Philippe Mathieu-Daudé
2020-08-21 10:20   ` Stefano Garzarella
2020-08-20 16:59 ` [PATCH v5 14/15] block/nvme: Extract nvme_poll_queue() Philippe Mathieu-Daudé
2020-08-21 10:23   ` Stefano Garzarella
2020-08-20 16:59 ` [PATCH v5 15/15] block/nvme: Use an array of EventNotifier Philippe Mathieu-Daudé
2020-08-21 10:29   ` Stefano Garzarella
2020-08-21 13:09     ` Philippe Mathieu-Daudé
2020-08-21 13:46       ` Stefano Garzarella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200820165901.1139109-12-philmd@redhat.com \
    --to=philmd@redhat.com \
    --cc=fam@euphon.net \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).