qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: "Cédric Le Goater" <clg@kaod.org>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
	Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>,
	Greg Kurz <groug@kaod.org>,
	Gustavo Romero <gromero@linux.ibm.com>
Subject: Re: [PATCH v2 0/4] spapr/xive: Allocate vCPU IPIs from the vCPU contexts
Date: Fri, 21 Aug 2020 11:38:07 +1000	[thread overview]
Message-ID: <20200821013807.GV271315@yekko.fritz.box> (raw)
In-Reply-To: <20200820134547.2355743-1-clg@kaod.org>

[-- Attachment #1: Type: text/plain, Size: 1361 bytes --]

On Thu, Aug 20, 2020 at 03:45:43PM +0200, Cédric Le Goater wrote:
> Hello,
> 
> 
> When QEMU switches to the XIVE interrupt mode, it creates all the
> guest interrupts at the level of the KVM device. These interrupts are
> backed by real HW interrupts from the IPI interrupt pool of the XIVE
> controller.
> 
> Currently, this is done from the QEMU main thread, which results in
> allocating all interrupts from the chip on which QEMU is running. IPIs
> are not distributed across the system and the load is not well
> balanced across the interrupt controllers.
> 
> Change the vCPU IPI allocation to run from the vCPU context. The
> associated XIVE IPI interrupt will be allocated on the chip on which
> the vCPU is running and improve distribution of the IPIs in the system.
> When the vCPUs are pinned, this will make the IPI local to the chip of
> the vCPU. It will reduce rerouting between interrupt controllers and
> gives better performance.
> 
> 
> I did some basic migration testing with the 'dual' and 'xive' modes,
> also tried CPU hoplug. I haven't tried migration with older pseries
> machine.

LGTM, applied to ppc-for-5.2.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      parent reply	other threads:[~2020-08-21  1:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-20 13:45 [PATCH v2 0/4] spapr/xive: Allocate vCPU IPIs from the vCPU contexts Cédric Le Goater
2020-08-20 13:45 ` [PATCH v2 1/4] spapr/xive: Modify kvm_cpu_is_enabled() interface Cédric Le Goater
2020-08-20 13:45 ` [PATCH v2 2/4] spapr/xive: Use kvmppc_xive_source_reset() in post_load Cédric Le Goater
2020-08-20 13:45 ` [PATCH v2 3/4] spapr/xive: Allocate IPIs independently from the other sources Cédric Le Goater
2020-11-05  8:37   ` Cédric Le Goater
2020-11-05 11:39     ` Greg Kurz
2020-08-20 13:45 ` [PATCH v2 4/4] spapr/xive: Allocate vCPU IPIs from the vCPU contexts Cédric Le Goater
2020-08-21  1:38 ` David Gibson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200821013807.GV271315@yekko.fritz.box \
    --to=david@gibson.dropbear.id.au \
    --cc=clg@kaod.org \
    --cc=gromero@linux.ibm.com \
    --cc=groug@kaod.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=sathnaga@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).