From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3D22C433DF for ; Fri, 21 Aug 2020 11:28:39 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AEE412072D for ; Fri, 21 Aug 2020 11:28:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="drYU2Uni" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AEE412072D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49648 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k95Dq-0000e4-UE for qemu-devel@archiver.kernel.org; Fri, 21 Aug 2020 07:28:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34246) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k94JX-0006PM-Ee for qemu-devel@nongnu.org; Fri, 21 Aug 2020 06:30:27 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:46601 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k94JU-0002o5-Dv for qemu-devel@nongnu.org; Fri, 21 Aug 2020 06:30:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598005823; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lInp/qK2CeDGFLsj6BzcHxxlDXULJRv35DwXnn7DuAE=; b=drYU2Uni2k8WPHEWftnd94uCll9Ofez6EN7lH5Y1wwlVG7sOwRTkkh6wp0caUZYT/za1N3 kzY7GzqpZCyjlEPnqPMA9YeAXJgoQJ3teCXKnJqDd7+XJuw6XZBJK3vpOayzlj4dQsug/J 9V/+brZpojpsayK2AceNVHESLKiXBs0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-485-YIyyLnlzMs-lCenX9sJscA-1; Fri, 21 Aug 2020 06:30:21 -0400 X-MC-Unique: YIyyLnlzMs-lCenX9sJscA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 083421007460 for ; Fri, 21 Aug 2020 10:30:21 +0000 (UTC) Received: from localhost (unknown [10.43.2.114]) by smtp.corp.redhat.com (Postfix) with ESMTP id 715B0747B0; Fri, 21 Aug 2020 10:30:09 +0000 (UTC) Date: Fri, 21 Aug 2020 12:30:07 +0200 From: Igor Mammedov To: Julia Suvorova Subject: Re: [RFC PATCH v2 0/4] Use ACPI PCI hot-plug for q35 Message-ID: <20200821123007.3d390d51@redhat.com> In-Reply-To: <20200818215227.181654-1-jusual@redhat.com> References: <20200818215227.181654-1-jusual@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=207.211.31.81; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/21 05:15:56 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , qemu-devel@nongnu.org, Gerd Hoffmann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 18 Aug 2020 23:52:23 +0200 Julia Suvorova wrote: > PCIe native hot-plug has numerous problems with racing events and unpredictable > guest behaviour (Windows). Documenting these misterious problems I've asked for in previous review hasn't been addressed. Pls see v1 for comments and add requested info into cover letter at least or in a commit message. > Switching to ACPI hot-plug for now. > > Tested on RHEL 8 and Windows 2019. > pxb-pcie is not yet supported. > > v2: > * new ioport range for acpiphp [Gerd] > * drop find_pci_host() [Igor] > * explain magic numbers in _OSC [Igor] > * drop build_q35_pci_hotplug() wrapper [Igor] > > Julia Suvorova (4): > hw/acpi/ich9: Trace ich9_gpe_readb()/writeb() > hw/i386/acpi-build: Add ACPI PCI hot-plug methods to q35 > hw/i386/acpi-build: Turn off support of PCIe native hot-plug and SHPC > in _OSC > hw/acpi/ich9: Enable ACPI PCI hot-plug > > hw/i386/acpi-build.h | 12 ++++++++++ > include/hw/acpi/ich9.h | 3 +++ > include/hw/acpi/pcihp.h | 3 ++- > hw/acpi/ich9.c | 52 ++++++++++++++++++++++++++++++++++++++++- > hw/acpi/pcihp.c | 15 ++++++++---- > hw/acpi/piix4.c | 2 +- > hw/i386/acpi-build.c | 48 +++++++++++++++++++++++-------------- > hw/i386/pc.c | 1 + > hw/acpi/trace-events | 4 ++++ > 9 files changed, 114 insertions(+), 26 deletions(-) >