From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PULL 5/6] meson: Fix --disable-tools --enable-system builds
Date: Fri, 21 Aug 2020 17:14:11 -0400 [thread overview]
Message-ID: <20200821211412.17321-6-pbonzini@redhat.com> (raw)
In-Reply-To: <20200821211412.17321-1-pbonzini@redhat.com>
From: Philippe Mathieu-Daudé <philmd@redhat.com>
Fixes:
$ ../configure --disable-tools --disable-user
../tests/qemu-iotests/meson.build:7:0: ERROR: Unknown variable "qemu_block_tools".
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200821150556.1235625-1-philmd@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
meson.build | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index dd8016c9da..df5bf728b5 100644
--- a/meson.build
+++ b/meson.build
@@ -1068,12 +1068,13 @@ if 'CONFIG_XKBCOMMON' in config_host
dependencies: [qemuutil, xkbcommon], install: have_tools)
endif
+qemu_block_tools = []
if have_tools
qemu_img = executable('qemu-img', [files('qemu-img.c'), hxdep],
dependencies: [authz, block, crypto, io, qom, qemuutil], install: true)
qemu_io = executable('qemu-io', files('qemu-io.c'),
dependencies: [block, qemuutil], install: true)
- qemu_block_tools = [qemu_img, qemu_io]
+ qemu_block_tools += [qemu_img, qemu_io]
if targetos == 'linux' or targetos == 'sunos' or targetos.endswith('bsd')
qemu_nbd = executable('qemu-nbd', files('qemu-nbd.c'),
dependencies: [block, qemuutil], install: true)
--
2.26.2
next prev parent reply other threads:[~2020-08-21 21:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 21:14 [PULL 0/6] Meson build system fixes Paolo Bonzini
2020-08-21 21:14 ` [PULL 1/6] target/s390x: fix meson.build issue Paolo Bonzini
2020-08-21 21:14 ` [PULL 2/6] util/meson.build: fix fdmon-io_uring build Paolo Bonzini
2020-08-21 21:14 ` [PULL 3/6] configure: silence 'shift' error message in version_ge() Paolo Bonzini
2020-08-21 21:14 ` [PULL 4/6] meson: convert pc-bios/keymaps/Makefile Paolo Bonzini
2020-08-21 21:14 ` Paolo Bonzini [this message]
2020-08-21 21:14 ` [PULL 6/6] keymaps: update Paolo Bonzini
2020-08-22 22:51 ` [PULL 0/6] Meson build system fixes Peter Maydell
2020-08-23 10:52 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200821211412.17321-6-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).