From: David Gibson <david@gibson.dropbear.id.au>
To: "Cédric Le Goater" <clg@kaod.org>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [PATCH] ppc/pnv: Fix TypeInfo of PnvLpcController abstract class
Date: Sat, 22 Aug 2020 23:18:37 +1000 [thread overview]
Message-ID: <20200822131837.GA4734@yekko.fritz.box> (raw)
In-Reply-To: <20200822083920.2668930-1-clg@kaod.org>
[-- Attachment #1: Type: text/plain, Size: 1805 bytes --]
On Sat, Aug 22, 2020 at 10:39:20AM +0200, Cédric Le Goater wrote:
> It was missing the instance_size field.
>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
Applied to ppc-for-5.2, thanks.
> ---
> hw/ppc/pnv_lpc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/hw/ppc/pnv_lpc.c b/hw/ppc/pnv_lpc.c
> index b5ffa48dac71..23f1e09492b1 100644
> --- a/hw/ppc/pnv_lpc.c
> +++ b/hw/ppc/pnv_lpc.c
> @@ -646,7 +646,6 @@ static void pnv_lpc_power8_class_init(ObjectClass *klass, void *data)
> static const TypeInfo pnv_lpc_power8_info = {
> .name = TYPE_PNV8_LPC,
> .parent = TYPE_PNV_LPC,
> - .instance_size = sizeof(PnvLpcController),
> .class_init = pnv_lpc_power8_class_init,
> .interfaces = (InterfaceInfo[]) {
> { TYPE_PNV_XSCOM_INTERFACE },
> @@ -687,7 +686,6 @@ static void pnv_lpc_power9_class_init(ObjectClass *klass, void *data)
> static const TypeInfo pnv_lpc_power9_info = {
> .name = TYPE_PNV9_LPC,
> .parent = TYPE_PNV_LPC,
> - .instance_size = sizeof(PnvLpcController),
> .class_init = pnv_lpc_power9_class_init,
> };
>
> @@ -768,6 +766,7 @@ static void pnv_lpc_class_init(ObjectClass *klass, void *data)
> static const TypeInfo pnv_lpc_info = {
> .name = TYPE_PNV_LPC,
> .parent = TYPE_DEVICE,
> + .instance_size = sizeof(PnvLpcController),
> .class_init = pnv_lpc_class_init,
> .class_size = sizeof(PnvLpcClass),
> .abstract = true,
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-08-22 13:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-22 8:39 [PATCH] ppc/pnv: Fix TypeInfo of PnvLpcController abstract class Cédric Le Goater
2020-08-22 13:18 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200822131837.GA4734@yekko.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=clg@kaod.org \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).