qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ppc/pnv: Fix TypeInfo of PnvLpcController abstract class
@ 2020-08-22  8:39 Cédric Le Goater
  2020-08-22 13:18 ` David Gibson
  0 siblings, 1 reply; 2+ messages in thread
From: Cédric Le Goater @ 2020-08-22  8:39 UTC (permalink / raw)
  To: David Gibson; +Cc: qemu-ppc, qemu-devel, Eduardo Habkost, Cédric Le Goater

It was missing the instance_size field.

Cc: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 hw/ppc/pnv_lpc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/hw/ppc/pnv_lpc.c b/hw/ppc/pnv_lpc.c
index b5ffa48dac71..23f1e09492b1 100644
--- a/hw/ppc/pnv_lpc.c
+++ b/hw/ppc/pnv_lpc.c
@@ -646,7 +646,6 @@ static void pnv_lpc_power8_class_init(ObjectClass *klass, void *data)
 static const TypeInfo pnv_lpc_power8_info = {
     .name          = TYPE_PNV8_LPC,
     .parent        = TYPE_PNV_LPC,
-    .instance_size = sizeof(PnvLpcController),
     .class_init    = pnv_lpc_power8_class_init,
     .interfaces = (InterfaceInfo[]) {
         { TYPE_PNV_XSCOM_INTERFACE },
@@ -687,7 +686,6 @@ static void pnv_lpc_power9_class_init(ObjectClass *klass, void *data)
 static const TypeInfo pnv_lpc_power9_info = {
     .name          = TYPE_PNV9_LPC,
     .parent        = TYPE_PNV_LPC,
-    .instance_size = sizeof(PnvLpcController),
     .class_init    = pnv_lpc_power9_class_init,
 };
 
@@ -768,6 +766,7 @@ static void pnv_lpc_class_init(ObjectClass *klass, void *data)
 static const TypeInfo pnv_lpc_info = {
     .name          = TYPE_PNV_LPC,
     .parent        = TYPE_DEVICE,
+    .instance_size = sizeof(PnvLpcController),
     .class_init    = pnv_lpc_class_init,
     .class_size    = sizeof(PnvLpcClass),
     .abstract      = true,
-- 
2.25.4



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ppc/pnv: Fix TypeInfo of PnvLpcController abstract class
  2020-08-22  8:39 [PATCH] ppc/pnv: Fix TypeInfo of PnvLpcController abstract class Cédric Le Goater
@ 2020-08-22 13:18 ` David Gibson
  0 siblings, 0 replies; 2+ messages in thread
From: David Gibson @ 2020-08-22 13:18 UTC (permalink / raw)
  To: Cédric Le Goater; +Cc: qemu-ppc, qemu-devel, Eduardo Habkost

[-- Attachment #1: Type: text/plain, Size: 1805 bytes --]

On Sat, Aug 22, 2020 at 10:39:20AM +0200, Cédric Le Goater wrote:
> It was missing the instance_size field.
> 
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>

Applied to ppc-for-5.2, thanks.

> ---
>  hw/ppc/pnv_lpc.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/hw/ppc/pnv_lpc.c b/hw/ppc/pnv_lpc.c
> index b5ffa48dac71..23f1e09492b1 100644
> --- a/hw/ppc/pnv_lpc.c
> +++ b/hw/ppc/pnv_lpc.c
> @@ -646,7 +646,6 @@ static void pnv_lpc_power8_class_init(ObjectClass *klass, void *data)
>  static const TypeInfo pnv_lpc_power8_info = {
>      .name          = TYPE_PNV8_LPC,
>      .parent        = TYPE_PNV_LPC,
> -    .instance_size = sizeof(PnvLpcController),
>      .class_init    = pnv_lpc_power8_class_init,
>      .interfaces = (InterfaceInfo[]) {
>          { TYPE_PNV_XSCOM_INTERFACE },
> @@ -687,7 +686,6 @@ static void pnv_lpc_power9_class_init(ObjectClass *klass, void *data)
>  static const TypeInfo pnv_lpc_power9_info = {
>      .name          = TYPE_PNV9_LPC,
>      .parent        = TYPE_PNV_LPC,
> -    .instance_size = sizeof(PnvLpcController),
>      .class_init    = pnv_lpc_power9_class_init,
>  };
>  
> @@ -768,6 +766,7 @@ static void pnv_lpc_class_init(ObjectClass *klass, void *data)
>  static const TypeInfo pnv_lpc_info = {
>      .name          = TYPE_PNV_LPC,
>      .parent        = TYPE_DEVICE,
> +    .instance_size = sizeof(PnvLpcController),
>      .class_init    = pnv_lpc_class_init,
>      .class_size    = sizeof(PnvLpcClass),
>      .abstract      = true,

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-08-22 13:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-22  8:39 [PATCH] ppc/pnv: Fix TypeInfo of PnvLpcController abstract class Cédric Le Goater
2020-08-22 13:18 ` David Gibson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).