* [PATCH] scripts/qemu-version.sh: Add missing space before ']'
@ 2020-08-23 10:26 Thomas Huth
2020-08-23 15:59 ` Marc-André Lureau
2020-08-25 7:58 ` Paolo Bonzini
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Huth @ 2020-08-23 10:26 UTC (permalink / raw)
To: Paolo Bonzini, Marc-André Lureau, qemu-devel; +Cc: qemu-trivial
When configure has been run with --with-pkgversion=xyz, the shell complains
about a missing ']' in this script.
Fixes: 2c273f32d3 ("meson: generate qemu-version.h")
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
scripts/qemu-version.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/qemu-version.sh b/scripts/qemu-version.sh
index 4847385e42..03128c56a2 100755
--- a/scripts/qemu-version.sh
+++ b/scripts/qemu-version.sh
@@ -6,7 +6,7 @@ dir="$1"
pkgversion="$2"
version="$3"
-if [ -z "$pkgversion"]; then
+if [ -z "$pkgversion" ]; then
cd "$dir"
if [ -e .git ]; then
pkgversion=$(git describe --match 'v*' --dirty | echo "")
--
2.18.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] scripts/qemu-version.sh: Add missing space before ']'
2020-08-23 10:26 [PATCH] scripts/qemu-version.sh: Add missing space before ']' Thomas Huth
@ 2020-08-23 15:59 ` Marc-André Lureau
2020-08-25 7:58 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Marc-André Lureau @ 2020-08-23 15:59 UTC (permalink / raw)
To: Thomas Huth; +Cc: qemu-trivial, Paolo Bonzini, qemu-devel
Hi
On Sun, Aug 23, 2020 at 2:26 PM Thomas Huth <thuth@redhat.com> wrote:
>
> When configure has been run with --with-pkgversion=xyz, the shell complains
> about a missing ']' in this script.
>
> Fixes: 2c273f32d3 ("meson: generate qemu-version.h")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
oops, my bad
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> scripts/qemu-version.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/qemu-version.sh b/scripts/qemu-version.sh
> index 4847385e42..03128c56a2 100755
> --- a/scripts/qemu-version.sh
> +++ b/scripts/qemu-version.sh
> @@ -6,7 +6,7 @@ dir="$1"
> pkgversion="$2"
> version="$3"
>
> -if [ -z "$pkgversion"]; then
> +if [ -z "$pkgversion" ]; then
> cd "$dir"
> if [ -e .git ]; then
> pkgversion=$(git describe --match 'v*' --dirty | echo "")
> --
> 2.18.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] scripts/qemu-version.sh: Add missing space before ']'
2020-08-23 10:26 [PATCH] scripts/qemu-version.sh: Add missing space before ']' Thomas Huth
2020-08-23 15:59 ` Marc-André Lureau
@ 2020-08-25 7:58 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2020-08-25 7:58 UTC (permalink / raw)
To: Thomas Huth; +Cc: qemu-trivial, Marc-André Lureau, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 834 bytes --]
Queued, thanks.
Paolo
Il dom 23 ago 2020, 12:26 Thomas Huth <thuth@redhat.com> ha scritto:
> When configure has been run with --with-pkgversion=xyz, the shell complains
> about a missing ']' in this script.
>
> Fixes: 2c273f32d3 ("meson: generate qemu-version.h")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> scripts/qemu-version.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/qemu-version.sh b/scripts/qemu-version.sh
> index 4847385e42..03128c56a2 100755
> --- a/scripts/qemu-version.sh
> +++ b/scripts/qemu-version.sh
> @@ -6,7 +6,7 @@ dir="$1"
> pkgversion="$2"
> version="$3"
>
> -if [ -z "$pkgversion"]; then
> +if [ -z "$pkgversion" ]; then
> cd "$dir"
> if [ -e .git ]; then
> pkgversion=$(git describe --match 'v*' --dirty | echo "")
> --
> 2.18.2
>
>
[-- Attachment #2: Type: text/html, Size: 1510 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-25 8:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-23 10:26 [PATCH] scripts/qemu-version.sh: Add missing space before ']' Thomas Huth
2020-08-23 15:59 ` Marc-André Lureau
2020-08-25 7:58 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).