From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: qemu-devel@nongnu.org
Cc: edgar.iglesias@xilinx.com, peter.maydell@linaro.org
Subject: [PULL v1 2/8] target/microblaze: mbar: Move LOG_DIS to before sleep
Date: Mon, 24 Aug 2020 12:00:35 +0200 [thread overview]
Message-ID: <20200824100041.1864420-3-edgar.iglesias@gmail.com> (raw)
In-Reply-To: <20200824100041.1864420-1-edgar.iglesias@gmail.com>
From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
Move LOG_DIS log to before sleeping handling so that it logs
for sleep instructions aswell.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
---
target/microblaze/translate.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c
index 47637f152b..c1be76d4c8 100644
--- a/target/microblaze/translate.c
+++ b/target/microblaze/translate.c
@@ -1231,6 +1231,8 @@ static void dec_br(DisasContext *dc)
if (mbar == 2 && dc->imm == 4) {
uint16_t mbar_imm = dc->rd;
+ LOG_DIS("mbar %d\n", mbar_imm);
+
/* mbar IMM & 16 decodes to sleep. */
if (mbar_imm & 16) {
TCGv_i32 tmp_hlt = tcg_const_i32(EXCP_HLT);
@@ -1248,7 +1250,6 @@ static void dec_br(DisasContext *dc)
tcg_temp_free_i32(tmp_1);
return;
}
- LOG_DIS("mbar %d\n", mbar_imm);
/* Break the TB. */
dc->cpustate_changed = 1;
return;
--
2.25.1
next prev parent reply other threads:[~2020-08-24 10:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 10:00 [PULL v1 0/8] Xilinx queue 2020-08-14 Edgar E. Iglesias
2020-08-24 10:00 ` [PULL v1 1/8] target/microblaze: mbar: Transfer dc->rd to mbar_imm Edgar E. Iglesias
2020-08-24 10:00 ` Edgar E. Iglesias [this message]
2020-08-24 10:00 ` [PULL v1 3/8] target/microblaze: mbar: Add support for data-access barriers Edgar E. Iglesias
2020-08-24 10:00 ` [PULL v1 4/8] target/microblaze: swx: Use atomic_cmpxchg Edgar E. Iglesias
2020-08-24 10:00 ` [PULL v1 5/8] configure: microblaze: Enable mttcg Edgar E. Iglesias
2020-08-24 10:00 ` [PULL v1 6/8] target/microblaze: mbar: Trap sleeps from user-space Edgar E. Iglesias
2020-08-24 10:00 ` [PULL v1 7/8] microblaze: petalogix-ml605: Add device-tree source Edgar E. Iglesias
2020-08-24 10:00 ` [PULL v1 8/8] microblaze: petalogix-s3adsp1800: " Edgar E. Iglesias
2020-08-24 15:32 ` [PULL v1 0/8] Xilinx queue 2020-08-14 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824100041.1864420-3-edgar.iglesias@gmail.com \
--to=edgar.iglesias@gmail.com \
--cc=edgar.iglesias@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).