From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: laurent@vivier.eu, Gerd Hoffmann <kraxel@redhat.com>
Subject: [PULL 3/3] meson: avoid compiling qemu-keymap by default
Date: Tue, 25 Aug 2020 08:20:08 +0200 [thread overview]
Message-ID: <20200825062008.6502-4-kraxel@redhat.com> (raw)
In-Reply-To: <20200825062008.6502-1-kraxel@redhat.com>
From: Laurent Vivier <laurent@vivier.eu>
qemu-keymap is not needed with linux-user, so disable it by default if
tools and system are disabled (tools are disabled by default with linux-user).
Avoid this error with statically linked binaries:
Linking target qemu-keymap
/usr/bin/ld: cannot find -lxkbcommon
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Message-id: 20200824152430.1844159-3-laurent@vivier.eu
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
meson.build | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/meson.build b/meson.build
index f6e346af1a69..f0fe5f8799e0 100644
--- a/meson.build
+++ b/meson.build
@@ -1063,6 +1063,11 @@ if 'CONFIG_GUEST_AGENT' in config_host
subdir('qga')
endif
+# Don't build qemu-keymap if xkbcommon is not explicitly enabled
+# when we don't build tools or system
+if get_option('xkbcommon').auto() and not have_system and not have_tools
+ xkbcommon = not_found
+endif
if xkbcommon.found()
# used for the update-keymaps target, so include rules even if !have_tools
qemu_keymap = executable('qemu-keymap', files('qemu-keymap.c', 'ui/input-keymap.c') + genh,
--
2.27.0
next prev parent reply other threads:[~2020-08-25 6:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 6:20 [PULL 0/3] Fixes 20200825 patches Gerd Hoffmann
2020-08-25 6:20 ` [PULL 1/3] meson: drop keymaps symlink Gerd Hoffmann
2020-08-25 6:20 ` [PULL 2/3] meson: move xkbcommon to meson Gerd Hoffmann
2020-08-25 6:20 ` Gerd Hoffmann [this message]
2020-08-25 12:59 ` [PULL 0/3] Fixes 20200825 patches Peter Maydell
2020-08-27 7:20 ` Thomas Huth
2020-08-27 9:28 ` Gerd Hoffmann
2020-08-27 10:23 ` Peter Maydell
2020-08-28 5:13 ` Gerd Hoffmann
2020-08-28 16:29 ` Peter Maydell
2020-08-28 16:40 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825062008.6502-4-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).