From: "Daniel P. Berrangé" <berrange@redhat.com>
To: luoyonggang@gmail.com
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH 4/5] meson: !/bin/sh are msys2 friendly.
Date: Tue, 25 Aug 2020 09:59:49 +0100 [thread overview]
Message-ID: <20200825085949.GC107278@redhat.com> (raw)
In-Reply-To: <20200825083500.359-4-luoyonggang@gmail.com>
On Tue, Aug 25, 2020 at 04:34:59PM +0800, luoyonggang@gmail.com wrote:
> From: Yonggang Luo <luoyonggang@gmail.com>
>
> ---
> scripts/undefsym.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/undefsym.sh b/scripts/undefsym.sh
> index b9ec332e95..8189308b2c 100755
> --- a/scripts/undefsym.sh
> +++ b/scripts/undefsym.sh
> @@ -1,4 +1,4 @@
> -#! /usr/bin/env bash
> +#!/bin/sh
Does this script actually work on non-bash shells ? If not, then this
change will likely break on plaforms where /bin/sh is not bash.
>
> # Before a shared module's DSO is produced, a static library is built for it
> # and passed to this script. The script generates -Wl,-u options to force
> --
> 2.27.0.windows.1
>
>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2020-08-25 9:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 8:34 [PATCH 1/5] meson: SIMPLE_PATH_RE should match the full path token. Or the $ and : contained in path would not matched. if the path are start with C:/ and E:/ luoyonggang
2020-08-25 8:34 ` [PATCH 2/5] meson: fixes relpath may fail on win32. for example C:/msys64/mingw64/x.exe relative to E:/path/qemu-build would fail luoyonggang
2020-08-25 9:04 ` Daniel P. Berrangé
2020-08-25 8:34 ` [PATCH 3/5] meson: Mingw64 gcc doesn't recognize system include_type for sdl2 luoyonggang
2020-08-25 8:34 ` [PATCH 4/5] meson: !/bin/sh are msys2 friendly luoyonggang
2020-08-25 8:59 ` Daniel P. Berrangé [this message]
2020-08-25 9:11 ` 罗勇刚(Yonggang Luo)
2020-08-25 13:59 ` Eric Blake
2020-08-25 14:21 ` 罗勇刚(Yonggang Luo)
2020-08-25 8:35 ` [PATCH 5/5] configure: replace all $PWD with $build_path that can handling msys2 properly luoyonggang
2020-08-25 9:04 ` Daniel P. Berrangé
2020-08-25 9:05 ` [PATCH 1/5] meson: SIMPLE_PATH_RE should match the full path token. Or the $ and : contained in path would not matched. if the path are start with C:/ and E:/ Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825085949.GC107278@redhat.com \
--to=berrange@redhat.com \
--cc=luoyonggang@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).