From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9CA6C433E1 for ; Tue, 25 Aug 2020 11:09:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC8B52071E for ; Tue, 25 Aug 2020 11:09:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CB+U0WR1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC8B52071E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44574 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAWpV-0005WE-QP for qemu-devel@archiver.kernel.org; Tue, 25 Aug 2020 07:09:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39222) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAWoy-0004y6-AB for qemu-devel@nongnu.org; Tue, 25 Aug 2020 07:08:56 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:38520 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kAWow-0003gx-5z for qemu-devel@nongnu.org; Tue, 25 Aug 2020 07:08:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598353733; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lLvrkff4jEO5m823rODYTpT4QRQkMv5vytNspHTCsMQ=; b=CB+U0WR1xsONAc4Ai8z73HgfIHZZlEJPMT4uy/9QBXhEtAUjJgAyksI4ApLXnbl8XRC3GO MjeRC6JhSabJsW2Vvyv2A/jYk4vPONGafGJMOz/xPn2TMRd+kvQgNcCDuCEr2j5YziQfNk zGW0JxIBiyOB2dCBnu6GAKHioOTB/7Q= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-515-iOiKp1kRNw-wQpGVjslkjg-1; Tue, 25 Aug 2020 07:08:51 -0400 X-MC-Unique: iOiKp1kRNw-wQpGVjslkjg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B61DA189E600; Tue, 25 Aug 2020 11:08:49 +0000 (UTC) Received: from redhat.com (ovpn-114-231.ams2.redhat.com [10.36.114.231]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E8AB0808AA; Tue, 25 Aug 2020 11:08:46 +0000 (UTC) Date: Tue, 25 Aug 2020 12:08:44 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Eduardo Habkost Subject: Re: [PATCH v2 06/58] aspeed_soc: Rename memmap/irqmap enum constants Message-ID: <20200825110844.GN107278@redhat.com> References: <20200820001236.1284548-1-ehabkost@redhat.com> <20200820001236.1284548-7-ehabkost@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200820001236.1284548-7-ehabkost@redhat.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline Received-SPF: pass client-ip=207.211.31.120; envelope-from=berrange@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/25 01:37:44 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.958, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Peter Maydell , Andrew Jeffery , qemu-devel@nongnu.org, qemu-arm@nongnu.org, Joel Stanley , Paolo Bonzini , =?utf-8?Q?C=C3=A9dric?= Le Goater Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Aug 19, 2020 at 08:11:44PM -0400, Eduardo Habkost wrote: > Some of the enum constant names conflict with the QOM type check > macros: > > ASPEED_GPIO > ASPEED_I2C > ASPEED_RTC > ASPEED_SCU > ASPEED_SDHCI > ASPEED_SDMC > ASPEED_VIC > ASPEED_WDT > ASPEED_XDMA > > This needs to be addressed to allow us to transform the QOM type > check macros into functions generated by OBJECT_DECLARE_TYPE(). > > Rename all the constants to ASPEED_DEV_*, to avoid conflicts. > > Signed-off-by: Eduardo Habkost > --- > Changes v1 -> v2: > * Added more details to commit message > > --- > Cc: "Cédric Le Goater" > Cc: Peter Maydell > Cc: Andrew Jeffery > Cc: Joel Stanley > Cc: qemu-arm@nongnu.org > Cc: qemu-devel@nongnu.org > --- > include/hw/arm/aspeed_soc.h | 92 +++++++-------- > hw/arm/aspeed.c | 4 +- > hw/arm/aspeed_ast2600.c | 208 ++++++++++++++++---------------- > hw/arm/aspeed_soc.c | 228 ++++++++++++++++++------------------ > 4 files changed, 266 insertions(+), 266 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|