From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7942CC433DF for ; Tue, 25 Aug 2020 11:44:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 42A3220706 for ; Tue, 25 Aug 2020 11:44:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Mx0ilNt/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 42A3220706 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42282 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAXN0-0002BP-G8 for qemu-devel@archiver.kernel.org; Tue, 25 Aug 2020 07:44:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52402) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAXMV-0001kg-4i for qemu-devel@nongnu.org; Tue, 25 Aug 2020 07:43:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:38335) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kAXMT-0000hg-9u for qemu-devel@nongnu.org; Tue, 25 Aug 2020 07:43:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598355811; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+avlk1y1WFWNyWx4IvMmZU6wwUO/wH191KSEflJbQSU=; b=Mx0ilNt/cA++LowK9vaepX2kMxkW+LHu9aQm7OHFn750Lpx3B+H8KknijBgLAAYwxIpb4W xJIw8DdecFp3lQsADrCec5vcT34KagjWp5nNxmfP2aBwk5v1MiBVNpCmd41RY5c5eeNoec KMwZY0a2bvCDQ2a9Vtk2o3TwByTauq0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-312-1VIWsjiFPiyomsy2g7YDXA-1; Tue, 25 Aug 2020 07:43:26 -0400 X-MC-Unique: 1VIWsjiFPiyomsy2g7YDXA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4996A189E600 for ; Tue, 25 Aug 2020 11:43:25 +0000 (UTC) Received: from redhat.com (ovpn-114-231.ams2.redhat.com [10.36.114.231]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3F1A77C5F6; Tue, 25 Aug 2020 11:43:24 +0000 (UTC) Date: Tue, 25 Aug 2020 12:43:21 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Eduardo Habkost Subject: Re: [PATCH v2 54/58] [semi-automated] Use DECLARE_*CHECKER* when possible (--force mode) Message-ID: <20200825114321.GL107278@redhat.com> References: <20200820001236.1284548-1-ehabkost@redhat.com> <20200820001236.1284548-55-ehabkost@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200820001236.1284548-55-ehabkost@redhat.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/25 06:38:59 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.958, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Paolo Bonzini , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Aug 19, 2020 at 08:12:32PM -0400, Eduardo Habkost wrote: > Separate run of the TypeCheckMacro converter using the --force > flag, for the cases where typedefs weren't found in the same > header nor in typedefs.h. > > Generated initially using: > > $ ./scripts/codeconverter/converter.py --force -i \ > --pattern=TypeCheckMacro $(git grep -l '' -- '*.[ch]') > > Then each case was manually reviewed, and a comment was added > indicating what's unusual about those type checking > macros/functions. Despite not following the usual pattern, the > changes in this patch were found to be safe. > > Signed-off-by: Eduardo Habkost > --- > Changes v1 -> v2: > * Most of the old changes in this patch are now being handled by > the regular TypeCheckMacro patch (without --force mode) > * Added comments added explaining why these unusual changes > remain > --- > include/hw/intc/arm_gic.h | 9 +++------ > include/hw/intc/arm_gicv3.h | 8 +++----- > include/hw/ppc/xics_spapr.h | 4 +++- > include/hw/virtio/virtio-mmio.h | 9 +++------ > hw/intc/apic.c | 5 +++-- > hw/intc/arm_gic_kvm.c | 9 +++------ > hw/intc/arm_gicv3_its_kvm.c | 8 +++----- > hw/intc/arm_gicv3_kvm.c | 9 +++------ > hw/sd/allwinner-sdhost.c | 5 +++-- > hw/sd/bcm2835_sdhost.c | 5 +++-- > hw/sd/pxa2xx_mmci.c | 4 +++- > hw/sd/sdhci.c | 4 +++- > 12 files changed, 36 insertions(+), 43 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|