qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Henrique Barboza <danielhb413@gmail.com>
To: qemu-devel@nongnu.org
Cc: Daniel Henrique Barboza <danielhb413@gmail.com>,
	qemu-ppc@nongnu.org, david@gibson.dropbear.id.au
Subject: [PATCH 0/3] spapr NVDIMM: consider 'nvdimm' machine option
Date: Tue, 25 Aug 2020 18:57:46 -0300	[thread overview]
Message-ID: <20200825215749.213536-1-danielhb413@gmail.com> (raw)

This series aims to solve bug [1].

First patch is a trivial cleanup, feel free to squash into
patch 02. Patch 02 attempts a code simplification to put
all NVDIMM related logic in the same function.

Patch 03 is where the actual fix is implemented. My initial
approach here was to make the handling of '-machine nvdimm' for
pSeries similar to how it is handled elsewhere, but I wasn't
able to accomplish that without either (1) breaking up existing
pseries-5.1 guests that didn't care about this option or (2)
make pseries-5.1 and pseries-5.2+ machines to have different
semantics for it.

I ended up doing what I was sure was sensible: if the user puts
'-machine nvdimm=off', we must comply to that.


[1] https://bugzilla.redhat.com/show_bug.cgi?id=1848887

Daniel Henrique Barboza (3):
  ppc/spapr_nvdimm: use g_autofree in spapr_nvdimm_validate_opts()
  spapr, spapr_nvdimm: fold NVDIMM validation in the same place
  ppc/spapr_nvdimm: do not enable support with 'nvdimm=off'

 hw/ppc/spapr.c                | 18 ++++++------------
 hw/ppc/spapr_nvdimm.c         | 31 +++++++++++++++++++++++++++----
 include/hw/ppc/spapr_nvdimm.h |  4 ++--
 3 files changed, 35 insertions(+), 18 deletions(-)

-- 
2.26.2



             reply	other threads:[~2020-08-25 21:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-25 21:57 Daniel Henrique Barboza [this message]
2020-08-25 21:57 ` [PATCH 1/3] ppc/spapr_nvdimm: use g_autofree in spapr_nvdimm_validate_opts() Daniel Henrique Barboza
2020-08-25 21:57 ` [PATCH 2/3] spapr, spapr_nvdimm: fold NVDIMM validation in the same place Daniel Henrique Barboza
2020-08-25 21:57 ` [PATCH 3/3] ppc/spapr_nvdimm: do not enable support with 'nvdimm=off' Daniel Henrique Barboza
2020-08-28 13:17 ` [PATCH 0/3] spapr NVDIMM: consider 'nvdimm' machine option David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200825215749.213536-1-danielhb413@gmail.com \
    --to=danielhb413@gmail.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).