qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	"Daniel P. Berrange" <berrange@redhat.com>,
	qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH 3/8] amd_iommu: Use TYPE_AMD_IOMMU_PCI constant
Date: Thu, 27 Aug 2020 08:07:08 -0400	[thread overview]
Message-ID: <20200827080657-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20200826184334.4120620-4-ehabkost@redhat.com>

On Wed, Aug 26, 2020 at 02:43:29PM -0400, Eduardo Habkost wrote:
> This will make future conversion to use OBJECT_DECLARE* easier.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Cc: qemu-devel@nongnu.org

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

feel free to merge with the rest of the patch.

> ---
>  hw/i386/amd_iommu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
> index 087f601666..18411f1dec 100644
> --- a/hw/i386/amd_iommu.c
> +++ b/hw/i386/amd_iommu.c
> @@ -1622,7 +1622,7 @@ static const TypeInfo amdvi = {
>  };
>  
>  static const TypeInfo amdviPCI = {
> -    .name = "AMDVI-PCI",
> +    .name = TYPE_AMD_IOMMU_PCI,
>      .parent = TYPE_PCI_DEVICE,
>      .instance_size = sizeof(AMDVIPCIState),
>      .interfaces = (InterfaceInfo[]) {
> -- 
> 2.26.2



  parent reply	other threads:[~2020-08-27 12:08 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-26 18:43 [PATCH 0/8] qom: Use TYPE_* constants Eduardo Habkost
2020-08-26 18:43 ` [PATCH 1/8] etsec: Use TYPE_ETSEC_COMMON constant Eduardo Habkost
2020-08-27  0:01   ` David Gibson
2020-08-27  1:27   ` Li Qiang
2020-08-26 18:43 ` [PATCH 2/8] nios2_iic: Use TYPE_ALTERA_IIC constant Eduardo Habkost
2020-08-27  1:28   ` Li Qiang
2020-08-26 18:43 ` [PATCH 3/8] amd_iommu: Use TYPE_AMD_IOMMU_PCI constant Eduardo Habkost
2020-08-27  1:29   ` Li Qiang
2020-08-27 12:07   ` Michael S. Tsirkin [this message]
2020-08-26 18:43 ` [PATCH 4/8] sclpconsole: Use TYPE_* constants Eduardo Habkost
2020-08-27  1:29   ` Li Qiang
2020-08-27  4:42   ` Thomas Huth
2020-08-27  7:14   ` Cornelia Huck
2020-08-26 18:43 ` [PATCH 5/8] xlnx-zcu102: Use TYPE_ZCU102_MACHINE constant Eduardo Habkost
2020-08-26 18:44   ` Edgar E. Iglesias
2020-08-26 19:25   ` Alistair Francis
2020-08-27  1:31   ` Li Qiang
2020-08-26 18:43 ` [PATCH 6/8] tosa: Use TYPE_TOSA_MISC_GPIO constant Eduardo Habkost
2020-08-27  1:32   ` Li Qiang
2020-08-26 18:43 ` [PATCH 7/8] ppce500: Use TYPE_PPC_E500_PCI_BRIDGE constant Eduardo Habkost
2020-08-27  0:01   ` David Gibson
2020-08-27  1:32   ` Li Qiang
2020-08-26 18:43 ` [PATCH 8/8] dc390: Use TYPE_DC390_DEVICE constant Eduardo Habkost
2020-08-27  1:33   ` Li Qiang
2020-08-27 18:22 ` [PATCH 0/8] qom: Use TYPE_* constants Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200827080657-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=berrange@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).