qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: P J P <ppandit@redhat.com>
To: "Michael S . Tsirkin" <mst@redhat.com>
Cc: Ruhr-University <bugs-syssec@rub.de>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Prasad J Pandit <pjp@fedoraproject.org>
Subject: [PATCH] pci: check bus pointer before dereference
Date: Thu, 27 Aug 2020 17:19:17 +0530	[thread overview]
Message-ID: <20200827114917.1851111-1-ppandit@redhat.com> (raw)

From: Prasad J Pandit <pjp@fedoraproject.org>

While mapping IRQ level in pci_change_irq_level() routine,
it does not check if pci_get_bus() returned a valid pointer.
It may lead to a NULL pointer dereference issue. Add check to
avoid it.

 -> https://ruhr-uni-bochum.sciebo.de/s/NNWP2GfwzYKeKwE?path=%2Flsi_nullptr1
    ==1183858==Hint: address points to the zero page.
    #0 pci_change_irq_level hw/pci/pci.c:259
    #1 pci_irq_handler hw/pci/pci.c:1445
    #2 pci_set_irq hw/pci/pci.c:1463
    #3 lsi_set_irq hw/scsi/lsi53c895a.c:488
    #4 lsi_update_irq hw/scsi/lsi53c895a.c:523
    #5 lsi_script_scsi_interrupt hw/scsi/lsi53c895a.c:554
    #6 lsi_execute_script hw/scsi/lsi53c895a.c:1149
    #7 lsi_reg_writeb hw/scsi/lsi53c895a.c:1984
    #8 lsi_io_write hw/scsi/lsi53c895a.c:2146
    ...

Reported-by: Ruhr-University <bugs-syssec@rub.de>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
---
 hw/pci/pci.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index de0fae10ab..df5a2c3294 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -253,6 +253,9 @@ static void pci_change_irq_level(PCIDevice *pci_dev, int irq_num, int change)
     PCIBus *bus;
     for (;;) {
         bus = pci_get_bus(pci_dev);
+        if (!bus) {
+            return;
+        }
         irq_num = bus->map_irq(pci_dev, irq_num);
         if (bus->set_irq)
             break;
-- 
2.26.2



             reply	other threads:[~2020-08-27 11:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-27 11:49 P J P [this message]
2020-09-15 12:46 ` [PATCH] pci: check bus pointer before dereference P J P
2020-09-15 13:51 ` Li Qiang
2020-09-15 16:26   ` Philippe Mathieu-Daudé
2020-09-16  6:27     ` P J P
2020-09-16 12:19       ` Peter Maydell
2020-09-28 11:03         ` P J P
2020-09-30  5:02           ` P J P
2020-09-30  6:45             ` Igor Mammedov
2020-09-30 10:14               ` P J P
2020-10-30  9:01             ` Michael S. Tsirkin
2020-10-30 10:50               ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200827114917.1851111-1-ppandit@redhat.com \
    --to=ppandit@redhat.com \
    --cc=bugs-syssec@rub.de \
    --cc=mst@redhat.com \
    --cc=pjp@fedoraproject.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).