From: elena.ufimtseva@oracle.com
To: qemu-devel@nongnu.org
Cc: elena.ufimtseva@oracle.com, fam@euphon.net,
swapnil.ingle@nutanix.com, john.g.johnson@oracle.com,
kraxel@redhat.com, jag.raman@oracle.com, quintela@redhat.com,
mst@redhat.com, armbru@redhat.com, kanth.ghatraju@oracle.com,
felipe@nutanix.com, thuth@redhat.com, ehabkost@redhat.com,
konrad.wilk@oracle.com, dgilbert@redhat.com, stefanha@redhat.com,
thanos.makatos@nutanix.com, rth@twiddle.net, kwolf@redhat.com,
berrange@redhat.com, mreitz@redhat.com,
ross.lagerwall@citrix.com, marcandre.lureau@gmail.com,
pbonzini@redhat.com
Subject: [PATCH v9 07/20] multi-process: define transmission functions in remote
Date: Thu, 27 Aug 2020 11:12:18 -0700 [thread overview]
Message-ID: <20200827181231.22778-8-elena.ufimtseva@oracle.com> (raw)
In-Reply-To: <20200827181231.22778-1-elena.ufimtseva@oracle.com>
From: Elena Ufimtseva <elena.ufimtseva@oracle.com>
remote process uses Qemu event loop and cannot block while
communicating with the remote proxy object.
This patch defines the co-routines to receive and send
messages to the proxy from remote process.
TODO: Avoid the aio_poll by entering the co-routines
from the higher level to avoid aio_poll.
Signed-off-by: Elena Ufimtseva <elena.ufimtseva@oracle.com>
Signed-off-by: John G Johnson <john.g.johnson@oracle.com>
Signed-off-by: Jagannathan Raman <jag.raman@oracle.com>
---
include/io/mpqemu-link.h | 12 +++++
io/mpqemu-link.c | 108 +++++++++++++++++++++++++++++++++++++++
2 files changed, 120 insertions(+)
diff --git a/include/io/mpqemu-link.h b/include/io/mpqemu-link.h
index c7de8648bc..e02b5ce663 100644
--- a/include/io/mpqemu-link.h
+++ b/include/io/mpqemu-link.h
@@ -52,6 +52,18 @@ typedef struct {
int num_fds;
} MPQemuMsg;
+struct MPQemuRequest {
+ MPQemuMsg *msg;
+ QIOChannel *ioc;
+ bool finished;
+ int error;
+};
+
+typedef struct MPQemuRequest MPQemuRequest;
+
+void mpqemu_msg_send_in_co(MPQemuRequest *req, QIOChannel *ioc, Error **errp);
+void mpqemu_msg_recv_in_co(MPQemuRequest *req, QIOChannel *ioc, Error **errp);
+
void mpqemu_msg_send(MPQemuMsg *msg, QIOChannel *ioc, Error **errp);
void mpqemu_msg_recv(MPQemuMsg *msg, QIOChannel *ioc, Error **errp);
diff --git a/io/mpqemu-link.c b/io/mpqemu-link.c
index d9be2bdeab..1dd776f81b 100644
--- a/io/mpqemu-link.c
+++ b/io/mpqemu-link.c
@@ -150,6 +150,114 @@ fail:
}
}
+static void coroutine_fn mpqemu_msg_send_co(void *data)
+{
+ MPQemuRequest *req = (MPQemuRequest *)data;
+ Error *local_err = NULL;
+
+ mpqemu_msg_send(req->msg, req->ioc, &local_err);
+ if (local_err) {
+ error_report("ERROR: failed to send command to remote %d, ",
+ req->msg->cmd);
+ req->finished = true;
+ req->error = -EINVAL;
+ return;
+ }
+
+ req->finished = true;
+}
+
+void mpqemu_msg_send_in_co(MPQemuRequest *req, QIOChannel *ioc,
+ Error **errp)
+{
+ Coroutine *co;
+
+ if (!req->ioc) {
+ if (errp) {
+ error_setg(errp, "Channel is set to NULL");
+ } else {
+ error_report("Channel is set to NULL");
+ }
+ return;
+ }
+
+ req->error = 0;
+ req->finished = false;
+
+ co = qemu_coroutine_create(mpqemu_msg_send_co, req);
+ qemu_coroutine_enter(co);
+
+ while (!req->finished) {
+ aio_poll(qemu_get_aio_context(), true);
+ }
+
+ if (req->error) {
+ if (errp) {
+ error_setg(errp, "Error sending message to proxy, "
+ "error %d", req->error);
+ } else {
+ error_report("Error sending message to proxy, "
+ "error %d", req->error);
+ }
+ }
+
+ return;
+}
+
+static void coroutine_fn mpqemu_msg_recv_co(void *data)
+{
+ MPQemuRequest *req = (MPQemuRequest *)data;
+ Error *local_err = NULL;
+
+ mpqemu_msg_recv(req->msg, req->ioc, &local_err);
+ if (local_err) {
+ error_report("ERROR: failed to send command to remote %d, ",
+ req->msg->cmd);
+ req->finished = true;
+ req->error = -EINVAL;
+ return;
+ }
+
+ req->finished = true;
+}
+
+void mpqemu_msg_recv_in_co(MPQemuRequest *req, QIOChannel *ioc,
+ Error **errp)
+{
+ Coroutine *co;
+
+ if (!req->ioc) {
+ if (errp) {
+ error_setg(errp, "Channel is set to NULL");
+ } else {
+ error_report("Channel is set to NULL");
+ }
+ return;
+ }
+
+ req->error = 0;
+ req->finished = false;
+
+ co = qemu_coroutine_create(mpqemu_msg_recv_co, req);
+ qemu_coroutine_enter(co);
+
+ while (!req->finished) {
+ aio_poll(qemu_get_aio_context(), true);
+ }
+
+ if (req->error) {
+ if (errp) {
+ error_setg(errp, "Error sending message to proxy, "
+ "error %d", req->error);
+ } else {
+ error_report("Error sending message to proxy, "
+ "error %d", req->error);
+ }
+ }
+
+ return;
+}
+
bool mpqemu_msg_valid(MPQemuMsg *msg)
{
if (msg->cmd >= MAX && msg->cmd < 0) {
--
2.25.GIT
next prev parent reply other threads:[~2020-08-27 18:24 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 18:12 [PATCH v9 00/20] Initial support for multi-process Qemu elena.ufimtseva
2020-08-27 18:12 ` [PATCH v9 01/20] memory: alloc RAM from file at offset elena.ufimtseva
2020-08-27 18:12 ` [PATCH v9 02/20] multi-process: Add config option for multi-process QEMU elena.ufimtseva
2020-08-27 18:12 ` [PATCH v9 03/20] multi-process: setup PCI host bridge for remote device elena.ufimtseva
2020-09-14 15:46 ` Stefan Hajnoczi
2020-08-27 18:12 ` [PATCH v9 04/20] multi-process: setup a machine object for remote device process elena.ufimtseva
2020-09-15 13:01 ` Stefan Hajnoczi
2020-08-27 18:12 ` [PATCH v9 05/20] multi-process: add qio channel function to transmit elena.ufimtseva
2020-08-27 18:12 ` [PATCH v9 06/20] multi-process: define MPQemuMsg format and transmission functions elena.ufimtseva
2020-09-23 13:47 ` Stefan Hajnoczi
2020-08-27 18:12 ` elena.ufimtseva [this message]
2020-09-23 14:02 ` [PATCH v9 07/20] multi-process: define transmission functions in remote Stefan Hajnoczi
2020-09-24 17:18 ` Elena Ufimtseva
2020-08-27 18:12 ` [PATCH v9 08/20] multi-process: Initialize message handler in remote device elena.ufimtseva
2020-09-23 14:10 ` Stefan Hajnoczi
2020-09-24 17:20 ` Elena Ufimtseva
2020-08-27 18:12 ` [PATCH v9 09/20] multi-process: Associate fd of a PCIDevice with its object elena.ufimtseva
2020-09-23 14:17 ` Stefan Hajnoczi
2020-08-27 18:12 ` [PATCH v9 10/20] multi-process: setup memory manager for remote device elena.ufimtseva
2020-09-23 15:03 ` Stefan Hajnoczi
2020-08-27 18:12 ` [PATCH v9 11/20] multi-process: introduce proxy object elena.ufimtseva
2020-09-23 15:06 ` Stefan Hajnoczi
2020-09-23 15:10 ` Michael S. Tsirkin
2020-09-24 14:33 ` Jag Raman
2020-08-27 18:12 ` [PATCH v9 12/20] multi-process: add proxy communication functions elena.ufimtseva
2020-09-23 15:55 ` Stefan Hajnoczi
2020-08-27 18:12 ` [PATCH v9 13/20] multi-process: Forward PCI config space acceses to the remote process elena.ufimtseva
2020-09-23 16:01 ` Stefan Hajnoczi
2020-08-27 18:12 ` [PATCH v9 14/20] multi-process: PCI BAR read/write handling for proxy & remote endpoints elena.ufimtseva
2020-09-24 7:51 ` Stefan Hajnoczi
2020-08-27 18:12 ` [PATCH v9 15/20] multi-process: Synchronize remote memory elena.ufimtseva
2020-09-24 8:27 ` Stefan Hajnoczi
2020-08-27 18:12 ` [PATCH v9 16/20] multi-process: create IOHUB object to handle irq elena.ufimtseva
2020-09-24 8:29 ` Stefan Hajnoczi
2020-08-27 18:12 ` [PATCH v9 17/20] multi-process: Retrieve PCI info from remote process elena.ufimtseva
2020-09-24 8:30 ` Stefan Hajnoczi
2020-08-27 18:12 ` [PATCH v9 18/20] multi-process: perform device reset in the " elena.ufimtseva
2020-09-24 8:31 ` Stefan Hajnoczi
2020-08-27 18:12 ` [PATCH v9 19/20] multi-process: add the concept description to docs/devel/qemu-multiprocess elena.ufimtseva
2020-09-24 8:32 ` Stefan Hajnoczi
2020-08-27 18:12 ` [PATCH v9 20/20] multi-process: add configure and usage information elena.ufimtseva
2020-09-24 8:32 ` Stefan Hajnoczi
2020-09-23 15:47 ` [PATCH v9 00/20] Initial support for multi-process Qemu Michael S. Tsirkin
2020-09-24 8:38 ` Stefan Hajnoczi
2020-09-24 14:33 ` Jag Raman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827181231.22778-8-elena.ufimtseva@oracle.com \
--to=elena.ufimtseva@oracle.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=felipe@nutanix.com \
--cc=jag.raman@oracle.com \
--cc=john.g.johnson@oracle.com \
--cc=kanth.ghatraju@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=ross.lagerwall@citrix.com \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
--cc=swapnil.ingle@nutanix.com \
--cc=thanos.makatos@nutanix.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).