From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, stefanha@redhat.com, vgoyal@redhat.com,
slp@redhat.com, yezhenyu2@huawei.com, longpeng2@huawei.com,
berrange@redhat.com
Subject: [PULL 7/8] virtiofsd: drop CAP_DAC_READ_SEARCH
Date: Fri, 28 Aug 2020 13:45:08 +0100 [thread overview]
Message-ID: <20200828124509.311210-8-dgilbert@redhat.com> (raw)
In-Reply-To: <20200828124509.311210-1-dgilbert@redhat.com>
From: Stefan Hajnoczi <stefanha@redhat.com>
virtiofsd does not need CAP_DAC_READ_SEARCH because it already has
the more powerful CAP_DAC_OVERRIDE. Drop it from the list of
capabilities.
This is important because container runtimes may not include
CAP_DAC_READ_SEARCH by default. This patch allows virtiofsd to reduce
its capabilities when running inside a Docker container.
Note that CAP_DAC_READ_SEARCH may be necessary again in the future if
virtiofsd starts using open_by_handle_at(2).
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20200727190223.422280-2-stefanha@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
tools/virtiofsd/passthrough_ll.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
index a9feb90fd0..784330e0e4 100644
--- a/tools/virtiofsd/passthrough_ll.c
+++ b/tools/virtiofsd/passthrough_ll.c
@@ -2596,7 +2596,6 @@ static void setup_capabilities(char *modcaps_in)
if (capng_updatev(CAPNG_ADD, CAPNG_PERMITTED | CAPNG_EFFECTIVE,
CAP_CHOWN,
CAP_DAC_OVERRIDE,
- CAP_DAC_READ_SEARCH,
CAP_FOWNER,
CAP_FSETID,
CAP_SETGID,
--
2.26.2
next prev parent reply other threads:[~2020-08-28 12:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 12:45 [PULL 0/8] migration and virtiofsd queue Dr. David Alan Gilbert (git)
2020-08-28 12:45 ` [PULL 1/8] migration: unify the framework of socket-type channel Dr. David Alan Gilbert (git)
2020-08-28 12:45 ` [PULL 2/8] migration: add vsock as data channel support Dr. David Alan Gilbert (git)
2020-08-28 12:45 ` [PULL 3/8] migration: improve error reporting of block driver state name Dr. David Alan Gilbert (git)
2020-08-28 12:45 ` [PULL 4/8] migration: tls: fix memory leak in migration_tls_get_creds Dr. David Alan Gilbert (git)
2020-08-28 12:45 ` [PULL 5/8] virtiofsd: Disable remote posix locks by default Dr. David Alan Gilbert (git)
2020-08-28 12:45 ` [PULL 6/8] virtiofsd: Remove "norace" from cmdline help and docs Dr. David Alan Gilbert (git)
2020-08-28 12:45 ` Dr. David Alan Gilbert (git) [this message]
2020-08-28 12:45 ` [PULL 8/8] virtiofsd: probe unshare(CLONE_FS) and print an error Dr. David Alan Gilbert (git)
2020-08-28 21:29 ` [PULL 0/8] migration and virtiofsd queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200828124509.311210-8-dgilbert@redhat.com \
--to=dgilbert@redhat.com \
--cc=berrange@redhat.com \
--cc=longpeng2@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=slp@redhat.com \
--cc=stefanha@redhat.com \
--cc=vgoyal@redhat.com \
--cc=yezhenyu2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).