From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADDD7C433E6 for ; Mon, 31 Aug 2020 10:47:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A2C8206F0 for ; Mon, 31 Aug 2020 10:47:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AYdTUSLW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A2C8206F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41572 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kChLy-0004Pd-Lf for qemu-devel@archiver.kernel.org; Mon, 31 Aug 2020 06:47:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43036) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kChLH-0003ZN-UG for qemu-devel@nongnu.org; Mon, 31 Aug 2020 06:47:15 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:29937 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kChLG-0006GL-7g for qemu-devel@nongnu.org; Mon, 31 Aug 2020 06:47:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598870833; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=umknKpRa/Hk2w4cmnV/bbQBB8EnHVqB/Mwx8H/7by9M=; b=AYdTUSLWzDbHRGAt1eH+QLqAjqq9PGLAmzi8gZUFlN9rz2Kr+nShJaMc8CtCm35ZN0OxxL WMS1SBwzHh4YKBDtFjnhDpkNiUyH8CajnsAW6+D8uIgpM8VaxznLCuO2YEahCZ+zbpCiKr XyzoP/PLg526/sd3UWWerabzR4kdIno= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-42-mNxAhh8MOAieKs1vym2xJA-1; Mon, 31 Aug 2020 06:47:11 -0400 X-MC-Unique: mNxAhh8MOAieKs1vym2xJA-1 Received: by mail-wm1-f69.google.com with SMTP id f125so1452269wma.3 for ; Mon, 31 Aug 2020 03:47:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=umknKpRa/Hk2w4cmnV/bbQBB8EnHVqB/Mwx8H/7by9M=; b=pNYfxlRYSIzId8rQ6/CD9LhhT9/YNEF+7giownAyh7D60Xzv4Xkjz2Y8dKyVdlkoF1 6hyQrHeKgWjVtRP3oxBmKb87op8YrMAqqnZIrnHuMx3gJXjxJLp7qOO4RkmqI5Uio6eA LIcR3QI1Oab4BCvtxXnbgEujR64qr/kDHpzDiiRjNqQ2/9SjE0HR4E5zB82PD0K28AUU 4u28FvIGH2vbBqFRRYFWKR0bIBk1yL90DDOgDJy+c/c1TLlDuetaG5bfcS1TN+5TRlYi iqk1Mrxz1kWgluSb911AePD2QgBS30jMd2UZNBtnSHOiB0NaZldNfYP5k7wxU3m77zIb 1SzA== X-Gm-Message-State: AOAM531ayjapT3lyekiVd3R+ZPldOePe2s7yHxZTIYfjmvmcQ59h4A+B a0jgs0qgGwcrhNovw4ud+/jvCdMV5l4jZvO9xutboaBj77WfWDMAyayd5zcGSfiNSSisLO7A/YQ k3GLGCX6AxlYmoQM= X-Received: by 2002:a5d:644b:: with SMTP id d11mr1013447wrw.373.1598870830289; Mon, 31 Aug 2020 03:47:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyp0N51/sBROKOQg7uX3JoT2sanhwRg1O3CLhGEA9lqObh6ffILLVclPtTcMj+ehy3Nm9+Guw== X-Received: by 2002:a5d:644b:: with SMTP id d11mr1013434wrw.373.1598870830097; Mon, 31 Aug 2020 03:47:10 -0700 (PDT) Received: from redhat.com (bzq-79-181-14-13.red.bezeqint.net. [79.181.14.13]) by smtp.gmail.com with ESMTPSA id 33sm12181796wri.16.2020.08.31.03.47.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Aug 2020 03:47:09 -0700 (PDT) Date: Mon, 31 Aug 2020 06:46:56 -0400 From: "Michael S. Tsirkin" To: Chen Qun Subject: Re: [PATCH 05/11] hw/virtio/vhost-user:Remove dead assignment in scrub_shadow_regions() Message-ID: <20200831064640-mutt-send-email-mst@kernel.org> References: <20200813073712.4001404-1-kuhn.chenqun@huawei.com> <20200813073712.4001404-6-kuhn.chenqun@huawei.com> MIME-Version: 1.0 In-Reply-To: <20200813073712.4001404-6-kuhn.chenqun@huawei.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=205.139.110.61; envelope-from=mst@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/31 03:56:57 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, qemu-trivial@nongnu.org, pannengyuan@huawei.com, qemu-devel@nongnu.org, Raphael Norwitz , Euler Robot Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Aug 13, 2020 at 03:37:06PM +0800, Chen Qun wrote: > Clang static code analyzer show warning: > hw/virtio/vhost-user.c:606:9: warning: Value stored to 'mr' is never read > mr = vhost_user_get_mr_data(reg->userspace_addr, &offset, &fd); > ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Reported-by: Euler Robot > Signed-off-by: Chen Qun > --- > Cc: "Michael S. Tsirkin" > Cc: Raphael Norwitz Reviewed-by: Michael S. Tsirkin feel free to merge through the trivial tree > --- > hw/virtio/vhost-user.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c > index d7e2423762..9c5b4f7fbc 100644 > --- a/hw/virtio/vhost-user.c > +++ b/hw/virtio/vhost-user.c > @@ -603,7 +603,7 @@ static void scrub_shadow_regions(struct vhost_dev *dev, > */ > for (i = 0; i < dev->mem->nregions; i++) { > reg = &dev->mem->regions[i]; > - mr = vhost_user_get_mr_data(reg->userspace_addr, &offset, &fd); > + vhost_user_get_mr_data(reg->userspace_addr, &offset, &fd); > if (fd > 0) { > ++fd_num; > } > -- > 2.23.0