From: Jason Wang <jasowang@redhat.com>
To: jasowang@redhat.com, qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>, lulu@redhat.com, mst@redhat.com
Subject: [PATCH 9/9] vhost-vdpa: allow pre-opend file descriptor
Date: Mon, 31 Aug 2020 16:27:37 +0800 [thread overview]
Message-ID: <20200831082737.10983-10-jasowang@redhat.com> (raw)
In-Reply-To: <20200831082737.10983-1-jasowang@redhat.com>
This patch allows to initialize vhost-vdpa network backend with pre
opened vhost-vdpa file descriptor. This is useful for running
unprivileged qemu through libvirt.
Cc: Eric Blake <eblake@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
net/vhost-vdpa.c | 24 +++++++++++++++++++-----
qapi/net.json | 5 ++++-
2 files changed, 23 insertions(+), 6 deletions(-)
diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
index 9a6f0b63d3..f6385cd264 100644
--- a/net/vhost-vdpa.c
+++ b/net/vhost-vdpa.c
@@ -206,20 +206,34 @@ int net_init_vhost_vdpa(const Netdev *netdev, const char *name,
(char *)name, errp)) {
return -1;
}
- if (!opts->has_vhostdev) {
- error_setg(errp, "vhost-vdpa requires vhostdev to be set");
+ if (!(opts->has_vhostdev ^ opts->has_fd)) {
+ error_setg(errp, "Vhost-vdpa requires either vhostdev or fd to be set");
return -1;
}
assert(name);
nc = qemu_new_net_client(&net_vhost_vdpa_info, peer, TYPE_VHOST_VDPA, name);
- snprintf(nc->info_str, sizeof(nc->info_str), "vhostdev=%s", opts->vhostdev);
+ if (opts->has_vhostdev) {
+ snprintf(nc->info_str, sizeof(nc->info_str),
+ "vhostdev=%s", opts->vhostdev);
+ vdpa_device_fd = qemu_open(opts->vhostdev, O_RDWR);
+ if (vdpa_device_fd == -1) {
+ error_setg(errp, "Fail to open vhost-vdpa device %s",
+ opts->vhostdev);
+ return -errno;
+ }
+ } else {
+ snprintf(nc->info_str, sizeof(nc->info_str), "fd=%s", opts->fd);
+ vdpa_device_fd = monitor_fd_param(cur_mon, opts->fd, errp);
+ if (vdpa_device_fd == -1) {
+ return -1;
+ }
+ }
s = DO_UPCAST(VhostVDPAState, nc, nc);
- vdpa_device_fd = qemu_open(opts->vhostdev, O_RDWR);
if (vdpa_device_fd == -1) {
- error_setg(errp, "Fail to open vhost-vdpa device %s", opts->vhostdev);
+
return -errno;
}
s->vhost_vdpa.device_fd = vdpa_device_fd;
diff --git a/qapi/net.json b/qapi/net.json
index a2a94fad3e..5ad60c3045 100644
--- a/qapi/net.json
+++ b/qapi/net.json
@@ -442,12 +442,15 @@
# @queues: number of queues to be created for multiqueue vhost-vdpa
# (default: 1)
#
+# @fd: file descriptor of an already opened vhost-vdpa (since 5.2)
+#
# Since: 5.1
##
{ 'struct': 'NetdevVhostVDPAOptions',
'data': {
'*vhostdev': 'str',
- '*queues': 'int' } }
+ '*queues': 'int',
+ '*fd': 'str' } }
##
# @NetClientDriver:
--
2.20.1
next prev parent reply other threads:[~2020-08-31 8:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 8:27 [PATCH 0/9] refine vhost-vdpa initialization Jason Wang
2020-08-31 8:27 ` [PATCH 1/9] vhost-vdpa: remove the default devname Jason Wang
2020-09-09 8:40 ` Laurent Vivier
2020-08-31 8:27 ` [PATCH 2/9] vhost-vdpa: mandate vhostdev Jason Wang
2020-09-09 8:42 ` Laurent Vivier
2020-08-31 8:27 ` [PATCH 3/9] vhost-vdpa: remove the unnecessary assert(s->vhost_net) Jason Wang
2020-08-31 8:27 ` [PATCH 4/9] vhost-vdpa: refine info string Jason Wang
2020-09-16 15:52 ` Laurent Vivier
2020-08-31 8:27 ` [PATCH 5/9] vhost-vdpa: remove the unnecessary initialization Jason Wang
2020-09-16 15:53 ` Laurent Vivier
2020-08-31 8:27 ` [PATCH 6/9] vhost-vdpa: remove the unnecessary queue index assignment Jason Wang
2020-09-16 15:54 ` Laurent Vivier
2020-08-31 8:27 ` [PATCH 7/9] vhost-vdpa: squash net_vhost_vdpa_init() into net_init_vhost_vdpa() Jason Wang
2020-09-16 15:58 ` Laurent Vivier
2020-08-31 8:27 ` [PATCH 8/9] vhost-vdpa: add accurate error string when fail to open vhost vDPA device Jason Wang
2020-09-16 16:09 ` Laurent Vivier
2020-08-31 8:27 ` Jason Wang [this message]
2020-08-31 11:16 ` [PATCH 9/9] vhost-vdpa: allow pre-opend file descriptor Cindy Lu
2020-09-01 6:53 ` Jason Wang
2020-09-16 16:04 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200831082737.10983-10-jasowang@redhat.com \
--to=jasowang@redhat.com \
--cc=armbru@redhat.com \
--cc=lulu@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).