From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8564AC433E2 for ; Tue, 1 Sep 2020 11:09:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C75B20BED for ; Tue, 1 Sep 2020 11:09:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IOgoRUTS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C75B20BED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51404 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD4Al-0001fL-Cs for qemu-devel@archiver.kernel.org; Tue, 01 Sep 2020 07:09:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35320) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD49b-0000Lw-6f for qemu-devel@nongnu.org; Tue, 01 Sep 2020 07:08:43 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:48216) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kD49Z-0005FR-BA for qemu-devel@nongnu.org; Tue, 01 Sep 2020 07:08:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598958520; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6Tr/ubedH4FzcIkR/7uJBUdz/vyFk5iD5me4WlW9z0g=; b=IOgoRUTSeJynOvo73CM8QI9I2qZCkhfVFIU/Js3ohjSVRnX2NZhWuk4tURnulkIr93WO2P 2Gw0npktvKCG113JU9JTssLYzFObaaNd2u5h/eguYTRqbrUuyhVbw+9mCOx044YV491BXC f57Gau1h0dQJnnFGJYY+Hj6hb97A6pQ= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-386-ObHbQsmyM3WdewK9BEP-og-1; Tue, 01 Sep 2020 07:08:38 -0400 X-MC-Unique: ObHbQsmyM3WdewK9BEP-og-1 Received: by mail-wr1-f71.google.com with SMTP id k11so429213wrw.16 for ; Tue, 01 Sep 2020 04:08:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6Tr/ubedH4FzcIkR/7uJBUdz/vyFk5iD5me4WlW9z0g=; b=DUE0CS+gogzsnM7d8PV+aYw0Zd5btS8KFPM4oP91B/dGyz2Vacug+GCGVPca5U5wtZ y6pD+ZDzivVQXQlM90ljwI/9WsF5hsl+WoWOzzHG/KIYu+Bi2c0wRMS+tMlkJpRsONSU eIBiJeR0n7FfeRWSXOMbcboaQ8betHyqQehVIhnLzVAfhOE+3clFvPpVu7W9QQIZOQ6+ Y78uXVEb8AGHrHTcgmUAJISOMARuiUOJ3OaEgCHq0Pg8tI0UzAkucc7zd62TWGzsZPMh /P/G8okHRmX3nW/6NEUIeX1LI6Gjrwc3uNhsXubGsGxVncaLz70IetWWEUN0rP/7q7CD C4kQ== X-Gm-Message-State: AOAM531FJdUa/tIib0wHGlFbmIOnfZ7UYwDZ+QjPMmcAZ1xXCSyrgrMv 9ojKMMZDh9L7OXUwxi+7EEtfGWa3rOGrcuYf2GfufyeZjJwYVDv8QswZ8Z053ggDUpMfB6u9ECC smYepyLx4QQkfK3k= X-Received: by 2002:adf:e907:: with SMTP id f7mr1282104wrm.169.1598958514238; Tue, 01 Sep 2020 04:08:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyollsv5OseW626cQ2WmhnezuXDFvDBsAwbNO8ssbSMZozaw1xDJXzfL8vYitfAzZ5jltEtIw== X-Received: by 2002:adf:e907:: with SMTP id f7mr1282083wrm.169.1598958514038; Tue, 01 Sep 2020 04:08:34 -0700 (PDT) Received: from redhat.com (bzq-109-66-64-75.red.bezeqint.net. [109.66.64.75]) by smtp.gmail.com with ESMTPSA id d18sm1587679wrm.10.2020.09.01.04.08.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 04:08:33 -0700 (PDT) Date: Tue, 1 Sep 2020 07:08:29 -0400 From: "Michael S. Tsirkin" To: Nathan Chancellor Subject: Re: [PATCH] riscv: sifive_test: Allow 16-bit writes to memory region Message-ID: <20200901065406-mutt-send-email-mst@kernel.org> References: <20200901055822.2721209-1-natechancellor@gmail.com> MIME-Version: 1.0 In-Reply-To: <20200901055822.2721209-1-natechancellor@gmail.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0.003 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/31 23:17:53 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-riscv@nongnu.org, Sagar Karandikar , Bastian Koppelmann , Mark Cave-Ayland , qemu-devel@nongnu.org, qemu-stable@nongnu.org, Alistair Francis , Paolo Bonzini , Palmer Dabbelt Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Aug 31, 2020 at 10:58:23PM -0700, Nathan Chancellor wrote: > When shutting down the machine running a mainline Linux kernel, the > following error happens: > > $ build/riscv64-softmmu/qemu-system-riscv64 -bios default -M virt \ > -display none -initrd rootfs.cpio -kernel Image -m 512m \ > -nodefaults -serial mon:stdio > ... > Requesting system poweroff > [ 4.999630] reboot: Power down > sbi_trap_error: hart0: trap handler failed (error -2) > sbi_trap_error: hart0: mcause=0x0000000000000007 mtval=0x0000000000100000 > sbi_trap_error: hart0: mepc=0x000000008000d4cc mstatus=0x0000000000001822 > sbi_trap_error: hart0: ra=0x000000008000999e sp=0x0000000080015c78 > sbi_trap_error: hart0: gp=0xffffffe000e76610 tp=0xffffffe0081b89c0 > sbi_trap_error: hart0: s0=0x0000000080015c88 s1=0x0000000000000040 > sbi_trap_error: hart0: a0=0x0000000000000000 a1=0x0000000080004024 > sbi_trap_error: hart0: a2=0x0000000080004024 a3=0x0000000080004024 > sbi_trap_error: hart0: a4=0x0000000000100000 a5=0x0000000000005555 > sbi_trap_error: hart0: a6=0x0000000000004024 a7=0x0000000080011158 > sbi_trap_error: hart0: s2=0x0000000000000000 s3=0x0000000080016000 > sbi_trap_error: hart0: s4=0x0000000000000000 s5=0x0000000000000000 > sbi_trap_error: hart0: s6=0x0000000000000001 s7=0x0000000000000000 > sbi_trap_error: hart0: s8=0x0000000000000000 s9=0x0000000000000000 > sbi_trap_error: hart0: s10=0x0000000000000000 s11=0x0000000000000008 > sbi_trap_error: hart0: t0=0x0000000000000000 t1=0x0000000000000000 > sbi_trap_error: hart0: t2=0x0000000000000000 t3=0x0000000000000000 > sbi_trap_error: hart0: t4=0x0000000000000000 t5=0x0000000000000000 > sbi_trap_error: hart0: t6=0x0000000000000000 > > The kernel does a 16-bit write when powering off the machine, which > was allowed before commit 5d971f9e67 ("memory: Revert "memory: accept > mismatching sizes in memory_region_access_valid""). Make min_access_size > match reality so that the machine can shut down properly now. > > Cc: qemu-stable@nongnu.org > Fixes: 88a07990fa ("SiFive RISC-V Test Finisher") > Fixes: 5d971f9e67 ("memory: Revert "memory: accept mismatching sizes in memory_region_access_valid"") > Signed-off-by: Nathan Chancellor > --- > > Please let me know if the tags are wrong or inappropriate, this is my > first QEMU patch. > > hw/riscv/sifive_test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/riscv/sifive_test.c b/hw/riscv/sifive_test.c > index 0c78fb2c93..8c70dd69df 100644 > --- a/hw/riscv/sifive_test.c > +++ b/hw/riscv/sifive_test.c > @@ -59,7 +59,7 @@ static const MemoryRegionOps sifive_test_ops = { > .write = sifive_test_write, > .endianness = DEVICE_NATIVE_ENDIAN, Apropos, why is this native endian? The write handler seems to ignore target endian-ness, looks like a bug ... > .valid = { > - .min_access_size = 4, > + .min_access_size = 2, > .max_access_size = 4 > } > }; > > base-commit: 2f4c51c0f384d7888a04b4815861e6d5fd244d75 > -- > 2.28.0