From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 4/6] target/microblaze: Handle DISAS_EXIT_NEXT in delay slot
Date: Tue, 1 Sep 2020 09:02:23 +0200 [thread overview]
Message-ID: <20200901070223.GJ14249@toto> (raw)
In-Reply-To: <20200831184018.839906-5-richard.henderson@linaro.org>
On Mon, Aug 31, 2020 at 11:40:16AM -0700, Richard Henderson wrote:
> It is legal to put an mts instruction into a delay slot.
> We should continue to return to the main loop in that
> case so that we recognize any pending interrupts.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/microblaze/translate.c | 34 +++++++++++++++++++++++++++++++++-
> 1 file changed, 33 insertions(+), 1 deletion(-)
>
> diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c
> index 9c52448c06..b116a0ce4f 100644
> --- a/target/microblaze/translate.c
> +++ b/target/microblaze/translate.c
> @@ -1696,6 +1696,10 @@ static void mb_tr_translate_insn(DisasContextBase *dcb, CPUState *cs)
> dc->base.pc_next += 4;
>
> if (dc->jmp_cond != TCG_COND_NEVER && !(dc->tb_flags & D_FLAG)) {
> + /*
> + * Finish finish any return-from branch.
Typo, 2x finish.
With that fixed:
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
next prev parent reply other threads:[~2020-09-01 7:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 18:40 [PATCH 0/6] target/microblaze: Use tcg_gen_lookup_and_goto_ptr Richard Henderson
2020-08-31 18:40 ` [PATCH 1/6] target/microblaze: Rename DISAS_UPDATE to DISAS_EXIT Richard Henderson
2020-08-31 18:40 ` [PATCH 2/6] target/microblaze: Introduce DISAS_EXIT_NEXT, DISAS_EXIT_JUMP Richard Henderson
2020-08-31 18:40 ` [PATCH 3/6] target/microblaze: Replace cpustate_changed with DISAS_EXIT_NEXT Richard Henderson
2020-08-31 18:40 ` [PATCH 4/6] target/microblaze: Handle DISAS_EXIT_NEXT in delay slot Richard Henderson
2020-09-01 7:02 ` Edgar E. Iglesias [this message]
2020-08-31 18:40 ` [PATCH 5/6] target/microblaze: Force rtid, rted, rtbd to exit Richard Henderson
2020-08-31 18:40 ` [PATCH 6/6] target/microblaze: Use tcg_gen_lookup_and_goto_ptr Richard Henderson
2020-09-01 7:08 ` [PATCH 0/6] " Edgar E. Iglesias
2020-09-01 10:00 ` Edgar E. Iglesias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901070223.GJ14249@toto \
--to=edgar.iglesias@xilinx.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).