* [PATCH] hw/acpi/tco: Remove unused definitions
@ 2020-09-01 10:19 Philippe Mathieu-Daudé
2020-09-02 9:09 ` Laurent Vivier
2020-09-09 13:26 ` Laurent Vivier
0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-09-01 10:19 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-trivial, Igor Mammedov, Paulo Alcantara,
Philippe Mathieu-Daudé, Michael S. Tsirkin
TCO_DEBUG() and DEBUG definitions are not used, remove them.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/acpi/tco.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/hw/acpi/tco.c b/hw/acpi/tco.c
index fb9052dbca2..cf1e68a5393 100644
--- a/hw/acpi/tco.c
+++ b/hw/acpi/tco.c
@@ -15,17 +15,6 @@
#include "hw/acpi/tco.h"
#include "trace.h"
-//#define DEBUG
-
-#ifdef DEBUG
-#define TCO_DEBUG(fmt, ...) \
- do { \
- fprintf(stderr, "%s "fmt, __func__, ## __VA_ARGS__); \
- } while (0)
-#else
-#define TCO_DEBUG(fmt, ...) do { } while (0)
-#endif
-
enum {
TCO_RLD_DEFAULT = 0x0000,
TCO_DAT_IN_DEFAULT = 0x00,
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/acpi/tco: Remove unused definitions
2020-09-01 10:19 [PATCH] hw/acpi/tco: Remove unused definitions Philippe Mathieu-Daudé
@ 2020-09-02 9:09 ` Laurent Vivier
2020-09-09 13:26 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2020-09-02 9:09 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: qemu-trivial, Igor Mammedov, Paulo Alcantara, Michael S. Tsirkin
Le 01/09/2020 à 12:19, Philippe Mathieu-Daudé a écrit :
> TCO_DEBUG() and DEBUG definitions are not used, remove them.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/acpi/tco.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/hw/acpi/tco.c b/hw/acpi/tco.c
> index fb9052dbca2..cf1e68a5393 100644
> --- a/hw/acpi/tco.c
> +++ b/hw/acpi/tco.c
> @@ -15,17 +15,6 @@
> #include "hw/acpi/tco.h"
> #include "trace.h"
>
> -//#define DEBUG
> -
> -#ifdef DEBUG
> -#define TCO_DEBUG(fmt, ...) \
> - do { \
> - fprintf(stderr, "%s "fmt, __func__, ## __VA_ARGS__); \
> - } while (0)
> -#else
> -#define TCO_DEBUG(fmt, ...) do { } while (0)
> -#endif
> -
> enum {
> TCO_RLD_DEFAULT = 0x0000,
> TCO_DAT_IN_DEFAULT = 0x00,
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/acpi/tco: Remove unused definitions
2020-09-01 10:19 [PATCH] hw/acpi/tco: Remove unused definitions Philippe Mathieu-Daudé
2020-09-02 9:09 ` Laurent Vivier
@ 2020-09-09 13:26 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2020-09-09 13:26 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: qemu-trivial, Igor Mammedov, Paulo Alcantara, Michael S. Tsirkin
Le 01/09/2020 à 12:19, Philippe Mathieu-Daudé a écrit :
> TCO_DEBUG() and DEBUG definitions are not used, remove them.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/acpi/tco.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/hw/acpi/tco.c b/hw/acpi/tco.c
> index fb9052dbca2..cf1e68a5393 100644
> --- a/hw/acpi/tco.c
> +++ b/hw/acpi/tco.c
> @@ -15,17 +15,6 @@
> #include "hw/acpi/tco.h"
> #include "trace.h"
>
> -//#define DEBUG
> -
> -#ifdef DEBUG
> -#define TCO_DEBUG(fmt, ...) \
> - do { \
> - fprintf(stderr, "%s "fmt, __func__, ## __VA_ARGS__); \
> - } while (0)
> -#else
> -#define TCO_DEBUG(fmt, ...) do { } while (0)
> -#endif
> -
> enum {
> TCO_RLD_DEFAULT = 0x0000,
> TCO_DAT_IN_DEFAULT = 0x00,
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-09 13:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-01 10:19 [PATCH] hw/acpi/tco: Remove unused definitions Philippe Mathieu-Daudé
2020-09-02 9:09 ` Laurent Vivier
2020-09-09 13:26 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).