From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org,
"Peter Maydell" <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [PATCH 1/2] hw/gpio/omap_gpio: Replace fprintf() by qemu_log_mask(GUEST_ERROR)
Date: Tue, 1 Sep 2020 12:42:33 +0200 [thread overview]
Message-ID: <20200901104234.92159-2-f4bug@amsat.org> (raw)
In-Reply-To: <20200901104234.92159-1-f4bug@amsat.org>
Replace fprintf() by qemu_log_mask(LOG_GUEST_ERROR).
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/gpio/omap_gpio.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/gpio/omap_gpio.c b/hw/gpio/omap_gpio.c
index f662c4cb958..e25084b40c9 100644
--- a/hw/gpio/omap_gpio.c
+++ b/hw/gpio/omap_gpio.c
@@ -392,8 +392,10 @@ static void omap2_gpio_module_write(void *opaque, hwaddr addr,
break;
case 0x10: /* GPIO_SYSCONFIG */
- if (((value >> 3) & 3) == 3)
- fprintf(stderr, "%s: bad IDLEMODE value\n", __func__);
+ if (((value >> 3) & 3) == 3) {
+ qemu_log_mask(LOG_GUEST_ERROR,
+ "%s: Illegal IDLEMODE value: 3\n", __func__);
+ }
if (value & 2)
omap2_gpio_module_reset(s);
s->config[0] = value & 0x1d;
--
2.26.2
next prev parent reply other threads:[~2020-09-01 10:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 10:42 [PATCH 0/2] hw/gpio: Replace printf() calls by qemu_log_mask() Philippe Mathieu-Daudé
2020-09-01 10:42 ` Philippe Mathieu-Daudé [this message]
2020-09-02 9:15 ` [PATCH 1/2] hw/gpio/omap_gpio: Replace fprintf() by qemu_log_mask(GUEST_ERROR) Laurent Vivier
2020-09-09 13:27 ` Laurent Vivier
2020-09-01 10:42 ` [PATCH 2/2] hw/gpio/max7310: Replace disabled printf() by qemu_log_mask(UNIMP) Philippe Mathieu-Daudé
2020-09-02 9:17 ` Laurent Vivier
2020-09-09 13:30 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901104234.92159-2-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).