From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Claudio Fontana" <cfontana@suse.de>,
"Richard Henderson" <rth@twiddle.net>
Subject: [PATCH 1/2] cpus: Do not dump CPU state when calling hw_error()
Date: Tue, 1 Sep 2020 13:23:22 +0200 [thread overview]
Message-ID: <20200901112323.94969-2-f4bug@amsat.org> (raw)
In-Reply-To: <20200901112323.94969-1-f4bug@amsat.org>
We already have cpu_abort() to dump CPU states and abort.
Restrict hw_error() to peripheral errors, hoping we can completely
remove it by proper functions from "error-report.h" in the future.
Suggested-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
softmmu/cpus.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/softmmu/cpus.c b/softmmu/cpus.c
index a802e899abb..c96a04d7f18 100644
--- a/softmmu/cpus.c
+++ b/softmmu/cpus.c
@@ -913,16 +913,11 @@ static void stop_tcg_kick_timer(void)
void hw_error(const char *fmt, ...)
{
va_list ap;
- CPUState *cpu;
va_start(ap, fmt);
fprintf(stderr, "qemu: hardware error: ");
vfprintf(stderr, fmt, ap);
fprintf(stderr, "\n");
- CPU_FOREACH(cpu) {
- fprintf(stderr, "CPU #%d:\n", cpu->cpu_index);
- cpu_dump_state(cpu, stderr, CPU_DUMP_FPU);
- }
va_end(ap);
abort();
}
--
2.26.2
next prev parent reply other threads:[~2020-09-01 11:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 11:23 [PATCH 0/2] hw/core: Move hw_error() out of cpus.c Philippe Mathieu-Daudé
2020-09-01 11:23 ` Philippe Mathieu-Daudé [this message]
2020-09-02 6:33 ` [PATCH 1/2] cpus: Do not dump CPU state when calling hw_error() Thomas Huth
2020-09-02 16:04 ` Philippe Mathieu-Daudé
2020-09-01 11:23 ` [PATCH 2/2] hw/core: Move hw_error() out of cpus.c Philippe Mathieu-Daudé
2020-09-02 6:37 ` Thomas Huth
2020-09-02 15:38 ` Richard Henderson
2020-09-02 15:59 ` Philippe Mathieu-Daudé
2020-09-02 16:02 ` Thomas Huth
2020-09-02 16:13 ` Philippe Mathieu-Daudé
2020-09-01 16:44 ` [PATCH 0/2] " Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901112323.94969-2-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=cfontana@suse.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).