qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Halil Pasic <pasic@linux.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org,
	Eduardo Habkost <ehabkost@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] virtio: add Virtio*BusClass sizes
Date: Tue, 1 Sep 2020 14:57:06 +0200	[thread overview]
Message-ID: <20200901145706.34def7db.pasic@linux.ibm.com> (raw)
In-Reply-To: <20200824122051.99432-1-cohuck@redhat.com>

On Mon, 24 Aug 2020 14:20:51 +0200
Cornelia Huck <cohuck@redhat.com> wrote:

> Both VirtioPCIBusClass and VirtioCcwBusClass are typedefs of
> VirtioBusClass, but set .class_size in the TypeInfo anyway
> to be safe if that changes in the future.
> 
> Reported-by: Eduardo Habkost <ehabkost@redhat.com>
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>

Reviewed-by: Halil Pasic <pasic@linux.ibm.com>

> ---
>  hw/s390x/virtio-ccw.c  | 1 +
>  hw/virtio/virtio-pci.c | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c
> index 0e602702971b..8feb3451a098 100644
> --- a/hw/s390x/virtio-ccw.c
> +++ b/hw/s390x/virtio-ccw.c
> @@ -1237,6 +1237,7 @@ static const TypeInfo virtio_ccw_bus_info = {
>      .name = TYPE_VIRTIO_CCW_BUS,
>      .parent = TYPE_VIRTIO_BUS,
>      .instance_size = sizeof(VirtioCcwBusState),
> +    .class_size = sizeof(VirtioCcwBusClass),
>      .class_init = virtio_ccw_bus_class_init,
>  };
>  
> diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
> index ccdf54e81c78..45e7b65a8d24 100644
> --- a/hw/virtio/virtio-pci.c
> +++ b/hw/virtio/virtio-pci.c
> @@ -2101,6 +2101,7 @@ static const TypeInfo virtio_pci_bus_info = {
>      .name          = TYPE_VIRTIO_PCI_BUS,
>      .parent        = TYPE_VIRTIO_BUS,
>      .instance_size = sizeof(VirtioPCIBusState),
> +    .class_size    = sizeof(VirtioPCIBusClass),
>      .class_init    = virtio_pci_bus_class_init,
>  };
>  



      reply	other threads:[~2020-09-01 13:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-24 12:20 [PATCH] virtio: add Virtio*BusClass sizes Cornelia Huck
2020-09-01 12:57 ` Halil Pasic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200901145706.34def7db.pasic@linux.ibm.com \
    --to=pasic@linux.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).