* [PATCH 0/3] i440fx: unit tests for testing flag that enables/disables pci root hotplug
@ 2020-08-30 9:59 Ani Sinha
2020-08-30 9:59 ` [PATCH 1/3] tests/acpi: document addition of table DSDT.roothp for unit testing root pci hotplug on/off Ani Sinha
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Ani Sinha @ 2020-08-30 9:59 UTC (permalink / raw)
To: qemu-devel
Cc: Laurent Vivier, Thomas Huth, Michael S. Tsirkin, jusual,
Paolo Bonzini, Ani Sinha, Igor Mammedov
The following set of patches have been generated according to the guidelines provided in the
header comment in the file tests/qtest/bios-tables-test.c.
The first patch documents that a new ACPI table binary blob has been added. The new file is
listed in file tests/qtest/bios-tables-test-allowed-diff.h.
The second patch is the actual unit test.
The third patch actually adds the new ACPI table blob and then clears the file
tests/qtest/bios-tables-test-allowed-diff.h.
The unit test has been tested on the top of upstream master qemu tree v5.1.0 tag. I have not
tested this patch on the latest upstream master branch HEAD because there seems to be an issue
with the latest upstream tip with qemu crashing consistently.
Thanks to Igor for pushing on this.
--Ani
Ani Sinha (3):
tests/acpi: document addition of table DSDT.roothp for unit testing
root pci hotplug on/off
tests/acpi: add a new unit test to test hotplug off/on feature on the
root pci bus
tests/acpi: add a new ACPI table in order to test root pci hotplug
on/off
tests/data/acpi/pc/DSDT.roothp | Bin 0 -> 3215 bytes
tests/qtest/bios-tables-test.c | 14 ++++++++++++++
2 files changed, 14 insertions(+)
create mode 100644 tests/data/acpi/pc/DSDT.roothp
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/3] tests/acpi: document addition of table DSDT.roothp for unit testing root pci hotplug on/off
2020-08-30 9:59 [PATCH 0/3] i440fx: unit tests for testing flag that enables/disables pci root hotplug Ani Sinha
@ 2020-08-30 9:59 ` Ani Sinha
2020-08-30 9:59 ` [PATCH 2/3] tests/acpi: add a new unit test to test hotplug off/on feature on the root pci bus Ani Sinha
2020-08-30 9:59 ` [PATCH 3/3] tests/acpi: add a new ACPI table in order to test root pci hotplug on/off Ani Sinha
2 siblings, 0 replies; 6+ messages in thread
From: Ani Sinha @ 2020-08-30 9:59 UTC (permalink / raw)
To: qemu-devel
Cc: Laurent Vivier, Thomas Huth, Michael S. Tsirkin, jusual,
Paolo Bonzini, Ani Sinha, Igor Mammedov
A new binary acpi table tests/data/acpi/pc/DSDT.roothp is added in order to unit test
the feature flag that can disable/enable root pci bus hotplug on i440fx. This feature was
added with the commit:
3d7e78aa7777f0 ("Introduce a new flag for i440fx to disable PCI hotplug on the root bus")
This change documents the fact that this new file addition was made as a part of the
unit test change.
Signed-off-by: Ani Sinha <ani@anisinha.ca>
---
tests/qtest/bios-tables-test-allowed-diff.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8b..ac864fc982 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1 +1,2 @@
/* List of comma-separated changed AML files to ignore */
+"tests/data/acpi/pc/DSDT.roothp",
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/3] tests/acpi: add a new unit test to test hotplug off/on feature on the root pci bus
2020-08-30 9:59 [PATCH 0/3] i440fx: unit tests for testing flag that enables/disables pci root hotplug Ani Sinha
2020-08-30 9:59 ` [PATCH 1/3] tests/acpi: document addition of table DSDT.roothp for unit testing root pci hotplug on/off Ani Sinha
@ 2020-08-30 9:59 ` Ani Sinha
2020-09-01 13:51 ` Igor Mammedov
2020-08-30 9:59 ` [PATCH 3/3] tests/acpi: add a new ACPI table in order to test root pci hotplug on/off Ani Sinha
2 siblings, 1 reply; 6+ messages in thread
From: Ani Sinha @ 2020-08-30 9:59 UTC (permalink / raw)
To: qemu-devel
Cc: Laurent Vivier, Thomas Huth, Michael S. Tsirkin, jusual,
Paolo Bonzini, Ani Sinha, Igor Mammedov
Ability to turn hotplug off on the pci root bus for i440fx was added in commit:
3d7e78aa7777f0 ("Introduce a new flag for i440fx to disable PCI hotplug on the root bus")
This change adds a unit test in order to test this feature.
This change has been tested against upstream qemu master branch on top of tag v5.1.0.
Signed-off-by: Ani Sinha <ani@anisinha.ca>
---
tests/qtest/bios-tables-test.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index d49b3988ec..8f7d87c0f6 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -709,6 +709,19 @@ static void test_acpi_piix4_tcg_bridge(void)
free_test_data(&data);
}
+static void test_acpi_piix4_root_hotplug(void)
+{
+ test_data data;
+
+ memset(&data, 0, sizeof(data));
+ data.machine = MACHINE_PC;
+ data.variant = ".roothp";
+ data.required_struct_types = base_required_struct_types;
+ data.required_struct_types_len = ARRAY_SIZE(base_required_struct_types);
+ test_acpi_one("-global PIIX4_PM.acpi-root-pci-hotplug=off", &data);
+ free_test_data(&data);
+}
+
static void test_acpi_q35_tcg(void)
{
test_data data;
@@ -1102,6 +1115,7 @@ int main(int argc, char *argv[])
qtest_add_func("acpi/q35/tpm-tis", test_acpi_q35_tcg_tpm_tis);
qtest_add_func("acpi/piix4", test_acpi_piix4_tcg);
qtest_add_func("acpi/piix4/bridge", test_acpi_piix4_tcg_bridge);
+ qtest_add_func("acpi/piix4/hotplug", test_acpi_piix4_root_hotplug);
qtest_add_func("acpi/q35", test_acpi_q35_tcg);
qtest_add_func("acpi/q35/bridge", test_acpi_q35_tcg_bridge);
qtest_add_func("acpi/q35/mmio64", test_acpi_q35_tcg_mmio64);
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] tests/acpi: add a new ACPI table in order to test root pci hotplug on/off
2020-08-30 9:59 [PATCH 0/3] i440fx: unit tests for testing flag that enables/disables pci root hotplug Ani Sinha
2020-08-30 9:59 ` [PATCH 1/3] tests/acpi: document addition of table DSDT.roothp for unit testing root pci hotplug on/off Ani Sinha
2020-08-30 9:59 ` [PATCH 2/3] tests/acpi: add a new unit test to test hotplug off/on feature on the root pci bus Ani Sinha
@ 2020-08-30 9:59 ` Ani Sinha
2 siblings, 0 replies; 6+ messages in thread
From: Ani Sinha @ 2020-08-30 9:59 UTC (permalink / raw)
To: qemu-devel
Cc: Laurent Vivier, Thomas Huth, Michael S. Tsirkin, jusual,
Paolo Bonzini, Ani Sinha, Igor Mammedov
A new binary ACPI table tests/data/acpi/pc/DSDT.roothp is added in order
to unit test hotplug on/off capability on the root pci bus for i440fx.
The diff between the table DSDT and DSDT.roothp is listed below:
--- /tmp/asl-7VRVP0.dsl 2020-08-30 12:01:53.992010411 +0530
+++ /tmp/asl-96QVP0.dsl 2020-08-30 12:01:53.988010392 +0530
@@ -1,30 +1,30 @@
/*
* Intel ACPI Component Architecture
* AML/ASL+ Disassembler version 20180105 (64-bit version)
* Copyright (c) 2000 - 2018 Intel Corporation
*
* Disassembling to symbolic ASL+ operators
*
- * Disassembly of tests/data/acpi/pc/DSDT, Sun Aug 30 12:01:53 2020
+ * Disassembly of /tmp/aml-W5QVP0, Sun Aug 30 12:01:53 2020
*
* Original Table Header:
* Signature "DSDT"
- * Length 0x00001346 (4934)
+ * Length 0x00000C8F (3215)
* Revision 0x01 **** 32-bit table (V1), no 64-bit math support
- * Checksum 0xBF
+ * Checksum 0x3D
* OEM ID "BOCHS "
* OEM Table ID "BXPCDSDT"
* OEM Revision 0x00000001 (1)
* Compiler ID "BXPC"
* Compiler Version 0x00000001 (1)
*/
DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPCDSDT", 0x00000001)
{
Scope (\)
{
OperationRegion (DBG, SystemIO, 0x0402, One)
Field (DBG, ByteAcc, NoLock, Preserve)
{
DBGB, 8
}
@@ -831,489 +831,47 @@
Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
{
IO (Decode16,
0x0510, // Range Minimum
0x0510, // Range Maximum
0x01, // Alignment
0x0C, // Length
)
})
}
}
Scope (\_SB)
{
Scope (PCI0)
{
- Name (BSEL, Zero)
Device (S00)
{
Name (_ADR, Zero) // _ADR: Address
}
Device (S10)
{
Name (_ADR, 0x00020000) // _ADR: Address
Method (_S1D, 0, NotSerialized) // _S1D: S1 Device State
{
Return (Zero)
}
Method (_S2D, 0, NotSerialized) // _S2D: S2 Device State
{
Return (Zero)
}
Method (_S3D, 0, NotSerialized) // _S3D: S3 Device State
{
Return (Zero)
}
}
- Device (S18)
- {
- Name (_SUN, 0x03) // _SUN: Slot User Number
- Name (_ADR, 0x00030000) // _ADR: Address
- Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
- {
- PCEJ (BSEL, _SUN)
- }
- }
-
- Device (S20)
- {
- Name (_SUN, 0x04) // _SUN: Slot User Number
- Name (_ADR, 0x00040000) // _ADR: Address
- Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
- {
- PCEJ (BSEL, _SUN)
- }
- }
-
- Device (S28)
- {
- Name (_SUN, 0x05) // _SUN: Slot User Number
- Name (_ADR, 0x00050000) // _ADR: Address
- Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
- {
- PCEJ (BSEL, _SUN)
- }
- }
-
- Device (S30)
- {
- Name (_SUN, 0x06) // _SUN: Slot User Number
- Name (_ADR, 0x00060000) // _ADR: Address
- Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
- {
- PCEJ (BSEL, _SUN)
- }
- }
-
- Device (S38)
- {
- Name (_SUN, 0x07) // _SUN: Slot User Number
- Name (_ADR, 0x00070000) // _ADR: Address
- Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
- {
- PCEJ (BSEL, _SUN)
- }
- }
-
- Device (S40)
- {
- Name (_SUN, 0x08) // _SUN: Slot User Number
- Name (_ADR, 0x00080000) // _ADR: Address
- Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
- {
- PCEJ (BSEL, _SUN)
- }
- }
-
- Device (S48)
- {
- Name (_SUN, 0x09) // _SUN: Slot User Number
- Name (_ADR, 0x00090000) // _ADR: Address
- Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
- {
- PCEJ (BSEL, _SUN)
- }
- }
-
- Device (S50)
- {
- Name (_SUN, 0x0A) // _SUN: Slot User Number
- Name (_ADR, 0x000A0000) // _ADR: Address
- Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
- {
- PCEJ (BSEL, _SUN)
- }
- }
-
- Device (S58)
- {
- Name (_SUN, 0x0B) // _SUN: Slot User Number
- Name (_ADR, 0x000B0000) // _ADR: Address
- Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
- {
- PCEJ (BSEL, _SUN)
- }
- }
-
- Device (S60)
- {
- Name (_SUN, 0x0C) // _SUN: Slot User Number
- Name (_ADR, 0x000C0000) // _ADR: Address
- Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
- {
- PCEJ (BSEL, _SUN)
- }
- }
-
- Device (S68)
- {
- Name (_SUN, 0x0D) // _SUN: Slot User Number
- Name (_ADR, 0x000D0000) // _ADR: Address
- Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
- {
- PCEJ (BSEL, _SUN)
- }
- }
-
- Device (S70)
- {
- Name (_SUN, 0x0E) // _SUN: Slot User Number
- Name (_ADR, 0x000E0000) // _ADR: Address
- Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
- {
- PCEJ (BSEL, _SUN)
- }
- }
-
- Device (S78)
- {
- Name (_SUN, 0x0F) // _SUN: Slot User Number
- Name (_ADR, 0x000F0000) // _ADR: Address
- Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
- {
- PCEJ (BSEL, _SUN)
- }
- }
-
- Device (S80)
- {
- Name (_SUN, 0x10) // _SUN: Slot User Number
- Name (_ADR, 0x00100000) // _ADR: Address
- Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
- {
- PCEJ (BSEL, _SUN)
- }
- }
-
- Device (S88)
- {
- Name (_SUN, 0x11) // _SUN: Slot User Number
- Name (_ADR, 0x00110000) // _ADR: Address
- Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
- {
- PCEJ (BSEL, _SUN)
- }
- }
-
- Device (S90)
- {
- Name (_SUN, 0x12) // _SUN: Slot User Number
- Name (_ADR, 0x00120000) // _ADR: Address
- Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
- {
- PCEJ (BSEL, _SUN)
- }
- }
-
- Device (S98)
- {
- Name (_SUN, 0x13) // _SUN: Slot User Number
- Name (_ADR, 0x00130000) // _ADR: Address
- Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
- {
- PCEJ (BSEL, _SUN)
- }
- }
-
- Device (SA0)
- {
- Name (_SUN, 0x14) // _SUN: Slot User Number
- Name (_ADR, 0x00140000) // _ADR: Address
- Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
- {
- PCEJ (BSEL, _SUN)
- }
- }
-
- Device (SA8)
- {
- Name (_SUN, 0x15) // _SUN: Slot User Number
- Name (_ADR, 0x00150000) // _ADR: Address
- Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
- {
- PCEJ (BSEL, _SUN)
- }
- }
-
- Device (SB0)
- {
- Name (_SUN, 0x16) // _SUN: Slot User Number
- Name (_ADR, 0x00160000) // _ADR: Address
- Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
- {
- PCEJ (BSEL, _SUN)
- }
- }
-
- Device (SB8)
- {
- Name (_SUN, 0x17) // _SUN: Slot User Number
- Name (_ADR, 0x00170000) // _ADR: Address
- Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
- {
- PCEJ (BSEL, _SUN)
- }
- }
-
- Device (SC0)
- {
- Name (_SUN, 0x18) // _SUN: Slot User Number
- Name (_ADR, 0x00180000) // _ADR: Address
- Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
- {
- PCEJ (BSEL, _SUN)
- }
- }
-
- Device (SC8)
- {
- Name (_SUN, 0x19) // _SUN: Slot User Number
- Name (_ADR, 0x00190000) // _ADR: Address
- Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
- {
- PCEJ (BSEL, _SUN)
- }
- }
-
- Device (SD0)
- {
- Name (_SUN, 0x1A) // _SUN: Slot User Number
- Name (_ADR, 0x001A0000) // _ADR: Address
- Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
- {
- PCEJ (BSEL, _SUN)
- }
- }
-
- Device (SD8)
- {
- Name (_SUN, 0x1B) // _SUN: Slot User Number
- Name (_ADR, 0x001B0000) // _ADR: Address
- Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
- {
- PCEJ (BSEL, _SUN)
- }
- }
-
- Device (SE0)
- {
- Name (_SUN, 0x1C) // _SUN: Slot User Number
- Name (_ADR, 0x001C0000) // _ADR: Address
- Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
- {
- PCEJ (BSEL, _SUN)
- }
- }
-
- Device (SE8)
- {
- Name (_SUN, 0x1D) // _SUN: Slot User Number
- Name (_ADR, 0x001D0000) // _ADR: Address
- Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
- {
- PCEJ (BSEL, _SUN)
- }
- }
-
- Device (SF0)
- {
- Name (_SUN, 0x1E) // _SUN: Slot User Number
- Name (_ADR, 0x001E0000) // _ADR: Address
- Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
- {
- PCEJ (BSEL, _SUN)
- }
- }
-
- Device (SF8)
- {
- Name (_SUN, 0x1F) // _SUN: Slot User Number
- Name (_ADR, 0x001F0000) // _ADR: Address
- Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
- {
- PCEJ (BSEL, _SUN)
- }
- }
-
- Method (DVNT, 2, NotSerialized)
- {
- If ((Arg0 & 0x08))
- {
- Notify (S18, Arg1)
- }
-
- If ((Arg0 & 0x10))
- {
- Notify (S20, Arg1)
- }
-
- If ((Arg0 & 0x20))
- {
- Notify (S28, Arg1)
- }
-
- If ((Arg0 & 0x40))
- {
- Notify (S30, Arg1)
- }
-
- If ((Arg0 & 0x80))
- {
- Notify (S38, Arg1)
- }
-
- If ((Arg0 & 0x0100))
- {
- Notify (S40, Arg1)
- }
-
- If ((Arg0 & 0x0200))
- {
- Notify (S48, Arg1)
- }
-
- If ((Arg0 & 0x0400))
- {
- Notify (S50, Arg1)
- }
-
- If ((Arg0 & 0x0800))
- {
- Notify (S58, Arg1)
- }
-
- If ((Arg0 & 0x1000))
- {
- Notify (S60, Arg1)
- }
-
- If ((Arg0 & 0x2000))
- {
- Notify (S68, Arg1)
- }
-
- If ((Arg0 & 0x4000))
- {
- Notify (S70, Arg1)
- }
-
- If ((Arg0 & 0x8000))
- {
- Notify (S78, Arg1)
- }
-
- If ((Arg0 & 0x00010000))
- {
- Notify (S80, Arg1)
- }
-
- If ((Arg0 & 0x00020000))
- {
- Notify (S88, Arg1)
- }
-
- If ((Arg0 & 0x00040000))
- {
- Notify (S90, Arg1)
- }
-
- If ((Arg0 & 0x00080000))
- {
- Notify (S98, Arg1)
- }
-
- If ((Arg0 & 0x00100000))
- {
- Notify (SA0, Arg1)
- }
-
- If ((Arg0 & 0x00200000))
- {
- Notify (SA8, Arg1)
- }
-
- If ((Arg0 & 0x00400000))
- {
- Notify (SB0, Arg1)
- }
-
- If ((Arg0 & 0x00800000))
- {
- Notify (SB8, Arg1)
- }
-
- If ((Arg0 & 0x01000000))
- {
- Notify (SC0, Arg1)
- }
-
- If ((Arg0 & 0x02000000))
- {
- Notify (SC8, Arg1)
- }
-
- If ((Arg0 & 0x04000000))
- {
- Notify (SD0, Arg1)
- }
-
- If ((Arg0 & 0x08000000))
- {
- Notify (SD8, Arg1)
- }
-
- If ((Arg0 & 0x10000000))
- {
- Notify (SE0, Arg1)
- }
-
- If ((Arg0 & 0x20000000))
- {
- Notify (SE8, Arg1)
- }
-
- If ((Arg0 & 0x40000000))
- {
- Notify (SF0, Arg1)
- }
-
- If ((Arg0 & 0x80000000))
- {
- Notify (SF8, Arg1)
- }
- }
-
Method (PCNT, 0, NotSerialized)
{
- BNUM = Zero
- DVNT (PCIU, One)
- DVNT (PCID, 0x03)
}
}
}
}
Signed-off-by: Ani Sinha <ani@anisinha.ca>
---
tests/data/acpi/pc/DSDT.roothp | Bin 0 -> 3215 bytes
tests/qtest/bios-tables-test-allowed-diff.h | 1 -
2 files changed, 1 deletion(-)
create mode 100644 tests/data/acpi/pc/DSDT.roothp
diff --git a/tests/data/acpi/pc/DSDT.roothp b/tests/data/acpi/pc/DSDT.roothp
new file mode 100644
index 0000000000000000000000000000000000000000..ddabd997794b698e64efa43c58f40af35a7aebbd
GIT binary patch
literal 3215
zcmb7GUvCpf5TEs(!+Fn1&dIew@L~lhDpYWGC~8$z!rpUiC$@9=9NOw4-8l(rf{-`?
zkq8LY7zqL|6>_Qi&<BJ3oP31#Bk&RESD-5733ui$Hi?r+aFW-%v$He5`LnZQ+Gg$7
zH~{-TJ0}WuGW(+?Or$XYpgH|(MR@_7hMCQ~OpVCQd7uV!9I}f3m6@H-vp-h6-#zd4
zV~^E+SbV8HU#$BNH@rn4rnN<%bDC(AuAOzA=5b3D4aF@K&3NV&mlQW+RzY#+izd^`
zO30H_3RbSxV`9jJ+X$mz)yjZ~U%gjBb{=T79>0>Sm`ST@x=H<_Yu7U16UFn1RKM$S
z&1=V>wLEBfYPZ{g_Q<nV9e%6F;h+Da9q8~;#T8XMk>DebVrVf62N_@;v@gyP8iMOI
zj}`5V8(<}eAr$L^AtK!4vR0WmFZCFS%V}Pi&6>y@nkXT9MAcJslz*0I9(cf5o-M;N
z{!d0wo6|g5o}2HV8XezrO5xE-(1<IeOq-(bza!{50)Lzz&9gVs8wun*dndh<fK6V4
zGjbp}HC?hYJwH#I#j&IYJj&;|!T1)B@Kg93<HvcIU*~W6C|4AB+RP;;xK0_c`-|Yh
zX{Jk7E!8tm-ih5FxEdeMvpdoqNl_*n0fw}gEBDVtSs3sAXSStn36x1KICH966McuM
zJC+8beei)PlfW=a1?5AS8kVqYOodIZV0O?#VEE>fIG9PNVdrKri<M1|xueoTWR2Vm
zZe%OvDpR#^gBBuNnJ*_DmMw`{&`((+HxqGA(5l<@S7_5;XRAQRozq0_fL6im%evYu
zr;O1}?poCv_+ycV=R^HvHuk*E8~)uokHDgT?`C}wxCBdWt+j+qG0eD9W!8k{_Q}=~
zYbRQDF89ecEWa4;uQJG#Xf5$bpOW37NPUWcW&i&ABG&+O9yXQ%{CjoOx3SE?U*7QQ
zuvYJQ&V!TZB|=MSO9{=a>SaU0Aw@%)hABlKFJ4Bkwqy5rV+HR^tix6PV)3%5#*m?E
zBu2RUWC&tGvaG{XqVXt>#kTr<1#MoTd56eOvvdT_#AFQbMjY=R-E0MYWhXx8<4;B)
zCPgvJIQ~@pt%E)qT<Q*iAb5JhHH$Xfr#Wu~lu^0^fE=P4tS4N%YO|*+Aqp%6)gsY%
zv}XsjV={iU_S7!zsX%)Q@$J^0(ht_2a++nbT?}aFkxx*c-laYrs80{5PamQ_y`$b7
zRFBo^qphFXrG6?<KQ*9!>Jar)PIFF1>+M1Ha;UzSLR5e;<gqa1m}f&luyr-`F+oKV
zMOP~Y*Uf1PzVM;`TGd=%1s@8MYgkzG$-<4>{`Iw=lQ*y4y0Lb1>FO<Tn6OH-J4I!f
z^E`ts*kW<4v6xgr71`o(=fMeDWFRT5T!o2Z#b%;fzQV8|7z|_~$|jbYF=CR0ohv1g
z)6CS8dfY8mii!_JMB~pc1XT*Lg!qOt!YUd@${+;cQyA3~qBi|gq|I9^@JJYjv8oq_
zu!dz~&WVNda_@~H8wopAqCqk$^TBH$YYlD?dY_Ma&gp$SrP+?Bm!o9Srzv8CqENzt
z^7X=quth~V%nate%&0AoA#@)Gg`$Vsd3m2fK_t*!gY4*h=I=v>+&=SO%*yS;eo;X@
z4;ICx{j!i9WgTp2IVR@pTKq6W4~*A7uxPQrdVpO%j|@_Y_1Yj2U2q^e=ixV$Rd~hl
z!vw|5QaY4hn1kg^EunG+6zXnpcf>_IR5AuuR<G&DF@5t^&dnKV3{cSSP%2YYwK<u#
zf{VSA)y758zeU~@kR$rdQTTlBB3PmlAl<{E2|c_k^e~0p%_YwN+!%%kwqE#kX~5=b
zJH8!f3es6zBGNnD-j4Uz!}#z4{QGzUAl#=%rQ4-Pg}w*`JG~A^>308mAMX79_UYLV
zXF?jWb-UePdh8(;8uU+HnUK*1VOKV6RV*WeE(og+(RY=du;o!hyMnUwdh7KTlS#;o
zY!$3(=*Yc7&=m)iu>G=N6E>NSP0^PNsNSA($A)Bvm~no=9aCg%^st4))z`E`;I;2Q
zINNESoBlyehX5|;%JY~kY2wE2bvI%yszs?#Y881QXnCe(ij~t;ZNmtgWVGgto!VJo
XTq2;OoRkTjV3O`lrh>^3B?9~pFwX-n
literal 0
HcmV?d00001
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index ac864fc982..dfb8523c8b 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1,2 +1 @@
/* List of comma-separated changed AML files to ignore */
-"tests/data/acpi/pc/DSDT.roothp",
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] tests/acpi: add a new unit test to test hotplug off/on feature on the root pci bus
2020-08-30 9:59 ` [PATCH 2/3] tests/acpi: add a new unit test to test hotplug off/on feature on the root pci bus Ani Sinha
@ 2020-09-01 13:51 ` Igor Mammedov
2020-09-01 15:12 ` Ani Sinha
0 siblings, 1 reply; 6+ messages in thread
From: Igor Mammedov @ 2020-09-01 13:51 UTC (permalink / raw)
To: Ani Sinha
Cc: Laurent Vivier, Thomas Huth, Michael S. Tsirkin, jusual,
qemu-devel, Paolo Bonzini
On Sun, 30 Aug 2020 15:29:13 +0530
Ani Sinha <ani@anisinha.ca> wrote:
> Ability to turn hotplug off on the pci root bus for i440fx was added in commit:
> 3d7e78aa7777f0 ("Introduce a new flag for i440fx to disable PCI hotplug on the root bus")
>
> This change adds a unit test in order to test this feature.
>
> This change has been tested against upstream qemu master branch on top of tag v5.1.0.
>
> Signed-off-by: Ani Sinha <ani@anisinha.ca>
> ---
> tests/qtest/bios-tables-test.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index d49b3988ec..8f7d87c0f6 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -709,6 +709,19 @@ static void test_acpi_piix4_tcg_bridge(void)
> free_test_data(&data);
> }
>
> +static void test_acpi_piix4_root_hotplug(void)
> +{
> + test_data data;
> +
> + memset(&data, 0, sizeof(data));
> + data.machine = MACHINE_PC;
> + data.variant = ".roothp";
> + data.required_struct_types = base_required_struct_types;
> + data.required_struct_types_len = ARRAY_SIZE(base_required_struct_types);
> + test_acpi_one("-global PIIX4_PM.acpi-root-pci-hotplug=off", &data);
I'd include here bridge config as well (test_acpi_piix4_tcg_bridge)
so that ASL diff could show whether bridge was or wasn't affected.
> + free_test_data(&data);
> +}
> +
> static void test_acpi_q35_tcg(void)
> {
> test_data data;
> @@ -1102,6 +1115,7 @@ int main(int argc, char *argv[])
> qtest_add_func("acpi/q35/tpm-tis", test_acpi_q35_tcg_tpm_tis);
> qtest_add_func("acpi/piix4", test_acpi_piix4_tcg);
> qtest_add_func("acpi/piix4/bridge", test_acpi_piix4_tcg_bridge);
> + qtest_add_func("acpi/piix4/hotplug", test_acpi_piix4_root_hotplug);
> qtest_add_func("acpi/q35", test_acpi_q35_tcg);
> qtest_add_func("acpi/q35/bridge", test_acpi_q35_tcg_bridge);
> qtest_add_func("acpi/q35/mmio64", test_acpi_q35_tcg_mmio64);
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] tests/acpi: add a new unit test to test hotplug off/on feature on the root pci bus
2020-09-01 13:51 ` Igor Mammedov
@ 2020-09-01 15:12 ` Ani Sinha
0 siblings, 0 replies; 6+ messages in thread
From: Ani Sinha @ 2020-09-01 15:12 UTC (permalink / raw)
To: Igor Mammedov
Cc: Laurent Vivier, Thomas Huth, Michael S. Tsirkin, Julia Suvorova,
QEMU Developers, Paolo Bonzini
On Tue, Sep 1, 2020 at 7:21 PM Igor Mammedov <imammedo@redhat.com> wrote:
>
> On Sun, 30 Aug 2020 15:29:13 +0530
> Ani Sinha <ani@anisinha.ca> wrote:
>
> > Ability to turn hotplug off on the pci root bus for i440fx was added in commit:
> > 3d7e78aa7777f0 ("Introduce a new flag for i440fx to disable PCI hotplug on the root bus")
> >
> > This change adds a unit test in order to test this feature.
> >
> > This change has been tested against upstream qemu master branch on top of tag v5.1.0.
> >
> > Signed-off-by: Ani Sinha <ani@anisinha.ca>
> > ---
> > tests/qtest/bios-tables-test.c | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> > index d49b3988ec..8f7d87c0f6 100644
> > --- a/tests/qtest/bios-tables-test.c
> > +++ b/tests/qtest/bios-tables-test.c
> > @@ -709,6 +709,19 @@ static void test_acpi_piix4_tcg_bridge(void)
> > free_test_data(&data);
> > }
> >
> > +static void test_acpi_piix4_root_hotplug(void)
> > +{
> > + test_data data;
> > +
> > + memset(&data, 0, sizeof(data));
> > + data.machine = MACHINE_PC;
> > + data.variant = ".roothp";
> > + data.required_struct_types = base_required_struct_types;
> > + data.required_struct_types_len = ARRAY_SIZE(base_required_struct_types);
> > + test_acpi_one("-global PIIX4_PM.acpi-root-pci-hotplug=off", &data);
>
> I'd include here bridge config as well (test_acpi_piix4_tcg_bridge)
> so that ASL diff could show whether bridge was or wasn't affected.
Patch series v2 just sent.
>
> > + free_test_data(&data);
> > +}
> > +
> > static void test_acpi_q35_tcg(void)
> > {
> > test_data data;
> > @@ -1102,6 +1115,7 @@ int main(int argc, char *argv[])
> > qtest_add_func("acpi/q35/tpm-tis", test_acpi_q35_tcg_tpm_tis);
> > qtest_add_func("acpi/piix4", test_acpi_piix4_tcg);
> > qtest_add_func("acpi/piix4/bridge", test_acpi_piix4_tcg_bridge);
> > + qtest_add_func("acpi/piix4/hotplug", test_acpi_piix4_root_hotplug);
> > qtest_add_func("acpi/q35", test_acpi_q35_tcg);
> > qtest_add_func("acpi/q35/bridge", test_acpi_q35_tcg_bridge);
> > qtest_add_func("acpi/q35/mmio64", test_acpi_q35_tcg_mmio64);
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-01 15:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-30 9:59 [PATCH 0/3] i440fx: unit tests for testing flag that enables/disables pci root hotplug Ani Sinha
2020-08-30 9:59 ` [PATCH 1/3] tests/acpi: document addition of table DSDT.roothp for unit testing root pci hotplug on/off Ani Sinha
2020-08-30 9:59 ` [PATCH 2/3] tests/acpi: add a new unit test to test hotplug off/on feature on the root pci bus Ani Sinha
2020-09-01 13:51 ` Igor Mammedov
2020-09-01 15:12 ` Ani Sinha
2020-08-30 9:59 ` [PATCH 3/3] tests/acpi: add a new ACPI table in order to test root pci hotplug on/off Ani Sinha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).