From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9101C433E2 for ; Tue, 1 Sep 2020 16:26:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B322E206FA for ; Tue, 1 Sep 2020 16:26:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Nv+TweK1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B322E206FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56404 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kD97H-0007pK-Tt for qemu-devel@archiver.kernel.org; Tue, 01 Sep 2020 12:26:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38720) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kD967-0006R5-17 for qemu-devel@nongnu.org; Tue, 01 Sep 2020 12:25:28 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:60598 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kD964-0007T4-Tw for qemu-devel@nongnu.org; Tue, 01 Sep 2020 12:25:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598977523; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fypGgSNbn19lfXRqyjkxmF4wS6aTx1YPWhGCnAqWJRA=; b=Nv+TweK1jTtTY2Ucm7Zmv4mauzR4wsIjKrhBOrJseDRkuexvKCib/QbX/vcFtYJSiSu3NV qQtAjjJXea0HRpwXQT07JmmX6ucgxvzoj1vMi3xRlFJQwzvuDaXxuwjLvniq7C8D/IXyzu 7h7TSzSO+41F/bE/k1YuzVG1SmOUoo4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-390-9e5fAQAvOomxlsDKyaZMGA-1; Tue, 01 Sep 2020 12:25:18 -0400 X-MC-Unique: 9e5fAQAvOomxlsDKyaZMGA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0C0678014D9; Tue, 1 Sep 2020 16:25:17 +0000 (UTC) Received: from redhat.com (ovpn-114-215.ams2.redhat.com [10.36.114.215]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F10A161983; Tue, 1 Sep 2020 16:25:11 +0000 (UTC) Date: Tue, 1 Sep 2020 17:25:08 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Thomas Huth Subject: Re: [PATCH v2 5/7] dockerfiles/debian-win64-cross: Download WHPX MinGW headers Message-ID: <20200901162508.GV345480@redhat.com> References: <20200823111757.72002-1-thuth@redhat.com> <20200823111757.72002-6-thuth@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200823111757.72002-6-thuth@redhat.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline Received-SPF: pass client-ip=205.139.110.120; envelope-from=berrange@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/01 05:11:36 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Stefan Weil , qemu-devel@nongnu.org, Wainer dos Santos Moschetta , Alex =?utf-8?Q?Benn=C3=A9e?= , luoyonggang@gmail.com, Paolo Bonzini , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sun, Aug 23, 2020 at 01:17:55PM +0200, Thomas Huth wrote: > To compile-test the WHPX accelerator, we need to download these system > headers first (they are unfortunately not part of any released and > packaged MinGW toolchain yet). > > Idea taken from another patch by Stefan Weil. > > Message-Id: <20200804170055.2851-12-thuth@redhat.com> > Signed-off-by: Thomas Huth > --- > tests/docker/dockerfiles/debian-win64-cross.docker | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/tests/docker/dockerfiles/debian-win64-cross.docker b/tests/docker/dockerfiles/debian-win64-cross.docker > index 2fc9cfcbc6..4cc4a3f365 100644 > --- a/tests/docker/dockerfiles/debian-win64-cross.docker > +++ b/tests/docker/dockerfiles/debian-win64-cross.docker > @@ -32,7 +32,14 @@ RUN apt-get update && \ > mxe-$TARGET-w64-mingw32.shared-sdl2 \ > mxe-$TARGET-w64-mingw32.shared-sdl2-mixer \ > mxe-$TARGET-w64-mingw32.shared-sdl2-gfx \ > - mxe-$TARGET-w64-mingw32.shared-zlib > + mxe-$TARGET-w64-mingw32.shared-zlib \ > + curl && \ > + curl -s -S -o /usr/lib/mxe/usr/x86_64-w64-mingw32.shared/include/WinHvEmulation.h \ > + "https://sourceforge.net/p/mingw-w64/mingw-w64/ci/master/tree/mingw-w64-headers/include/winhvemulation.h?format=raw" && \ > + curl -s -S -o /usr/lib/mxe/usr/x86_64-w64-mingw32.shared/include/WinHvPlatform.h \ > + "https://sourceforge.net/p/mingw-w64/mingw-w64/ci/master/tree/mingw-w64-headers/include/winhvplatform.h?format=raw" && \ > + curl -s -S -o /usr/lib/mxe/usr/x86_64-w64-mingw32.shared/include/winhvplatformdefs.h \ > + "https://sourceforge.net/p/mingw-w64/mingw-w64/ci/master/tree/mingw-w64-headers/include/winhvplatformdefs.h?format=raw" My only concern here is whether sourceforge.net URLs are reliable enough for CI, or whether we should instead be mirroring the w64 repo on git.qemu.org ? I guess this will be a short term issue until a new mingw release is made and arrives i nthe distros, so we can try with the curl approach for now and change if it causes problems Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|