From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19915C433E2 for ; Wed, 2 Sep 2020 16:09:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D3369207EA for ; Wed, 2 Sep 2020 16:09:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AHHq7vLW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3369207EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58200 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kDVJn-0004I0-WB for qemu-devel@archiver.kernel.org; Wed, 02 Sep 2020 12:09:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59844) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDVJ8-0003Po-Pq for qemu-devel@nongnu.org; Wed, 02 Sep 2020 12:08:22 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:33658 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kDVJ5-0000NJ-D1 for qemu-devel@nongnu.org; Wed, 02 Sep 2020 12:08:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599062897; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z9lrEPFX4+KMMYD6/HYPLMb0W9TmtyphV+vXOObFqF4=; b=AHHq7vLW1RdzXcuaoMuKdb72m2VzuBnfu9oz8MpM23sHFEUgvWUxSny2JKuHqadxSqy7nX h+uY2x2oCak4q0x4ldkv7W7UvSNc/zkY95gh4K9RIvUyb07vodnYb56OJI1MLnsIJLTHLd ytpfgY8OWAA21Bvp21ikE5v3QuhBvMI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-234-VqNp3YjDNAit1pv9orlkwg-1; Wed, 02 Sep 2020 12:08:11 -0400 X-MC-Unique: VqNp3YjDNAit1pv9orlkwg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C1B762FD0C; Wed, 2 Sep 2020 16:08:10 +0000 (UTC) Received: from redhat.com (ovpn-114-158.ams2.redhat.com [10.36.114.158]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CC48F19D7C; Wed, 2 Sep 2020 16:08:09 +0000 (UTC) Date: Wed, 2 Sep 2020 17:08:07 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Christian Schoenebeck Subject: Re: [PATCH] 9pfs: log warning if msize <= 8192 Message-ID: <20200902160807.GN403297@redhat.com> References: <2812056.Ea3xXQFrjv@silver> <20200902141035.GK403297@redhat.com> <2877776.MzA8b4DPAS@silver> MIME-Version: 1.0 In-Reply-To: <2877776.MzA8b4DPAS@silver> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline Received-SPF: pass client-ip=205.139.110.61; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/02 03:24:55 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: qemu-devel@nongnu.org, Greg Kurz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Sep 02, 2020 at 06:03:12PM +0200, Christian Schoenebeck wrote: > On Mittwoch, 2. September 2020 16:10:35 CEST Daniel P. Berrangé wrote: > > > Yeah, I know, but the problem is I don't see how I would squeeze the > > > relevant information into only one log message; and even "what's a good > > > starting point" is already questionable. > > > > > > For that reason my plan was: > > > - logging this warning > > > > > > - describing the 'msize' issue in detail on the QEMU wiki (what's the > > > > > > point, how would you benchmark it) > > > > > > So my idea was: user sees the message, "what is 'msize?'" -> Google "msize > > > qemu" -> click 'QEMU wiki' -> read all the details. > > > > > > But how about this: I put a QEMU wiki link directly into the log message? > > > > Rather than that, how about putting it in the QEMU man page, and then > > just add "See 'man 1 qemu' for further guidance". > > Well, I can do that of course. But somehow I fear users get lost by just > pointing them to "man 1 qemu" in the log message. It already starts that e.g. > on Debian there is no "man qemu", it is "man qemu-system" there instead. Next > issue is that qemu man page is currently not structured in a way that would > allow me to directly point them to the relevant man heading like: > > man --pager='less -p ^9P-msize' qemu > > So they would need to scroll their way through the entire man page by > themselfes and find confusing sections like "-fsdev -device virtio-9p-pci" vs. > "-virtfs", etc. I can imagine some people will struggle with that. > > With a link like "https://wiki.qemu.org/Documentation/9psetup#msize" the thing > would be crystal clear within seconds. I don't feel strongly either way as long as we have docs somewhere, so I won't object to either approach. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|