From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: "Fam Zheng" <fam@euphon.net>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, "Gerd Hoffmann" <kraxel@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH 3/8] i8259: Rename TYPE_I8259 to TYPE_ISA_I8259
Date: Fri, 4 Sep 2020 09:46:24 +0100 [thread overview]
Message-ID: <20200904084624.GF721059@redhat.com> (raw)
In-Reply-To: <20200903180128.1523959-4-ehabkost@redhat.com>
On Thu, Sep 03, 2020 at 02:01:23PM -0400, Eduardo Habkost wrote:
> This will make the type name constant consistent with QOM
> type name string ("isa-i8259").
>
> Suggested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Suggested-by: "Daniel P. Berrangé" <berrange@redhat.com>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Changes v1 ->v2:
> * v1 subject was "i8259: Rename TYPE_I8259 to TYPE_PIC"
> * Rename it to TYPE_ISA_I8259 instead, to be consistent
> with the QOM type name ("isa-i8259")
> ---
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: qemu-devel@nongnu.org
> ---
> hw/intc/i8259.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2020-09-04 8:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 18:01 [PATCH 0/8] qom: Rename macros for consistency (pass 2) Eduardo Habkost
2020-09-03 18:01 ` [PATCH 1/8] i8254: Rename TYPE_I8254 to TYPE_ISA_PIT Eduardo Habkost
2020-09-04 8:44 ` Daniel P. Berrangé
2020-09-03 18:01 ` [PATCH 2/8] i8254: Rename PIT to ISA_PIT Eduardo Habkost
2020-09-04 8:44 ` Daniel P. Berrangé
2020-09-03 18:01 ` [PATCH 3/8] i8259: Rename TYPE_I8259 to TYPE_ISA_I8259 Eduardo Habkost
2020-09-04 8:46 ` Daniel P. Berrangé [this message]
2020-09-03 18:01 ` [PATCH 4/8] i8259: Rename PIC to ISA_I8259 Eduardo Habkost
2020-09-04 8:48 ` Daniel P. Berrangé
2020-09-03 18:01 ` [PATCH 5/8] i8259: Rename KVM_PIC to KVM_I8259 Eduardo Habkost
2020-09-04 8:48 ` Daniel P. Berrangé
2020-09-03 18:01 ` [PATCH 6/8] esp-pci: Rename TYPE_AM53C974_DEVICE to TYPE_AM53C974 Eduardo Habkost
2020-09-04 8:48 ` Daniel P. Berrangé
2020-09-03 18:01 ` [PATCH 7/8] esp-pci: Rename PCI_ESP to AM53C974 Eduardo Habkost
2020-09-04 8:49 ` Daniel P. Berrangé
2020-09-03 18:01 ` [PATCH 8/8] tusb6010: Rename TUSB to TUSB6010 Eduardo Habkost
2020-09-03 19:17 ` Philippe Mathieu-Daudé
2020-09-04 8:50 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200904084624.GF721059@redhat.com \
--to=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).