qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: [PATCH 3/3] pci: Let pci_dma_write() propagate MemTxResult
Date: Fri,  4 Sep 2020 18:26:20 +0200	[thread overview]
Message-ID: <20200904162620.657726-4-philmd@redhat.com> (raw)
In-Reply-To: <20200904162620.657726-1-philmd@redhat.com>

pci_dma_rw() returns a MemTxResult type.
Do not discard it, return it to the caller.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 include/hw/pci/pci.h | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
index bb57525dffd..76826e240a9 100644
--- a/include/hw/pci/pci.h
+++ b/include/hw/pci/pci.h
@@ -824,8 +824,20 @@ static inline MemTxResult pci_dma_read(PCIDevice *dev, dma_addr_t addr,
     return pci_dma_rw(dev, addr, buf, len, DMA_DIRECTION_TO_DEVICE);
 }
 
-static inline int pci_dma_write(PCIDevice *dev, dma_addr_t addr,
-                                const void *buf, dma_addr_t len)
+/**
+ * pci_dma_write: Write to address space from PCI device.
+ *
+ * Return a MemTxResult indicating whether the operation succeeded
+ * or failed (eg unassigned memory, device rejected the transaction,
+ * IOMMU fault).
+ *
+ * @dev: #PCIDevice doing the memory access
+ * @addr: address within the #PCIDevice address space
+ * @buf: buffer with the data transferred
+ * @len: the number of bytes to write
+ */
+static inline MemTxResult pci_dma_write(PCIDevice *dev, dma_addr_t addr,
+                                        const void *buf, dma_addr_t len)
 {
     return pci_dma_rw(dev, addr, (void *) buf, len, DMA_DIRECTION_FROM_DEVICE);
 }
-- 
2.26.2



  parent reply	other threads:[~2020-09-04 16:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-04 16:26 [PATCH 0/3] pci: Let PCI DMA API functions propagate a MemTxResult Philippe Mathieu-Daudé
2020-09-04 16:26 ` [PATCH 1/3] pci: Let pci_dma_rw() propagate MemTxResult Philippe Mathieu-Daudé
2020-09-05  2:41   ` Li Qiang
2020-09-06  4:06   ` Richard Henderson
2020-09-04 16:26 ` [PATCH 2/3] pci: Let pci_dma_read() " Philippe Mathieu-Daudé
2020-09-05  2:42   ` Li Qiang
2020-09-06  4:07   ` Richard Henderson
2020-09-04 16:26 ` Philippe Mathieu-Daudé [this message]
2020-09-05  2:42   ` [PATCH 3/3] pci: Let pci_dma_write() " Li Qiang
2020-09-06  4:08   ` Richard Henderson
2020-09-15 17:30 ` [PATCH 0/3] pci: Let PCI DMA API functions propagate a MemTxResult Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200904162620.657726-4-philmd@redhat.com \
    --to=philmd@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).