qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cleber Rosa <crosa@redhat.com>
To: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Cc: "Thomas Huth" <thuth@redhat.com>,
	"Beraldo Leal" <bleal@redhat.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Willian Rampazzo" <wrampazz@redhat.com>,
	"Cleber Rosa" <crosa@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>
Subject: [PATCH 4/7] scripts/ci/gitlab-pipeline-status: refactor parser creation
Date: Fri,  4 Sep 2020 12:42:55 -0400	[thread overview]
Message-ID: <20200904164258.240278-5-crosa@redhat.com> (raw)
In-Reply-To: <20200904164258.240278-1-crosa@redhat.com>

Out of the main function.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
 scripts/ci/gitlab-pipeline-status | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/scripts/ci/gitlab-pipeline-status b/scripts/ci/gitlab-pipeline-status
index 18609553be..8355b6a427 100755
--- a/scripts/ci/gitlab-pipeline-status
+++ b/scripts/ci/gitlab-pipeline-status
@@ -89,10 +89,7 @@ def wait_on_pipeline_success(timeout, interval,
         return False
 
 
-def main():
-    """
-    Script entry point
-    """
+def create_parser():
     parser = argparse.ArgumentParser(
         prog='pipeline-status',
         description='check or wait on a pipeline status')
@@ -127,7 +124,13 @@ def main():
     parser.add_argument('--verbose', action='store_true', default=False,
                         help=('A minimal verbosity level that prints the '
                               'overall result of the check/wait'))
+    return parser
 
+def main():
+    """
+    Script entry point
+    """
+    parser = create_parser()
     args = parser.parse_args()
 
     try:
-- 
2.25.4



  parent reply	other threads:[~2020-09-04 16:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-04 16:42 [PATCH 0/7] gitlab pipeline check/watch script improvements Cleber Rosa
2020-09-04 16:42 ` [PATCH 1/7] scripts/ci/gitlab-pipeline-status: make branch name configurable Cleber Rosa
2020-09-04 17:01   ` Philippe Mathieu-Daudé
2020-09-04 16:42 ` [PATCH 2/7] scripts/ci/gitlab-pipeline-status: improve message regarding timeout Cleber Rosa
2020-09-04 16:53   ` Philippe Mathieu-Daudé
2020-09-04 16:42 ` [PATCH 3/7] scripts/ci/gitlab-pipeline-status: give early feedback on running pipelines Cleber Rosa
2020-09-04 16:59   ` Philippe Mathieu-Daudé
2020-09-04 16:42 ` Cleber Rosa [this message]
2020-09-04 16:42 ` [PATCH 5/7] scripts/ci/gitlab-pipeline-status: handle keyboard interrupts Cleber Rosa
2020-09-04 16:42 ` [PATCH 6/7] scripts/ci/gitlab-pipeline-status: use more descriptive exceptions Cleber Rosa
2020-09-04 16:42 ` [PATCH 7/7] scripts/ci/gitlab-pipeline-status: wait for pipeline creation Cleber Rosa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200904164258.240278-5-crosa@redhat.com \
    --to=crosa@redhat.com \
    --cc=bleal@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    --cc=wrampazz@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).