* [PATCH] tests: fixes test-vmstate.c compile error on msys2
@ 2020-09-05 6:38 Yonggang Luo
2020-09-05 8:48 ` Thomas Huth
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Yonggang Luo @ 2020-09-05 6:38 UTC (permalink / raw)
To: qemu-devel
Cc: Paolo Bonzini, Yonggang Luo, Dr . David Alan Gilbert,
Juan Quintela
../tests/test-vmstate.c: In function 'int_cmp':
../tests/test-vmstate.c:884:5: error: unknown type name 'uint'; did you mean 'uInt'?
884 | uint ua = GPOINTER_TO_UINT(a);
| ^~~~
| uInt
../tests/test-vmstate.c:885:5: error: unknown type name 'uint'; did you mean 'uInt'?
885 | uint ub = GPOINTER_TO_UINT(b);
| ^~~~
| uInt
make: *** [Makefile.ninja:5461：tests/test-vmstate.exe.p/test-vmstate.c.obj] 错误 1
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
---
tests/test-vmstate.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
index f7b3868881..f8de709a0b 100644
--- a/tests/test-vmstate.c
+++ b/tests/test-vmstate.c
@@ -881,8 +881,8 @@ static gint interval_cmp(gconstpointer a, gconstpointer b, gpointer user_data)
/* ID comparison function */
static gint int_cmp(gconstpointer a, gconstpointer b, gpointer user_data)
{
- uint ua = GPOINTER_TO_UINT(a);
- uint ub = GPOINTER_TO_UINT(b);
+ guint ua = GPOINTER_TO_UINT(a);
+ guint ub = GPOINTER_TO_UINT(b);
return (ua > ub) - (ua < ub);
}
--
2.28.0.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] tests: fixes test-vmstate.c compile error on msys2
2020-09-05 6:38 [PATCH] tests: fixes test-vmstate.c compile error on msys2 Yonggang Luo
@ 2020-09-05 8:48 ` Thomas Huth
2020-09-05 16:16 ` 罗勇刚(Yonggang Luo)
2020-09-05 21:33 ` Philippe Mathieu-Daudé
2020-09-07 2:57 ` 罗勇刚(Yonggang Luo)
2 siblings, 1 reply; 6+ messages in thread
From: Thomas Huth @ 2020-09-05 8:48 UTC (permalink / raw)
To: Yonggang Luo, qemu-devel
Cc: QEMU Trivial, Paolo Bonzini, Dr . David Alan Gilbert,
Juan Quintela
On 05/09/2020 08.38, Yonggang Luo wrote:
> ../tests/test-vmstate.c: In function 'int_cmp':
> ../tests/test-vmstate.c:884:5: error: unknown type name 'uint'; did you mean 'uInt'?
> 884 | uint ua = GPOINTER_TO_UINT(a);
> | ^~~~
> | uInt
> ../tests/test-vmstate.c:885:5: error: unknown type name 'uint'; did you mean 'uInt'?
> 885 | uint ub = GPOINTER_TO_UINT(b);
> | ^~~~
> | uInt
> make: *** [Makefile.ninja:5461：tests/test-vmstate.exe.p/test-vmstate.c.obj] 错误 1
>
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> ---
> tests/test-vmstate.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
> index f7b3868881..f8de709a0b 100644
> --- a/tests/test-vmstate.c
> +++ b/tests/test-vmstate.c
> @@ -881,8 +881,8 @@ static gint interval_cmp(gconstpointer a, gconstpointer b, gpointer user_data)
> /* ID comparison function */
> static gint int_cmp(gconstpointer a, gconstpointer b, gpointer user_data)
> {
> - uint ua = GPOINTER_TO_UINT(a);
> - uint ub = GPOINTER_TO_UINT(b);
> + guint ua = GPOINTER_TO_UINT(a);
> + guint ub = GPOINTER_TO_UINT(b);
> return (ua > ub) - (ua < ub);
> }
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] tests: fixes test-vmstate.c compile error on msys2
2020-09-05 8:48 ` Thomas Huth
@ 2020-09-05 16:16 ` 罗勇刚(Yonggang Luo)
2020-09-05 16:32 ` Thomas Huth
0 siblings, 1 reply; 6+ messages in thread
From: 罗勇刚(Yonggang Luo) @ 2020-09-05 16:16 UTC (permalink / raw)
To: Thomas Huth
Cc: QEMU Trivial, Paolo Bonzini, Juan Quintela, qemu-level,
Dr . David Alan Gilbert
[-- Attachment #1: Type: text/plain, Size: 1635 bytes --]
On Sat, Sep 5, 2020 at 4:48 PM Thomas Huth <thuth@redhat.com> wrote:
> On 05/09/2020 08.38, Yonggang Luo wrote:
> > ../tests/test-vmstate.c: In function 'int_cmp':
> > ../tests/test-vmstate.c:884:5: error: unknown type name 'uint'; did you
> mean 'uInt'?
> > 884 | uint ua = GPOINTER_TO_UINT(a);
> > | ^~~~
> > | uInt
> > ../tests/test-vmstate.c:885:5: error: unknown type name 'uint'; did you
> mean 'uInt'?
> > 885 | uint ub = GPOINTER_TO_UINT(b);
> > | ^~~~
> > | uInt
> > make: ***
> [Makefile.ninja:5461：tests/test-vmstate.exe.p/test-vmstate.c.obj] 错误 1
> >
> > Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> > ---
> > tests/test-vmstate.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
> > index f7b3868881..f8de709a0b 100644
> > --- a/tests/test-vmstate.c
> > +++ b/tests/test-vmstate.c
> > @@ -881,8 +881,8 @@ static gint interval_cmp(gconstpointer a,
> gconstpointer b, gpointer user_data)
> > /* ID comparison function */
> > static gint int_cmp(gconstpointer a, gconstpointer b, gpointer
> user_data)
> > {
> > - uint ua = GPOINTER_TO_UINT(a);
> > - uint ub = GPOINTER_TO_UINT(b);
> > + guint ua = GPOINTER_TO_UINT(a);
> > + guint ub = GPOINTER_TO_UINT(b);
> > return (ua > ub) - (ua < ub);
> > }
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
> Does this means quened or to be queued, if that's true, will skip this
next revision
--
此致
礼
罗勇刚
Yours
sincerely,
Yonggang Luo
[-- Attachment #2: Type: text/html, Size: 2412 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] tests: fixes test-vmstate.c compile error on msys2
2020-09-05 16:16 ` 罗勇刚(Yonggang Luo)
@ 2020-09-05 16:32 ` Thomas Huth
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Huth @ 2020-09-05 16:32 UTC (permalink / raw)
To: luoyonggang
Cc: Juan Quintela, QEMU Trivial, qemu-level, Dr . David Alan Gilbert,
Paolo Bonzini, Alex Bennée
On 05/09/2020 18.16, 罗勇刚(Yonggang Luo) wrote:
>
>
> On Sat, Sep 5, 2020 at 4:48 PM Thomas Huth <thuth@redhat.com
> <mailto:thuth@redhat.com>> wrote:
>
> On 05/09/2020 08.38, Yonggang Luo wrote:
> > ../tests/test-vmstate.c: In function 'int_cmp':
> > ../tests/test-vmstate.c:884:5: error: unknown type name 'uint';
> did you mean 'uInt'?
> > 884 | uint ua = GPOINTER_TO_UINT(a);
> > | ^~~~
> > | uInt
> > ../tests/test-vmstate.c:885:5: error: unknown type name 'uint';
> did you mean 'uInt'?
> > 885 | uint ub = GPOINTER_TO_UINT(b);
> > | ^~~~
> > | uInt
> > make: *** [Makefile.ninja:5461：tests/test-vmstate.exe.p/test-
> vmstate.c.obj] 错误 1
> >
> > Signed-off-by: Yonggang Luo <luoyonggang@gmail.com
> <mailto:luoyonggang@gmail.com>>
> > ---
> > tests/test-vmstate.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
> > index f7b3868881..f8de709a0b 100644
> > --- a/tests/test-vmstate.c
> > +++ b/tests/test-vmstate.c
> > @@ -881,8 +881,8 @@ static gint interval_cmp(gconstpointer a,
> gconstpointer b, gpointer user_data)
> > /* ID comparison function */
> > static gint int_cmp(gconstpointer a, gconstpointer b, gpointer
> user_data)
> > {
> > - uint ua = GPOINTER_TO_UINT(a);
> > - uint ub = GPOINTER_TO_UINT(b);
> > + guint ua = GPOINTER_TO_UINT(a);
> > + guint ub = GPOINTER_TO_UINT(b);
> > return (ua > ub) - (ua < ub);
> > }
>
> Reviewed-by: Thomas Huth <thuth@redhat.com <mailto:thuth@redhat.com>>
>
> Does this means quened or to be queued, if that's true, will skip this
> next revision
No, "Reviewed-by" just means that somebody looked at the patch and
thinks it is right. It does not mean that it is queued yet, but it
certainly helps that the patch gets accepted.
But I've also put the qemu-trivial mailing list on CC: - trivial paches
like this can often get picked up more easily via the trivial queue.
Otherwise this should maybe get merged via the migration tree, or Alex'
or my testing tree.
Thomas
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tests: fixes test-vmstate.c compile error on msys2
2020-09-05 6:38 [PATCH] tests: fixes test-vmstate.c compile error on msys2 Yonggang Luo
2020-09-05 8:48 ` Thomas Huth
@ 2020-09-05 21:33 ` Philippe Mathieu-Daudé
2020-09-07 2:57 ` 罗勇刚(Yonggang Luo)
2 siblings, 0 replies; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-09-05 21:33 UTC (permalink / raw)
To: Yonggang Luo, qemu-devel
Cc: Paolo Bonzini, Dr . David Alan Gilbert, Juan Quintela
On 9/5/20 8:38 AM, Yonggang Luo wrote:
> ../tests/test-vmstate.c: In function 'int_cmp':
> ../tests/test-vmstate.c:884:5: error: unknown type name 'uint'; did you mean 'uInt'?
> 884 | uint ua = GPOINTER_TO_UINT(a);
> | ^~~~
> | uInt
> ../tests/test-vmstate.c:885:5: error: unknown type name 'uint'; did you mean 'uInt'?
> 885 | uint ub = GPOINTER_TO_UINT(b);
> | ^~~~
> | uInt
> make: *** [Makefile.ninja:5461：tests/test-vmstate.exe.p/test-vmstate.c.obj] 错误 1
>
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> tests/test-vmstate.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
> index f7b3868881..f8de709a0b 100644
> --- a/tests/test-vmstate.c
> +++ b/tests/test-vmstate.c
> @@ -881,8 +881,8 @@ static gint interval_cmp(gconstpointer a, gconstpointer b, gpointer user_data)
> /* ID comparison function */
> static gint int_cmp(gconstpointer a, gconstpointer b, gpointer user_data)
> {
> - uint ua = GPOINTER_TO_UINT(a);
> - uint ub = GPOINTER_TO_UINT(b);
> + guint ua = GPOINTER_TO_UINT(a);
> + guint ub = GPOINTER_TO_UINT(b);
> return (ua > ub) - (ua < ub);
> }
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] tests: fixes test-vmstate.c compile error on msys2
2020-09-05 6:38 [PATCH] tests: fixes test-vmstate.c compile error on msys2 Yonggang Luo
2020-09-05 8:48 ` Thomas Huth
2020-09-05 21:33 ` Philippe Mathieu-Daudé
@ 2020-09-07 2:57 ` 罗勇刚(Yonggang Luo)
2 siblings, 0 replies; 6+ messages in thread
From: 罗勇刚(Yonggang Luo) @ 2020-09-07 2:57 UTC (permalink / raw)
To: qemu-level, Paolo Bonzini; +Cc: Dr . David Alan Gilbert, Juan Quintela
[-- Attachment #1: Type: text/plain, Size: 1466 bytes --]
Bonzini, you need have a look at this
On Sat, Sep 5, 2020 at 2:38 PM Yonggang Luo <luoyonggang@gmail.com> wrote:
> ../tests/test-vmstate.c: In function 'int_cmp':
> ../tests/test-vmstate.c:884:5: error: unknown type name 'uint'; did you
> mean 'uInt'?
> 884 | uint ua = GPOINTER_TO_UINT(a);
> | ^~~~
> | uInt
> ../tests/test-vmstate.c:885:5: error: unknown type name 'uint'; did you
> mean 'uInt'?
> 885 | uint ub = GPOINTER_TO_UINT(b);
> | ^~~~
> | uInt
> make: ***
> [Makefile.ninja:5461：tests/test-vmstate.exe.p/test-vmstate.c.obj] 错误 1
>
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> ---
> tests/test-vmstate.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
> index f7b3868881..f8de709a0b 100644
> --- a/tests/test-vmstate.c
> +++ b/tests/test-vmstate.c
> @@ -881,8 +881,8 @@ static gint interval_cmp(gconstpointer a,
> gconstpointer b, gpointer user_data)
> /* ID comparison function */
> static gint int_cmp(gconstpointer a, gconstpointer b, gpointer user_data)
> {
> - uint ua = GPOINTER_TO_UINT(a);
> - uint ub = GPOINTER_TO_UINT(b);
> + guint ua = GPOINTER_TO_UINT(a);
> + guint ub = GPOINTER_TO_UINT(b);
> return (ua > ub) - (ua < ub);
> }
>
> --
> 2.28.0.windows.1
>
>
--
此致
礼
罗勇刚
Yours
sincerely,
Yonggang Luo
[-- Attachment #2: Type: text/html, Size: 2071 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-07 2:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-05 6:38 [PATCH] tests: fixes test-vmstate.c compile error on msys2 Yonggang Luo
2020-09-05 8:48 ` Thomas Huth
2020-09-05 16:16 ` 罗勇刚(Yonggang Luo)
2020-09-05 16:32 ` Thomas Huth
2020-09-05 21:33 ` Philippe Mathieu-Daudé
2020-09-07 2:57 ` 罗勇刚(Yonggang Luo)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).