From: Cornelia Huck <cohuck@redhat.com>
To: Eric Auger <eric.auger@redhat.com>
Cc: jean-philippe@linaro.org, thuth@redhat.com, mst@redhat.com,
qemu-stable@nongnu.org, qemu-devel@nongnu.org,
eric.auger.pro@gmail.com
Subject: Re: [PATCH 1/2] virtio-iommu: Check gtrees are non null before destroying them
Date: Mon, 7 Sep 2020 18:09:25 +0200 [thread overview]
Message-ID: <20200907180925.47a405a8.cohuck@redhat.com> (raw)
In-Reply-To: <20200902131152.1219-2-eric.auger@redhat.com>
On Wed, 2 Sep 2020 15:11:51 +0200
Eric Auger <eric.auger@redhat.com> wrote:
> If realize fails, domains and endpoints trees may be NULL. On
> unrealize(), this produces asseryions:
s/asseryions/assertions/
> "GLib: g_tree_destroy: assertion 'tree != NULL' failed"
>
> Check the tree are non NULL before destroying them.
s/the tree/that the trees/
>
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
> ---
> hw/virtio/virtio-iommu.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
Good to see that the version checking has flushed out a bug :)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2020-09-07 16:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 13:11 [PATCH 0/2] virtio-iommu-pci: Advertise the device as modern-only Eric Auger
2020-09-02 13:11 ` [PATCH 1/2] virtio-iommu: Check gtrees are non null before destroying them Eric Auger
2020-09-07 16:09 ` Cornelia Huck [this message]
2020-09-02 13:11 ` [PATCH 2/2] virtio-iommu-pci: force virtio version 1 Eric Auger
2020-09-07 16:12 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200907180925.47a405a8.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=jean-philippe@linaro.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).