From: Halil Pasic <pasic@linux.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Michael Roth <mdroth@linux.vnet.ibm.com>,
Andre Wild <Andre.Wild1@ibm.com>,
qemu-devel@nongnu.org, qemu-stable <qemu-stable@nongnu.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org
Subject: Re: [PULL 13/14] virtio-ccw: fix virtio_set_ind_atomic
Date: Tue, 8 Sep 2020 11:34:28 +0200 [thread overview]
Message-ID: <20200908113428.6eb68d8e.pasic@linux.ibm.com> (raw)
In-Reply-To: <20200703100650.621212-14-cohuck@redhat.com>
On Fri, 3 Jul 2020 12:06:49 +0200
Cornelia Huck <cohuck@redhat.com> wrote:
> From: Halil Pasic <pasic@linux.ibm.com>
>
> The atomic_cmpxchg() loop is broken because we occasionally end up with
> old and _old having different values (a legit compiler can generate code
> that accessed *ind_addr again to pick up a value for _old instead of
> using the value of old that was already fetched according to the
> rules of the abstract machine). This means the underlying CS instruction
> may use a different old (_old) than the one we intended to use if
> atomic_cmpxchg() performed the xchg part.
>
[..]
I believe this fix should be considered for stable. Unfortunately we
didn't think about it back then.
Regards,
Halil
next prev parent reply other threads:[~2020-09-08 9:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 10:06 [PULL 00/14] s390x update Cornelia Huck
2020-07-03 10:06 ` [PULL 01/14] pc-bios: s390x: cio.c cleanup and compile fix Cornelia Huck
2020-07-03 10:06 ` [PULL 02/14] pc-bios: s390x: Consolidate timing functions into time.h Cornelia Huck
2020-07-03 10:06 ` [PULL 03/14] pc-bios: s390x: Move sleep and yield to helper.h Cornelia Huck
2020-07-03 10:06 ` [PULL 04/14] pc-bios: s390x: Get rid of magic offsets into the lowcore Cornelia Huck
2020-07-03 10:06 ` [PULL 05/14] pc-bios: s390x: Rename PSW_MASK_ZMODE to PSW_MASK_64 Cornelia Huck
2020-07-03 10:06 ` [PULL 06/14] pc-bios: s390x: Use PSW masks where possible and introduce PSW_MASK_SHORT_ADDR Cornelia Huck
2020-07-03 10:06 ` [PULL 07/14] pc-bios: s390x: Move panic() into header and add infinite loop Cornelia Huck
2020-07-03 10:06 ` [PULL 08/14] pc-bios: s390x: Use ebcdic2ascii table Cornelia Huck
2020-07-03 10:06 ` [PULL 09/14] pc-bios: s390x: Make u32 ptr check explicit Cornelia Huck
2020-07-03 10:06 ` [PULL 10/14] pc-bios/s390-ccw: Generate and include dependency files in the Makefile Cornelia Huck
2020-07-03 10:06 ` [PULL 11/14] pc-bios/s390: Update s390-ccw bios binaries with the latest changes Cornelia Huck
2020-07-03 10:06 ` [PULL 12/14] target/s390x: Fix SQXBR Cornelia Huck
2020-07-03 10:06 ` [PULL 13/14] virtio-ccw: fix virtio_set_ind_atomic Cornelia Huck
2020-07-06 11:23 ` Halil Pasic
2020-07-06 11:38 ` Cornelia Huck
2020-09-08 9:34 ` Halil Pasic [this message]
2020-07-03 10:06 ` [PULL 14/14] s390x/pci: fix set_ind_atomic Cornelia Huck
2020-07-06 11:23 ` Halil Pasic
2020-09-08 9:36 ` Halil Pasic
2020-07-03 10:46 ` [PULL 00/14] s390x update no-reply
2020-07-04 13:58 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908113428.6eb68d8e.pasic@linux.ibm.com \
--to=pasic@linux.ibm.com \
--cc=Andre.Wild1@ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).