* [PATCH] hw/core/cpu: Add missing 'exec/cpu-common.h' include
@ 2020-09-08 12:34 Philippe Mathieu-Daudé
2020-10-01 17:44 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-09-08 12:34 UTC (permalink / raw)
To: qemu-devel
Cc: Eduardo Habkost, qemu-trivial, Paolo Bonzini,
Philippe Mathieu-Daudé, Richard Henderson
cpu_common_reset() uses tcg_flush_softmmu_tlb() which is
declared in "exec/cpu-common.h". Add the missing header
to avoid when refactoring other headers:
hw/core/cpu.c: In function ‘cpu_common_reset’:
hw/core/cpu.c:273:9: error: implicit declaration of function ‘tcg_flush_softmmu_tlb’ [-Werror=implicit-function-declaration]
273 | tcg_flush_softmmu_tlb(cpu);
| ^~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/core/cpu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/core/cpu.c b/hw/core/cpu.c
index 22bc3f974a2..63ece3662d6 100644
--- a/hw/core/cpu.c
+++ b/hw/core/cpu.c
@@ -26,6 +26,7 @@
#include "qemu/log.h"
#include "qemu/main-loop.h"
#include "exec/log.h"
+#include "exec/cpu-common.h"
#include "qemu/error-report.h"
#include "qemu/qemu-print.h"
#include "sysemu/tcg.h"
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] hw/core/cpu: Add missing 'exec/cpu-common.h' include
2020-09-08 12:34 [PATCH] hw/core/cpu: Add missing 'exec/cpu-common.h' include Philippe Mathieu-Daudé
@ 2020-10-01 17:44 ` Philippe Mathieu-Daudé
2020-10-01 17:56 ` Eduardo Habkost
0 siblings, 1 reply; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-10-01 17:44 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-trivial, Paolo Bonzini, Eduardo Habkost, Richard Henderson
ping?
On 9/8/20 2:34 PM, Philippe Mathieu-Daudé wrote:
> cpu_common_reset() uses tcg_flush_softmmu_tlb() which is
> declared in "exec/cpu-common.h". Add the missing header
> to avoid when refactoring other headers:
>
> hw/core/cpu.c: In function ‘cpu_common_reset’:
> hw/core/cpu.c:273:9: error: implicit declaration of function ‘tcg_flush_softmmu_tlb’ [-Werror=implicit-function-declaration]
> 273 | tcg_flush_softmmu_tlb(cpu);
> | ^~~~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/core/cpu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/core/cpu.c b/hw/core/cpu.c
> index 22bc3f974a2..63ece3662d6 100644
> --- a/hw/core/cpu.c
> +++ b/hw/core/cpu.c
> @@ -26,6 +26,7 @@
> #include "qemu/log.h"
> #include "qemu/main-loop.h"
> #include "exec/log.h"
> +#include "exec/cpu-common.h"
> #include "qemu/error-report.h"
> #include "qemu/qemu-print.h"
> #include "sysemu/tcg.h"
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/core/cpu: Add missing 'exec/cpu-common.h' include
2020-10-01 17:44 ` Philippe Mathieu-Daudé
@ 2020-10-01 17:56 ` Eduardo Habkost
0 siblings, 0 replies; 3+ messages in thread
From: Eduardo Habkost @ 2020-10-01 17:56 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: qemu-trivial, Paolo Bonzini, qemu-devel, Richard Henderson
On Thu, Oct 01, 2020 at 07:44:57PM +0200, Philippe Mathieu-Daudé wrote:
> ping?
>
> On 9/8/20 2:34 PM, Philippe Mathieu-Daudé wrote:
> > cpu_common_reset() uses tcg_flush_softmmu_tlb() which is
> > declared in "exec/cpu-common.h". Add the missing header
> > to avoid when refactoring other headers:
> >
> > hw/core/cpu.c: In function ‘cpu_common_reset’:
> > hw/core/cpu.c:273:9: error: implicit declaration of function ‘tcg_flush_softmmu_tlb’ [-Werror=implicit-function-declaration]
> > 273 | tcg_flush_softmmu_tlb(cpu);
> > | ^~~~~~~~~~~~~~~~~~~~~
> >
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Qeueued, thanks!
--
Eduardo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-01 18:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-08 12:34 [PATCH] hw/core/cpu: Add missing 'exec/cpu-common.h' include Philippe Mathieu-Daudé
2020-10-01 17:44 ` Philippe Mathieu-Daudé
2020-10-01 17:56 ` Eduardo Habkost
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).