From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4035C43461 for ; Wed, 9 Sep 2020 10:22:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3CB4521D7A for ; Wed, 9 Sep 2020 10:22:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="c8Fv9QcB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3CB4521D7A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58432 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFxF4-0001Y8-B2 for qemu-devel@archiver.kernel.org; Wed, 09 Sep 2020 06:22:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36932) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFxEW-000181-1o for qemu-devel@nongnu.org; Wed, 09 Sep 2020 06:21:44 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:56580 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kFxEU-0003hj-G4 for qemu-devel@nongnu.org; Wed, 09 Sep 2020 06:21:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599646901; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6CMfw9AFmKKliSBTI/wBxQyftyr7u8kUDqC9QgDK78Q=; b=c8Fv9QcBpiFcJ0ZLMwH7ZEnpntTV6JCsc9ALqXUb46T+5nvprbQXnaJxx3iqHBGSt9CuW2 3ASE4kgpv1qQPbcdQPDhuS/CzXpCFxSlFnOfXnIIApSwNDe/lQCiifwfq1IRaioqFxMU02 yNBs2WHsQnDBf94tLYa2pdq9tEqGyaA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-513-Mmzyf-h5Ma2dqA8hjSOK4Q-1; Wed, 09 Sep 2020 06:21:40 -0400 X-MC-Unique: Mmzyf-h5Ma2dqA8hjSOK4Q-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2213D5204 for ; Wed, 9 Sep 2020 10:21:39 +0000 (UTC) Received: from work-vm (ovpn-114-246.ams2.redhat.com [10.36.114.246]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 237BC5D9EF; Wed, 9 Sep 2020 10:21:32 +0000 (UTC) Date: Wed, 9 Sep 2020 11:21:30 +0100 From: "Dr. David Alan Gilbert" To: Peter Xu Subject: Re: [PATCH v2 1/6] migration: Properly destroy variables on incoming side Message-ID: <20200909102130.GD2866@work-vm> References: <20200908203022.341615-1-peterx@redhat.com> <20200908203022.341615-2-peterx@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200908203022.341615-2-peterx@redhat.com> User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=207.211.31.81; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/09 02:43:02 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Xiaohui Li , qemu-devel@nongnu.org, Juan Quintela Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Peter Xu (peterx@redhat.com) wrote: > In migration_incoming_state_destroy(), we've got a few variables that aren't > destroyed properly, namely: > > main_thread_load_event > postcopy_pause_sem_dst > postcopy_pause_sem_fault > rp_mutex > > Destroy them properly. > > Signed-off-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert > --- > migration/migration.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/migration/migration.c b/migration/migration.c > index 58a5452471..749d9b145b 100644 > --- a/migration/migration.c > +++ b/migration/migration.c > @@ -238,12 +238,15 @@ void migration_incoming_state_destroy(void) > mis->postcopy_remote_fds = NULL; > } > > - qemu_event_reset(&mis->main_thread_load_event); > - > if (mis->socket_address_list) { > qapi_free_SocketAddressList(mis->socket_address_list); > mis->socket_address_list = NULL; > } > + > + qemu_event_destroy(&mis->main_thread_load_event); > + qemu_sem_destroy(&mis->postcopy_pause_sem_dst); > + qemu_sem_destroy(&mis->postcopy_pause_sem_fault); > + qemu_mutex_destroy(&mis->rp_mutex); > } > > static void migrate_generate_event(int new_state) > -- > 2.26.2 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK