From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: fam@euphon.net, berrange@redhat.com,
"Alex Bennée" <alex.bennee@linaro.org>,
richard.henderson@linaro.org, f4bug@amsat.org,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
cota@braap.org, "Gerd Hoffmann" <kraxel@redhat.com>,
aurelien@aurel32.net
Subject: [PATCH v2 02/10] usb-host: restrict workaround to new libusb versions
Date: Wed, 9 Sep 2020 12:27:33 +0100 [thread overview]
Message-ID: <20200909112742.25730-3-alex.bennee@linaro.org> (raw)
In-Reply-To: <20200909112742.25730-1-alex.bennee@linaro.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Fixes build failures with old kernels (USBDEVFS_GET_SPEED missing),
on the assumtion that distros with old kernels also have old libusb.
Reported-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200902081445.3291-1-kraxel@redhat.com>
Message-Id: <20200903112107.27367-5-alex.bennee@linaro.org>
---
hw/usb/host-libusb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c
index 08604f787fd..c5d38cb09c0 100644
--- a/hw/usb/host-libusb.c
+++ b/hw/usb/host-libusb.c
@@ -942,7 +942,7 @@ static int usb_host_open(USBHostDevice *s, libusb_device *dev, int hostfd)
usb_host_ep_update(s);
libusb_speed = libusb_get_device_speed(dev);
-#ifdef CONFIG_LINUX
+#if LIBUSB_API_VERSION >= 0x01000107 && defined(CONFIG_LINUX)
if (hostfd && libusb_speed == 0) {
/*
* Workaround libusb bug: libusb_get_device_speed() does not
--
2.20.1
next prev parent reply other threads:[~2020-09-09 11:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 11:27 [PATCH v2 00/10] testing and misc updates Alex Bennée
2020-09-09 11:27 ` [PATCH v2 01/10] CODING_STYLE.rst: flesh out our naming conventions Alex Bennée
2020-09-09 13:44 ` Thomas Huth
2020-09-09 11:27 ` Alex Bennée [this message]
2020-09-09 11:27 ` [PATCH v2 03/10] tests/meson.build: fp tests don't need CONFIG_TCG Alex Bennée
2020-09-09 13:03 ` Philippe Mathieu-Daudé
2020-09-09 11:27 ` [PATCH v2 04/10] target/mips: simplify gen_compute_imm_branch logic Alex Bennée
2020-09-09 11:27 ` [PATCH v2 05/10] docs/system/deprecated: mark ppc64abi32-linux-user for deprecation Alex Bennée
2020-09-09 12:59 ` Philippe Mathieu-Daudé
2020-09-09 11:27 ` [PATCH v2 06/10] configure: don't enable ppc64abi32-linux-user by default Alex Bennée
2020-09-09 12:57 ` Philippe Mathieu-Daudé
2020-09-09 11:27 ` [PATCH v2 07/10] hw/i386: make explicit clearing of pch_rev_id Alex Bennée
2020-09-09 12:58 ` Philippe Mathieu-Daudé
2020-09-09 11:27 ` [PATCH v2 08/10] tests: bump avocado version Alex Bennée
2020-09-09 11:27 ` [PATCH v2 09/10] tests/acceptance: Add Test.fetch_asset(cancel_on_missing=True) Alex Bennée
2020-09-09 11:27 ` [PATCH v2 10/10] plugins: move the more involved plugins to contrib Alex Bennée
2020-09-09 13:57 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909112742.25730-3-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=cota@braap.org \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=kraxel@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).