From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Yonggang Luo <luoyonggang@gmail.com>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH] tests: Fixes building test-util-filemonitor.c on msys2/mingw
Date: Wed, 9 Sep 2020 13:23:39 +0100 [thread overview]
Message-ID: <20200909122339.GR1011023@redhat.com> (raw)
In-Reply-To: <20200905203425.1470-1-luoyonggang@gmail.com>
On Sun, Sep 06, 2020 at 04:34:25AM +0800, Yonggang Luo wrote:
> Fixes the following compiling error:
> ../tests/test-util-filemonitor.c: In function 'test_file_monitor_events':
> ../tests/test-util-filemonitor.c:620:17: error: too many arguments to function 'mkdir'
> 620 | if (mkdir(pathsrc, 0700) < 0) {
> | ^~~~~
> In file included from C:/CI-Tools/msys64/mingw64/x86_64-w64-mingw32/include/unistd.h:10,
> from C:/work/xemu/qemu/include/qemu/osdep.h:93,
> from ../tests/test-util-filemonitor.c:21:
> C:/CI-Tools/msys64/mingw64/x86_64-w64-mingw32/include/io.h:282:15: note: declared here
> 282 | int __cdecl mkdir (const char *) __MINGW_ATTRIB_DEPRECATED_MSVC2005;
> | ^~~~~
>
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> ---
> tests/test-util-filemonitor.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2020-09-09 12:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-05 20:34 [PATCH] tests: Fixes building test-util-filemonitor.c on msys2/mingw Yonggang Luo
2020-09-06 2:14 ` Richard Henderson
2020-09-09 12:23 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909122339.GR1011023@redhat.com \
--to=berrange@redhat.com \
--cc=luoyonggang@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).